Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] use internal /run for pid and pickle files #1569

Merged
merged 3 commits into from
May 12, 2015
Merged

[core] use internal /run for pid and pickle files #1569

merged 3 commits into from
May 12, 2015

Commits on May 12, 2015

  1. [core] use internal /run for temp files 

    Added it to pidfile (instead of `/var/run/dd-agent`) and pickle
files, as it should fix all issues with `dd-agent info` reporting
incorrectly. It doesn't break anything, as it checks first to see if
the internal `/run` exists, and fallback to the current behaviour if
not. (ie `tempfile.gettempdir()`)

Also:
- move PidFile and Platform from util.py to their own files in `utils/`
- as a consequence, move `checks/utils.py` into `utils/tailfile.py`
    @degemer
    degemer committed May 12, 2015
    Configuration menu
    Copy the full SHA
    6cb37ec View commit details
    Browse the repository at this point in the history

  2. [core] only start collector/dogstatsd when needed 

    Before any call to `agent.py` or `dogstatsd.py` would actually create a
`Agent` or `Dogstatsd` instance, without doing anaything with it (and
diplaying a message about its pidfile).

This commit changes this behaviour and only create them when needed.
    @degemer
    degemer committed May 12, 2015
    Configuration menu
    Copy the full SHA
    6757c35 View commit details
    Browse the repository at this point in the history

  3. [core] remove old option --clean 

    It's a legacy command which shouldn't be needed after #1435
    @degemer
    degemer committed May 12, 2015
    Configuration menu
    Copy the full SHA
    e25f5c8 View commit details
    Browse the repository at this point in the history