Http check additions #375
Http check additions #375
Conversation
ghost
assigned 
|
@remh what do you think? |
| @@ -84,6 +84,16 @@ def _create_status_event(self, status, msg, instance): | |||
| notify_message = " ".join(notify_list) + " \n" | |||
|
|
|||
| if status == Status.DOWN: | |||
| # format the HTTP response body into the event | |||
| code, reason, content = msg | |||
There was a problem hiding this comment.
This code will fail with a ValueError in case we got a Status.DOWN which was not raised by a response.code > 400 (e.g. a socket timeout: https://github.com/dcrosta/dd-agent/blob/c111602b02ceae75f1447dc2986489e07e58818d/checks.d/http_check.py#L32) as it won't return a triplet
There was a problem hiding this comment.
(See the travis build: https://travis-ci.org/DataDog/dd-agent/jobs/4804845 for an example of failure)
There was a problem hiding this comment.
Yikes, good point. Thanks for catching this.
|
It's a good idea, it needs a few fixes though but it's definitely a good thing to have. |
|
Thanks a lot @dcrosta by the way ! :) |
|
That is, a flag in the conf.d/http_check.yaml file -- something like |
|
@dcrosta : I agree, the response should only be included if the flag is on as 200 characters of plain html code will be hard to read. |
|
Done :) |
| content = content[:197] + '...' | ||
| content = content.replace('<', '<').replace('>', '>') | ||
|
|
||
| msg = "%d %s\n\n%s" % (code, reason, content) |
There was a problem hiding this comment.
last thing before we merge.
Why do you need this line ?
With this line the created event on datadog is full of < instead of proper < >.
It will be good to merge once it's removed! Thanks
There was a problem hiding this comment.
Which line?
If you mean L98: I wasn't sure if datadog will escape the HTML on display or not, and wanted to be safe. If it does do this, then, yes, we should remove it.
If you mean L100 -- then I'm not sure I understand the question.
There was a problem hiding this comment.
Yes L98. Sorry I put the comment on the wrong line :$
There was a problem hiding this comment.
OK. And DataDog's web UI escapes the HTML (including possibly malformed HTML due to truncation) properly?
|
Thanks a lot @dcrosta 👍 |
Add (a truncated copy of) the HTTP body on failures to the alert messages generated by http_check.
This probably only works helpfully for "health check" endpoints which return a brief message about why they failed; human-friendly HTML pages (like 404s) probably won't be that usable in 200 characters or less. It would be fairly simple to add a configuration option for whether to include the body or not.