Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql check improvements #576

Merged
merged 2 commits into from
Jul 22, 2013
Merged

Mysql check improvements #576

merged 2 commits into from
Jul 22, 2013

Conversation

LotharSee
Copy link
Contributor

I already did some changes in the code of MySQL check since 3.8.0 (bugfixes: 68975c5, ddc56aa, refactoring: 5517c79), they should be part of this PR but they are already on master.

This PR closes #575, it adds port as an configuration parameter. It shouldn't be a problem.

It also provides a solution for #442 / #448. It concerns system metrics for MySQL, the issue is well described in the previous 2 tickets.
Instead of adding a parameter in the configuration to collect these metrics, I collect them only if I am sure they will be right:

  • Server connection on UNIX socket / localhost : be sure that the server is running locally
  • Get pid from ps only if it returns only 1 result, avoid error in case of multiple server instances
  • Get pid from ps only on linux: no way to filter precisely on FreeBSD and Darwin
  • An exception during the opening of the /proc/ file (no permission, file doesn't exist) isn't an error
  • Don't display warning if system metrics aren't collected

That's a proposal. @clutchski, @remh, tell me what you think about it.

remh added a commit that referenced this pull request Jul 22, 2013
@remh remh merged commit 9214a52 into master Jul 22, 2013
@conorbranagan conorbranagan deleted the mysql_improvements branch July 22, 2013 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to set server port for MySQL check
2 participants