Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already did some changes in the code of MySQL check since 3.8.0 (bugfixes: 68975c5, ddc56aa, refactoring: 5517c79), they should be part of this PR but they are already on master.
This PR closes #575, it adds port as an configuration parameter. It shouldn't be a problem.
It also provides a solution for #442 / #448. It concerns system metrics for MySQL, the issue is well described in the previous 2 tickets.
Instead of adding a parameter in the configuration to collect these metrics, I collect them only if I am sure they will be right:
ps
only if it returns only 1 result, avoid error in case of multiple server instancesps
only on linux: no way to filter precisely on FreeBSD and Darwin/proc/
file (no permission, file doesn't exist) isn't an errorThat's a proposal. @clutchski, @remh, tell me what you think about it.