add two new metrics to nginx check #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* nginx.net.conn_opened_per_s, number of new HTTP connections created per second * nginx.net.current, total number of current HTTP connections, regardless of their state (sum of reading, writing, waiting)
|
+1 |
|
Thanks Dan Can you remove that metric and then i'll merge the PR for the other metric ? Thanks! |
|
Good catch @remh. Fixed. |
remh
added a commit
that referenced
this pull request
Oct 4, 2013
add two new metrics to nginx check
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first one is of interest to us -- we run a service that relies on re-use of HTTP keep-alive sessions, and the cost of establishing new connections is high. The second seems like an obvious convenience, though it could be recreated in charts in DD web.