Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Couchbase check and corresponding unit test #700

Merged
merged 1 commit into from Oct 24, 2013
Merged

Updated Couchbase check and corresponding unit test #700

merged 1 commit into from Oct 24, 2013

Conversation

jslatts
Copy link
Contributor

@jslatts jslatts commented Oct 23, 2013

This PR replaces the original PR referenced in issue #690, which, due to a bad branching strategy had to be discarded.

Each comment in the original PR has been addressed, including style and flow changes, check naming conventions, and unit test coverage.

@jslatts jslatts mentioned this pull request Oct 23, 2013
@jslatts
Copy link
Contributor Author

jslatts commented Oct 23, 2013

@remh Let me know if this PR addresses the comments from issue #690.

@remh
Copy link
Contributor

remh commented Oct 24, 2013

Thanks @jslatts !
Merging it in but I'll make a few small changes if you don't mind!

@remh remh closed this Oct 24, 2013
@remh remh reopened this Oct 24, 2013
remh added a commit that referenced this pull request Oct 24, 2013
Updated Couchbase check and corresponding unit test
@remh remh merged commit 71df2cb into DataDog:master Oct 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants