Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic authentication support to the Elasticsearch check. #806

Merged
merged 6 commits into from
Jan 23, 2014

Conversation

conorbranagan
Copy link
Member

Useful for anyone using a 3rd party plugin or a service like found.no which has basic auth on by default.

Also:

  • Refactors the Elasticsearch check some. I think there's still more to do - the closure/mapping stuff is hard to follow.
  • Move all the basic authorization handling into one place because there was a bug in how we were generating the authorization string and it's better to have this stuff in one place (until we have our own Python and can use requests...)

@ghost ghost assigned remh Jan 22, 2014
remh added a commit that referenced this pull request Jan 23, 2014
Add basic authentication support to the Elasticsearch check.
@remh remh merged commit 058a9df into master Jan 23, 2014
@remh
Copy link
Contributor

remh commented Jan 23, 2014

Looks good to me!

@remh remh deleted the elasticsearch-basic-auth branch June 23, 2014 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants