Small fixes for macos / clang builds #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were not passing under macos in mysterious ways - a reference to a static error_category reference were not behaving correctly. The underlying cause was linking dd_opentracing after the opentracing library. It'd essentially call a different version of the function and get a different (static) error_category reference.
|
These came up as part of envoyproxy/envoy#11094, which failed some of its CI checks. We need a new release before reopening a PR for that project. |
rochdev
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some environments,
std::chrono::durationuseslongfor representing the value, and others uselong long. In the latter, it caused an error comparing against alongusingstd::min.It could have been fixed using
std::common_type, but a simpler fix with a basic if comparison was chosen instead.When running tests on macos, one specific test would fail in a mysterious way, when comparing against an essentially static value. This was somehow due to the orders libraries were linked causing trouble on this environment. (It didn't occur with Linux/GCC).