Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake flag equivalent to -fPIC #151

Merged
merged 3 commits into from
Jan 23, 2021
Merged

Add cmake flag equivalent to -fPIC #151

merged 3 commits into from
Jan 23, 2021

Conversation

cgilmour
Copy link
Contributor

@cgilmour cgilmour commented Nov 4, 2020

This prevents an error when doing certain builds involving static libraries.

relocation R_X86_64_TPOFF32 against `__tls_guard' can not be used when making a shared object; recompile with -fPIC

@cgilmour cgilmour added this to the 1.2.1 milestone Nov 4, 2020
@cgilmour cgilmour merged commit c827956 into master Jan 23, 2021
@cgilmour cgilmour deleted the cgilmour/pic branch January 23, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@cgilmour @brettlangdon