Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.7, AGP to 8.4.0 #253

Merged
merged 3 commits into from
May 2, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented May 2, 2024

What does this PR do?

This PR updates Gradle version to 8.7 and AGP to 8.4.0 in 2 different commits: one updates it for the build env, another one updates it for the functional tests run.

This PR also removes Detekt from the build script - it is run externally in the static-analysis nested pipeline and it was using old version 1.17.0, which doesn't work with the change made.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners May 2, 2024 08:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (5368d30) to head (284cc34).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #253      +/-   ##
=============================================
+ Coverage      81.38%   81.42%   +0.05%     
- Complexity       202      204       +2     
=============================================
  Files             26       26              
  Lines            800      802       +2     
  Branches         103      104       +1     
=============================================
+ Hits             651      653       +2     
  Misses           112      112              
  Partials          37       37              

see 2 files with indirect coverage changes

@0xnm 0xnm merged commit bedd416 into develop May 2, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/update-gradle-agp-versions branch May 2, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants