Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4406: Avoid BuildId task creation if there is no obfuscation or native build providers registered #259

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented May 13, 2024

What does this PR do?

This PR will make build ID generation task to be created only if there is obfuscation enabled or there are native build providers.

Partially addresses #258.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners May 13, 2024 12:19
@0xnm 0xnm changed the title RUM-4406: Avoid BuildId task creation if there is no obfuscation or n… RUM-4406: Avoid BuildId task creation if there is no obfuscation or native build providers registered May 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.41%. Comparing base (db3ff0d) to head (ecf9853).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #259      +/-   ##
=============================================
- Coverage      80.87%   80.41%   -0.46%     
- Complexity       207      208       +1     
=============================================
  Files             26       26              
  Lines            826      827       +1     
  Branches         108      110       +2     
=============================================
- Hits             668      665       -3     
- Misses           114      116       +2     
- Partials          44       46       +2     
Files Coverage Δ
...datadog/gradle/plugin/DdNdkSymbolFileUploadTask.kt 76.39% <100.00%> (-1.24%) ⬇️
...com/datadog/gradle/plugin/DdAndroidGradlePlugin.kt 67.61% <50.00%> (-1.21%) ⬇️

... and 3 files with indirect coverage changes

@0xnm 0xnm merged commit e5b955f into develop May 15, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-4406/avoid-buildid-task-creation-if-no-deobfuscation-or-native-build-providers branch May 15, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants