Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4407 & RUM-4087: Add test for the duplicate resources issue with AGP 8.4.x #264

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented May 29, 2024

What does this PR do?

This PR adds the necessary test to reproduce the issue mentioned in #242 and #257. The problem itself was fixed in #263.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners May 29, 2024 09:38
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.09%. Comparing base (ed9c4e6) to head (12d2037).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #264      +/-   ##
=============================================
- Coverage      78.34%   78.09%   -0.24%     
+ Complexity       253      250       -3     
=============================================
  Files             31       31              
  Lines            914      913       -1     
  Branches         114      114              
=============================================
- Hits             716      713       -3     
- Misses           147      148       +1     
- Partials          51       52       +1     

see 4 files with indirect coverage changes

@0xnm 0xnm force-pushed the nogorodnikov/rum-592/support-new-variant-api branch from 7374873 to 70ba81c Compare May 29, 2024 11:58
Base automatically changed from nogorodnikov/rum-592/support-new-variant-api to develop May 30, 2024 08:34
@0xnm 0xnm force-pushed the nogorodnikov/rum-4407/add-test-for-duplicate-resources-issue branch from e254419 to 12d2037 Compare May 30, 2024 08:56
@0xnm 0xnm merged commit 46233f7 into develop May 30, 2024
13 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-4407/add-test-for-duplicate-resources-issue branch May 30, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants