Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-7475 [SR][SwiftUI] Update snapshot tests #2131

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

RUM-7475 [SR][SwiftUI] Update snapshot tests #2131

wants to merge 2 commits into from

Conversation

mariedm
Copy link
Member

@mariedm mariedm commented Dec 4, 2024 •
edited
Loading

What and why?

With the introduction of SwiftUI support in Session Replay, our snapshot tests need to be updated to cover a wider range of components.

How?

  • Created a dedicated SwiftUIView to test SwiftUI components.
  • Added tests for additional components: TextField, Button, Divider, Image, List
  • Added snapshot tests for different privacy configurations
Mask none Mask user input + non bundled images Mask all
testSwiftUI()-maskAll_images-maskSensitiveInputs-privacy testSwiftUI()-maskNonBundledOnly_images-maskAllInputs-privacy testSwiftUI()-maskAll_images-maskAll-privacy

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines [internal]) and run make api-surface)

@mariedm mariedm changed the title mariedm/rum 7475 sr swiftui update snapshot tests RUM-7475 [SR][SwiftUI] Update snapshot tests Dec 4, 2024
@mariedm mariedm changed the base branch from develop to mariedm/rum-7462-sr-apply-global-privacy-settings December 4, 2024 15:46
@mariedm mariedm force-pushed the mariedm/rum-7475-sr-swiftui-update-snapshot-tests branch from 87caf3a to 46b6464 Compare December 4, 2024 15:52
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 4, 2024 •
edited
Loading

Datadog Report

Branch report: mariedm/rum-7475-sr-swiftui-update-snapshot-tests
Commit report: 2e55a2b
Test service: dd-sdk-ios

✅ 0 Failed, 3571 Passed, 0 Skipped, 2m 21.77s Total Time
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 8 no change

🔻 Code Coverage Decreases vs Default Branch (3)

  • test DatadogInternalTests tvOS 80.37% (-0.06%) - Details
  • test DatadogTraceTests iOS 54.17% (-0.05%) - Details
  • test DatadogCrashReportingTests iOS 26.63% (-0.02%) - Details

@mariedm mariedm force-pushed the mariedm/rum-7475-sr-swiftui-update-snapshot-tests branch from 46b6464 to 2c8e1af Compare December 4, 2024 16:01
@mariedm mariedm marked this pull request as ready for review December 4, 2024 17:25
@mariedm mariedm requested review from a team as code owners December 4, 2024 17:25
simaoseica-dd
simaoseica-dd reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@simaoseica-dd simaoseica-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments/questions

...sts/SRFixtures/Sources/SRFixtures/Resources/Assets.xcassets/Flowers_1.imageset/Flowers_1.png Outdated Show resolved Hide resolved
...essionReplay/SRSnapshotTests/SRFixtures/Sources/SRFixtures/ViewControllers/SwiftUIView.swift Outdated Show resolved Hide resolved
...essionReplay/SRSnapshotTests/SRFixtures/Sources/SRFixtures/ViewControllers/SwiftUIView.swift Outdated Show resolved Hide resolved
simaoseica-dd
simaoseica-dd previously approved these changes Dec 5, 2024
View reviewed changes
@mariedm mariedm force-pushed the mariedm/rum-7475-sr-swiftui-update-snapshot-tests branch 2 times, most recently from d2a3288 to 2e55a2b Compare December 6, 2024 10:20
Base automatically changed from mariedm/rum-7462-sr-apply-global-privacy-settings to develop December 11, 2024 09:11
@mariedm mariedm dismissed simaoseica-dd’s stale review December 11, 2024 09:11

The base branch was changed.

@mariedm mariedm force-pushed the mariedm/rum-7475-sr-swiftui-update-snapshot-tests branch from 2e55a2b to 44b02a5 Compare December 11, 2024 16:21
maxep
maxep approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simaoseica-dd simaoseica-dd simaoseica-dd approved these changes

@maxep maxep maxep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariedm @maxep @simaoseica-dd