Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In another internal project that relies on
dd-trace-cpp
, I needed to enable cross-compilation for Windows from a Linux host. During this process, I usedclang-cl
as the compiler - MSVC frontend forclang
. However, I encountered an issue whereCMAKE_CXX_COMPILER_ID
was detected asClang
, which caused the incorrect file to be included, leading to a compilation failure.To address this, I utilized the
CMAKE_CXX_COMPILER_FRONTEND_VARIANT
variable. This change ensures that the correct compiler frontend (clang-cl
) is identified, allowing for successful cross-compilation in this scenario.