Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing(parametric): update start span parametric endpoint #170

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link

Description

  • Moves http_header extraction from /trace/span/start/ to a new trace/span/extract_headers endpoint. This ensures the /trace/span/start parametric endpoint aligns with the following specification.
  • Renames the active_spans_ variable to spans_. This map will no longer just contain active spans, it will also store spans extracted from distributed tracing headers.
  • Ensures /trace/span/finish does NOT clear the span list. Spans should only be removed from spans_ (previously active_spans_) if the trace/spans/flush is called.

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-12-03 18:34:44

Comparing candidate commit 7316007 in PR branch munir/update-parametric-app-start-span with baseline commit 3a8bcba in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@mabdinur mabdinur force-pushed the munir/update-parametric-app-start-span branch from 418cd3d to b35ee1c Compare November 22, 2024 20:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (3a8bcba) to head (55ec27d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          73       73           
  Lines        4176     4176           
=======================================
  Hits         3922     3922           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants