dc

DataDog · Apr 10, 2024 · 8282643 · 8282643
1 parent 987ade3
commit 8282643
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tracer/src/Datadog.Trace/AppSec/Rcm/ConfigurationStatus.cs b/tracer/src/Datadog.Trace/AppSec/Rcm/ConfigurationStatus.cs
@@ -148,7 +148,8 @@ internal Dictionary<string, object> BuildDictionaryForWafAccordingToIncomingUpda
     }
 
     /// <summary>
-    /// Calls each file updater to deserialize all remote config payloads and store them in the proper dictionaries with involved merges
+    /// Calls each file updater to deserialize all remote config payloads and store them in the proper dictionaries with might involve various logical merges
+    /// This method deserializes everything stored in _fileUpdates. ConfigurationStatus will have a *bigger* memory footprint.
     /// </summary>
     public void ApplyStoredFiles()
     {

diff --git a/tracer/src/Datadog.Trace/AppSec/Security.cs b/tracer/src/Datadog.Trace/AppSec/Security.cs
@@ -171,6 +171,7 @@ private ApplyDetails[] UpdateFromRcm(Dictionary<string, List<RemoteConfiguration
 
             try
             {
+                // store the last config state, clearing any previous state, without deserializing any payloads yet.
                 var anyChange = _configurationStatus.StoreLastConfigState(configsByProduct, removedConfigs);
                 var securityStateChange = Enabled != _configurationStatus.EnableAsm;