Add #if _WIN32 clauses for windows only definitions

DataDog · Nov 11, 2024 · 86827a9 · 86827a9
1 parent 17bc420
commit 86827a9
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 11 deletions.
diff --git a/tracer/build/_build/CodeGenerators/CallSitesGenerator.cs b/tracer/build/_build/CodeGenerators/CallSitesGenerator.cs
@@ -238,6 +238,7 @@ static string GetArgument(Mono.Cecil.CustomAttributeArgument customAttributeArgu
         internal static void GenerateFile(Dictionary<string, AspectClass> aspectClasses, AbsolutePath outputPath)
         {
             var sb = new StringBuilder();
+            bool inWin32Section = false;
             sb.AppendLine("""
                 // <copyright company="Datadog">
                 // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
@@ -260,7 +261,19 @@ namespace trace
 
                 foreach (var method in aspectClass.Value.Aspects.OrderBy(static k => k.Key.ToString(), StringComparer.OrdinalIgnoreCase))
                 {
-                    sb.AppendLine(Format("  " + method.Key + method.Value.Subfix()));
+                    bool win32Only = method.Value.Tfms.IsNetFxOnly();
+                    if (win32Only && !inWin32Section)
+                    {
+                        inWin32Section = true;
+                        sb.AppendLine("#if _WIN32");
+                    }
+                    else if (!win32Only && inWin32Section)
+                    {
+                        inWin32Section = false;
+                        sb.AppendLine("#endif");
+                    }
+
+                    sb.AppendLine(Format("  " + method.Key + method.Value.Suffix()));
                 }
             }
 
@@ -306,7 +319,7 @@ public Aspect() { }
 
             public TargetFrameworks Tfms = TargetFrameworks.None;
 
-            public string Subfix()
+            public string Suffix()
             {
                 return $" {((long)Tfms).ToString()}";
             }

diff --git a/tracer/build/_build/CodeGenerators/CallTargetsGenerator.cs b/tracer/build/_build/CodeGenerators/CallTargetsGenerator.cs
@@ -474,6 +474,7 @@ namespace trace
 
 
             //Write all CallTargets
+            bool inWin32Section = false;
             sb.AppendLine();
             sb.AppendLine("std::vector<CallTargetDefinition3> g_callTargets=");
             sb.AppendLine("{");
@@ -484,6 +485,18 @@ namespace trace
                                         .ThenBy(static x => x.Key.TargetTypeName)
                                         .ThenBy(static x => x.Key.TargetMethodName))
             {
+                bool win32Only = definition.Value.IsNetFxOnly();
+                if (win32Only && !inWin32Section)
+                {
+                    inWin32Section = true;
+                    sb.AppendLine("#if _WIN32");
+                }
+                else if (!win32Only && inWin32Section)
+                {
+                    inWin32Section = false;
+                    sb.AppendLine("#endif");
+                }
+
                 sb.AppendLine(GetCallTarget(definition.Key, signatures[GetSignature(definition.Key)], definition.Value, x++));
             }
 
@@ -535,14 +548,6 @@ static string GetCallTarget(CallTargetDefinitionSource definition, string signat
 
             static string GetCallTargetKind(int kind)
             {
-                /*
-                 enum class CallTargetKind : UINT8
-                {
-                    Default = 0,
-                    Derived = 1,
-                    Interface = 2
-                };
-                 */
                 return kind switch
                 {
                     0 => "CallTargetKind::Default",
@@ -575,7 +580,6 @@ internal static void GenerateJsonFile(Dictionary<CallTargetDefinitionSource, Tar
             Serilog.Log.Information("CallTarget definitions File saved: {File}", fileName);
         }
 
-
         internal static TargetFrameworks GetCategory(TargetFramework tfm)
         {
             return (TargetFrameworks)Enum.Parse<TargetFrameworks>(tfm.ToString().ToUpper().Replace('.', '_'));

diff --git a/tracer/build/_build/CodeGenerators/TargetFrameworks.cs b/tracer/build/_build/CodeGenerators/TargetFrameworks.cs
@@ -26,3 +26,12 @@ internal enum TargetFrameworks : uint
     NET7_0 = 256,
     NET8_0 = 512
 }
+
+
+internal static class TargetFrameworksExtensions
+{ 
+    public static bool IsNetFxOnly(this TargetFrameworks tfm)
+    {
+        return ((uint)(tfm & (~(TargetFrameworks.NET461 | TargetFrameworks.NET462)))) == 0;
+    }
+}