Fix the code to move the dumps

DataDog · Nov 30, 2023 · c838d83 · c838d83
1 parent 9a1947c
commit c838d83
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/tracer/build/_build/Build.Steps.cs b/tracer/build/_build/Build.Steps.cs
@@ -2712,23 +2712,27 @@ private void CopyDumpsToBuildData()
 
     private void CopyDumpsTo(AbsolutePath root)
     {
+        var dumpFolder = root / "dumps";
+
         if (Directory.Exists(TempDirectory))
         {
             foreach (var dump in GlobFiles(TempDirectory, "coredump*", "*.dmp"))
             {
-                Logger.Information("Moving file '{Dump}' to '{Root}'", dump, root / "dumps");
+                Logger.Information("Moving file '{Dump}' to '{Root}'", dump, dumpFolder);
 
-                MoveFileToDirectory(dump, root / "dumps", FileExistsPolicy.Overwrite);
+                MoveFileToDirectory(dump, dumpFolder, FileExistsPolicy.Overwrite);
             }
         }
-        else
-        {
-            Logger.Warning("TempDirectory '{TempDirectory}' does not exist, skipping dump copy", TempDirectory);
-        }
 
         foreach (var file in Directory.EnumerateFiles(TracerDirectory, "*.dmp", SearchOption.AllDirectories))
         {
-            CopyFileToDirectory(file, root, FileExistsPolicy.OverwriteIfNewer);
+            if (Path.GetDirectoryName(file) == dumpFolder)
+            {
+                // The dump is already in the right location
+                continue;
+            }
+
+            CopyFileToDirectory(file, dumpFolder, FileExistsPolicy.OverwriteIfNewer);
         }
     }