Skip to content

Commit

Permalink
Skip the mass transit test to see if it solves flake issues (#5861)
Browse files Browse the repository at this point in the history
## Summary of changes

Skip the mass transit smoke test as it seems to be a cause of a lot of
flakiness

## Reason for change

We've seen a lot of errors in the `CheckBuildlogsForErr` stage:

```
CheckBuildLogsForErr: 03:08:39 [Error] An error occurred while sending data to the agent at http://127.0.0.1:39573/v0.4/traces. If the error isn't transient, please check https://docs.datadoghq.com/tracing/troubleshooting/connection_errors/?code-lang=dotnet for guidance. System.Net.Http.HttpRequestException: Error while copying content to a stream.
```

These seemed to get a lot worse after we disabled keep-alive, but that's
anecdotal.

## Implementation details

It's not entirely clear if the problem is just coincidentally related to
the MassTransit test (i.e. it's a test ordering process) or if it's
actually something about the test.

As a check I tried skipping the test in this branch and did 4 full (all
TFM) integration tests runs, and didn't see the issue again. It's all
still anecdotal, but rather trade off flakiness here. If the problem
reappears subsequently, we can look into it again further.

## Test coverage

Did 4 full runs, and didn't see the issue again
  • Loading branch information
andrewlock committed Aug 16, 2024
1 parent b56d037 commit ce7f3a8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public ServiceBusMinimalMassTransitTest(ITestOutputHelper output)
AssumeSuccessOnTimeout = true;
}

[SkippableFact]
[SkippableFact(Skip = "Testing to see if this solves weird flake issues")]
[Trait("Category", "Smoke")]
public async Task NoExceptions()
{
Expand Down

0 comments on commit ce7f3a8

Please sign in to comment.