Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch integration #163

Merged
merged 13 commits into from
Oct 9, 2018
Merged

Elasticsearch integration #163

merged 13 commits into from
Oct 9, 2018

Conversation

dd-caleb
Copy link
Contributor

@dd-caleb dd-caleb commented Oct 1, 2018

This is an Elasticsearch tracing integration. I swapped out the CallElasticsearch and CallElasticsearchAsync methods of the IPipeline interface which is used by Transport and a lot of other classes up stream, so all Nest functionality should get included as well.

One tricky thing here, CancellationToken is a value type with a single CancellationTokenSource field (an object type), so the method ends up receiving a CancellationTokenSource, hence why we do:

var cancellationToken = (cancellationTokenSource as CancellationTokenSource)?.Token ?? CancellationToken.None;

@dd-caleb dd-caleb merged commit d6574b3 into master Oct 9, 2018
@dd-caleb dd-caleb deleted the caleb/elasticsearch branch October 9, 2018 14:27
@lucaspimentel lucaspimentel added type:new-feature area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) labels Oct 10, 2018
@lucaspimentel lucaspimentel added this to the 0.3.3-beta milestone Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:automatic-instrumentation Automatic instrumentation managed C# code (Datadog.Trace.ClrProfiler.Managed) type:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants