Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for changes to Datadog.Trace's Public API #1681

Merged
merged 10 commits into from
Aug 13, 2021
Merged

Add tests for changes to Datadog.Trace's Public API #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c06df22
Add tests for public API and public browsable (intellisense) API
andrewlock Aug 12, 2021
bdc65bf
Add public API snapshots based on v1.28.2 (pre assembly merge)
andrewlock Aug 12, 2021
ce2ac2c
Update snapshots _after_ assembly merge. This adds a _lot_ of surface…
andrewlock Aug 12, 2021
2036686
Update snapshots for master
andrewlock Aug 12, 2021
4327d75
Make Security class internal
andrewlock Aug 12, 2021
ee570da
Add [Browsable(false)] and [EditorBrowsable(EditorBrowsableState.Neve…
andrewlock Aug 12, 2021
89fcf00
Exclude non-browsable APIs from "public API"
andrewlock Aug 12, 2021
b212280
Try making some things internal
andrewlock Aug 13, 2021
991a580
More updates
andrewlock Aug 13, 2021
cc3fe91
Fix test visibility
andrewlock Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Datadog.Trace/AppSec/Security.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
namespace Datadog.Trace.AppSec
{
/// <summary>
/// The Secure is responsible cooridating app sec
/// The Secure is responsible coordinating app sec
/// </summary>
public class Security : IDatadogSecurity, IDisposable
internal class Security : IDatadogSecurity, IDisposable
{
private static readonly IDatadogLogger Log = DatadogLogging.GetLoggerFor<Security>();

Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/AspNet/TracingHttpModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Linq;
using System.Web;
using Datadog.Trace.AppSec;
Expand All @@ -24,6 +25,8 @@ namespace Datadog.Trace.AspNet
/// <summary>
/// IHttpModule used to trace within an ASP.NET HttpApplication request
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class TracingHttpModule : IHttpModule
{
internal static readonly IntegrationInfo IntegrationId = IntegrationRegistry.GetIntegrationInfo(nameof(IntegrationIds.AspNet));
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IAmazonWebServiceResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;
using System.Net;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// AmazonWebServiceResponse interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IAmazonWebServiceResponse
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IClientConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IClientConfig interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IClientConfig
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IExecutionContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IExecutionContext interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IExecutionContext
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IRegionEndpoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IRegionEndpoint interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IRegionEndpoint
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IRequest interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IRequest
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IRequestContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IRequestContext interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IRequestContext
{
/// <summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IResponseContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// IResponseContext interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IResponseContext
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/IResponseMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
// </copyright>

using System.Collections.Generic;
using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
{
/// <summary>
/// ResponseMetadata interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IResponseMetadata
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions ...og.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/RuntimePipelineInvokeAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.ExtensionMethods;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsConstants.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class RuntimePipelineInvokeAsyncIntegration
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions ...dog.Trace/ClrProfiler/AutoInstrumentation/AWS/SDK/RuntimePipelineInvokeSyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.ExtensionMethods;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsConstants.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class RuntimePipelineInvokeSyncIntegration
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/CreateQueueAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using System.Threading;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class CreateQueueAsyncIntegration
{
private const string Operation = "CreateQueue";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/CreateQueueIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.Tagging;
Expand All @@ -22,6 +23,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class CreateQueueIntegration
{
private const string Operation = "CreateQueue";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteMessageAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using System.Threading;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteMessageAsyncIntegration
{
private const string Operation = "DeleteMessage";
Expand Down
3 changes: 3 additions & 0 deletions ...tadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteMessageBatchAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using System.Threading;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteMessageBatchAsyncIntegration
{
private const string Operation = "DeleteMessageBatch";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteMessageBatchIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.Tagging;
Expand All @@ -22,6 +23,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteMessageBatchIntegration
{
private const string Operation = "DeleteMessageBatch";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteMessageIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.Tagging;
Expand All @@ -22,6 +23,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteMessageIntegration
{
private const string Operation = "DeleteMessage";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteQueueAsyncIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using System.Threading;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
Expand All @@ -23,6 +24,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteQueueAsyncIntegration
{
private const string Operation = "DeleteQueue";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/DeleteQueueIntegration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// </copyright>

using System;
using System.ComponentModel;
using Datadog.Trace.ClrProfiler.CallTarget;
using Datadog.Trace.DuckTyping;
using Datadog.Trace.Tagging;
Expand All @@ -22,6 +23,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
MinimumVersion = "3.0.0",
MaximumVersion = "3.*.*",
IntegrationName = AwsSqsCommon.IntegrationName)]
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public class DeleteQueueIntegration
{
private const string Operation = "DeleteQueue";
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/IAmazonSQSRequestWithQueueUrl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
Expand All @@ -14,6 +15,8 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
/// <summary>
/// Interface for ducktyping AmazonSQSRequest implementations with the QueueUrl property
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IAmazonSQSRequestWithQueueUrl
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/IContainsMessageAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
// </copyright>

using System.Collections;
using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
{
/// <summary>
/// MessageAttributes interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface IContainsMessageAttributes
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/ICreateQueueRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@
// </copyright>

using System.Collections.Generic;
using System.ComponentModel;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
{
/// <summary>
/// CreateQueueRequest interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface ICreateQueueRequest
{
/// <summary>
Expand Down
3 changes: 3 additions & 0 deletions src/Datadog.Trace/ClrProfiler/AutoInstrumentation/AWS/SQS/ICreateQueueResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>

using System.ComponentModel;
using Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SDK;

namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
{
/// <summary>
/// CreateQueueResponse interface for ducktyping
/// </summary>
[Browsable(false)]
[EditorBrowsable(EditorBrowsableState.Never)]
public interface ICreateQueueResponse : IAmazonWebServiceResponse
{
/// <summary>
Expand Down
Loading