Add .NET Core support to msi installer #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
added
status:work-in-progress
dd-caleb
approved these changes
Oct 22, 2018
lucaspimentel
force-pushed
the
lpimentel/dotnet-core-msi
branch
from
94e5cbb
to
f30c7d9
Compare
lucaspimentel
changed the title
lucaspimentel
removed
the
status:work-in-progress
lucaspimentel
added
area:builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORECLR_*)w3wp.exe(.NET Core apps run as child processes, not in-process)I also published NuGet package Datadog.Trace.ClrProfiler.Managed that should be added to .NET Core apps that use automatic instrumentation.