allow built-in Web API tracing, fix StackExchange.Redis, add IL validation #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ystemDiagnosticsTracing()` if enabled via settings or env. variable
lucaspimentel
added
type:bug
area:automatic-instrumentation
lucaspimentel
removed
the
status:work-in-progress
lucaspimentel
changed the title
|
A flaky test failed the first time, then passed. |
dd-caleb
reviewed
Oct 26, 2018
src/Datadog.Trace.ClrProfiler.Managed/Integrations/AspNetWebApi2Integration.cs
Show resolved
Hide resolved
dd-caleb
approved these changes
Oct 26, 2018
Merged
…vOps integration)
lucaspimentel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core:
Sigilto validate dynamically emitted ILTrim()what would truncate strings with spacesWeb API integration:
EnableSystemDiagnosticsTracing()StackExchange.Redisintegration:RedisBase.ExecuteAsync()should returnTask<T>, notTask<Task<T>>(caught by Sigil, see above)