add support for DD_AGENT_HOST environment variable
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lds to match conventions
lucaspimentel
added
type:enhancement
palazzem
approved these changes
Nov 13, 2018
bmermet
reviewed
Nov 13, 2018
| { | ||
| var prefixes = new string[] { "DD", "DATADOG" }; | ||
| var host = TraceAgentHostEnvironmentVariableNames.Select(Environment.GetEnvironmentVariable) |
bmermet
approved these changes
Nov 13, 2018
lucaspimentel
added a commit
that referenced
this pull request
Nov 19, 2018
* add support for `DD_AGENT_HOST`, make some fields `const`, rename fields to match conventions * call `GetAgentUri()` once and cache the result * make another field `const`, reorder fields * add unit tests * restore original environment variables after unit test * add comments * add "DATADOG_" prefix as fallbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DD_AGENT_HOSTenvironment variable (while keeping a fallback for the oldDD_TRACE_AGENT_HOSTNAME)code clean-up:
constorreadonlywhere possible