Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] Add the vale of the cookie/header name in source #4856

Merged
merged 1 commit into from
Nov 17, 2023
Merged

[ASM] Add the vale of the cookie/header name in source #4856

merged 1 commit into from
Nov 17, 2023

Conversation

NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Nov 13, 2023 •
edited
Loading

Summary of changes

In order to comply with the naming conventions of all the IAST teams, a source of type "cookie name" or "header name" should have the name in both name and value fields of the source.

Reason for change

To return the same json data as the other IAST teams.

Implementation details

Test coverage

Other details

@NachoEchevarria NachoEchevarria changed the title Add the vale of the cookie name in source [ASM] Add the vale of the cookie/header name in source Nov 13, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 13, 2023 •
edited
Loading

Datadog Report

Branch report: nacho/AddCookieNameAsValue
Commit report: 5b52391

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 301549 Passed, 978 Skipped, 54m 9.93s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (71ms)  : 63, 79
     .   : milestone, 71,
    master - mean (71ms)  : 62, 79
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (1,001ms)  : 981, 1022
     .   : milestone, 1001,
    master - mean (995ms)  : 957, 1032
     .   : milestone, 995,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (105ms)  : 103, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (691ms)  : 672, 710
     .   : milestone, 691,
    master - mean (683ms)  : 661, 705
     .   : milestone, 683,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (90ms)  : 87, 93
     .   : milestone, 90,
    master - mean (89ms)  : 85, 93
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (657ms)  : 631, 683
     .   : milestone, 657,
    master - mean (651ms)  : 625, 677
     .   : milestone, 651,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (187ms)  : 185, 189
     .   : milestone, 187,
    master - mean (187ms)  : 185, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (1,101ms)  : 1077, 1124
     .   : milestone, 1101,
    master - mean (1,107ms)  : 1055, 1159
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (271ms)  : 267, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (1,057ms)  : 1030, 1084
     .   : milestone, 1057,
    master - mean (1,058ms)  : 1031, 1086
     .   : milestone, 1058,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4856) - mean (262ms)  : 259, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4856) - mean (1,022ms)  : 1000, 1044
     .   : milestone, 1022,
    master - mean (1,019ms)  : 995, 1042
     .   : milestone, 1019,
Loading

@NachoEchevarria NachoEchevarria marked this pull request as ready for review November 13, 2023 17:00
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner November 13, 2023 17:00
@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4856 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.161
  • 3 benchmarks are slower, with geometric mean 1.163
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.14μs 42.1ns 202ns 0.0197 0.0079 0 7.29 KB
master StartStopWithChild netcoreapp3.1 10.3μs 56.9ns 341ns 0.0312 0.0156 0.0052 7.38 KB
master StartStopWithChild net472 15.7μs 51ns 197ns 1.28 0.311 0.0934 7.66 KB
#4856 StartStopWithChild net6.0 8.12μs 46ns 322ns 0.0352 0.0156 0 7.29 KB
#4856 StartStopWithChild netcoreapp3.1 10μs 54.3ns 312ns 0.0341 0.0146 0 7.39 KB
#4856 StartStopWithChild net472 15.7μs 44.4ns 172ns 1.27 0.326 0.101 7.66 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 497μs 243ns 940ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 289ns 1.12μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 802μs 562ns 2.18μs 0.398 0 0 3.3 KB
#4856 WriteAndFlushEnrichedTraces net6.0 484μs 265ns 1.03μs 0 0 0 2.7 KB
#4856 WriteAndFlushEnrichedTraces netcoreapp3.1 642μs 94.4ns 341ns 0 0 0 2.7 KB
#4856 WriteAndFlushEnrichedTraces net472 803μs 411ns 1.59μs 0.398 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4856

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑netcoreapp3.1 1.176 4,276.37 3,637.65
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.149 211.22 183.85

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 44.3μs 78.3ns 303ns 0.0221 0 0 2.02 KB
master AllCycleSimpleBody netcoreapp3.1 45.5μs 185ns 715ns 0.0229 0 0 2 KB
master AllCycleSimpleBody net472 46.3μs 24.7ns 85.5ns 0.326 0 0 2.07 KB
master AllCycleMoreComplexBody net6.0 206μs 71.1ns 276ns 0.103 0 0 8.37 KB
master AllCycleMoreComplexBody netcoreapp3.1 210μs 83.6ns 324ns 0.105 0 0 8.26 KB
master AllCycleMoreComplexBody net472 217μs 85.3ns 319ns 1.28 0 0 8.43 KB
master ObjectExtractorSimpleBody net6.0 131ns 0.105ns 0.392ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 211ns 0.364ns 1.36ns 0.00376 0 0 272 B
master ObjectExtractorSimpleBody net472 159ns 0.103ns 0.397ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.76μs 1.35ns 5.22ns 0.0527 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.28μs 1.45ns 5.62ns 0.0492 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.5μs 2.75ns 10.3ns 0.602 0.00525 0 3.8 KB
#4856 AllCycleSimpleBody net6.0 43.2μs 16.7ns 62.3ns 0.0216 0 0 2.02 KB
#4856 AllCycleSimpleBody netcoreapp3.1 45.5μs 100ns 389ns 0.0226 0 0 2 KB
#4856 AllCycleSimpleBody net472 46.6μs 23.2ns 89.9ns 0.321 0 0 2.07 KB
#4856 AllCycleMoreComplexBody net6.0 205μs 88.8ns 344ns 0.103 0 0 8.37 KB
#4856 AllCycleMoreComplexBody netcoreapp3.1 210μs 82.1ns 296ns 0.105 0 0 8.26 KB
#4856 AllCycleMoreComplexBody net472 212μs 138ns 534ns 1.26 0 0 8.43 KB
#4856 ObjectExtractorSimpleBody net6.0 128ns 0.0537ns 0.201ns 0.00394 0 0 280 B
#4856 ObjectExtractorSimpleBody netcoreapp3.1 184ns 0.101ns 0.39ns 0.00371 0 0 272 B
#4856 ObjectExtractorSimpleBody net472 154ns 0.113ns 0.406ns 0.0446 0 0 281 B
#4856 ObjectExtractorMoreComplexBody net6.0 2.75μs 1.14ns 4.27ns 0.0524 0 0 3.78 KB
#4856 ObjectExtractorMoreComplexBody netcoreapp3.1 3.64μs 3.71ns 13.9ns 0.0505 0 0 3.69 KB
#4856 ObjectExtractorMoreComplexBody net472 3.51μs 1.6ns 6.21ns 0.602 0.00527 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 12.9μs 3.31ns 12.8ns 0.129 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 20.4μs 48.2ns 174ns 0.122 0 0 9.41 KB
master RunWaf(args=NestedMap (10)) net472 29.9μs 8.65ns 33.5ns 1.49 0.0149 0 9.47 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 76.5μs 32.9ns 123ns 0.195 0 0 15.76 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 86.4μs 174ns 673ns 0.218 0 0 15.71 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 101μs 92.7ns 359ns 2.51 0 0 16.03 KB
master RunWaf(args=NestedMap (100)) net6.0 24.4μs 10.3ns 38.4ns 0.27 0 0 19.66 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 39μs 13.8ns 53.5ns 0.273 0 0 20.41 KB
master RunWaf(args=NestedMap (100)) net472 58.3μs 26.1ns 101ns 3.26 0.0583 0 20.62 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 91.4μs 35ns 121ns 0.363 0 0 26 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 111μs 81.6ns 316ns 0.334 0 0 26.71 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 130μs 233ns 902ns 4.27 0.0648 0 27.18 KB
master RunWaf(args=NestedMap (20)) net6.0 24μs 23.9ns 92.5ns 0.276 0 0 19.39 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 38.9μs 11.7ns 42.3ns 0.253 0 0 19.83 KB
master RunWaf(args=NestedMap (20)) net472 56.6μs 29.2ns 113ns 3.17 0.0566 0 20.03 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 92.6μs 36.8ns 138ns 0.369 0 0 25.74 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 110μs 37.5ns 130ns 0.328 0 0 26.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 152ns 589ns 4.18 0.0654 0 26.59 KB
#4856 RunWaf(args=NestedMap (10)) net6.0 12.8μs 5.1ns 19.8ns 0.129 0 0 9.42 KB
#4856 RunWaf(args=NestedMap (10)) netcoreapp3.1 20.3μs 10.3ns 37.3ns 0.121 0 0 9.41 KB
#4856 RunWaf(args=NestedMap (10)) net472 29.8μs 5.67ns 20.4ns 1.5 0 0 9.47 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 77μs 70.8ns 274ns 0.225 0 0 15.76 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 85.9μs 95.3ns 369ns 0.171 0 0 15.71 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) net472 99.4μs 69.1ns 268ns 2.51 0 0 16.03 KB
#4856 RunWaf(args=NestedMap (100)) net6.0 24.4μs 8ns 29.9ns 0.27 0 0 19.66 KB
#4856 RunWaf(args=NestedMap (100)) netcoreapp3.1 39.1μs 12.1ns 47.1ns 0.275 0 0 20.41 KB
#4856 RunWaf(args=NestedMap (100)) net472 57.2μs 30.5ns 118ns 3.27 0.0569 0 20.62 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 90.9μs 28.5ns 98.6ns 0.364 0 0 26 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 110μs 123ns 459ns 0.328 0 0 26.71 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [23]) net472 131μs 126ns 489ns 4.26 0.0646 0 27.18 KB
#4856 RunWaf(args=NestedMap (20)) net6.0 24.1μs 12.9ns 49.8ns 0.267 0 0 19.39 KB
#4856 RunWaf(args=NestedMap (20)) netcoreapp3.1 40.3μs 10.4ns 40.5ns 0.262 0 0 19.83 KB
#4856 RunWaf(args=NestedMap (20)) net472 55.9μs 16.5ns 64ns 3.16 0.056 0 20.03 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 91.3μs 37.2ns 144ns 0.362 0 0 25.74 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 109μs 122ns 458ns 0.323 0 0 26.14 KB
#4856 RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 100ns 389ns 4.16 0.065 0 26.59 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 173ns 672ns 0.17 0 0 18.04 KB
master SendRequest netcoreapp3.1 189μs 290ns 1.12μs 0.186 0 0 20.2 KB
master SendRequest net472 0.000213ns 0.000155ns 0.000602ns 0 0 0 0 b
#4856 SendRequest net6.0 167μs 162ns 627ns 0.25 0 0 18.04 KB
#4856 SendRequest netcoreapp3.1 193μs 201ns 777ns 0.192 0 0 20.2 KB
#4856 SendRequest net472 0.000723ns 0.000246ns 0.000887ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 534μs 628ns 2.26μs 0.566 0 0 41.46 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 1.14μs 4.43μs 0.327 0 0 41.63 KB
master WriteAndFlushEnrichedTraces net472 838μs 2.54μs 9.85μs 8.17 2.45 0.408 53.24 KB
#4856 WriteAndFlushEnrichedTraces net6.0 545μs 302ns 1.17μs 0.539 0 0 41.58 KB
#4856 WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 787ns 3.05μs 0.324 0 0 41.68 KB
#4856 WriteAndFlushEnrichedTraces net472 835μs 3.83μs 15.3μs 8.12 2.44 0.406 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4856

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.127 955.80 1,077.06

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 956ns 0.872ns 3.38ns 0.0107 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.3μs 0.476ns 1.78ns 0.0102 0 0 768 B
master ExecuteNonQuery net472 1.66μs 4.23ns 16.4ns 0.116 0 0 730 B
#4856 ExecuteNonQuery net6.0 1.08μs 0.694ns 2.69ns 0.0107 0 0 768 B
#4856 ExecuteNonQuery netcoreapp3.1 1.3μs 0.763ns 2.96ns 0.0104 0 0 768 B
#4856 ExecuteNonQuery net472 1.56μs 0.402ns 1.39ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.688ns 2.66ns 0.0128 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.39μs 0.813ns 2.93ns 0.0125 0 0 936 B
master CallElasticsearch net472 2.32μs 0.682ns 2.64ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.14μs 0.379ns 1.47ns 0.0127 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.51μs 1.81ns 7ns 0.0134 0 0 984 B
master CallElasticsearchAsync net472 2.46μs 1.62ns 6.26ns 0.16 0 0 1.01 KB
#4856 CallElasticsearch net6.0 1.21μs 0.402ns 1.51ns 0.0133 0 0 936 B
#4856 CallElasticsearch netcoreapp3.1 1.39μs 4.06ns 15.7ns 0.0126 0 0 936 B
#4856 CallElasticsearch net472 2.24μs 0.26ns 0.901ns 0.151 0 0 955 B
#4856 CallElasticsearchAsync net6.0 1.12μs 0.38ns 1.42ns 0.0128 0 0 912 B
#4856 CallElasticsearchAsync netcoreapp3.1 1.38μs 0.565ns 2.11ns 0.0132 0 0 984 B
#4856 CallElasticsearchAsync net472 2.46μs 3.9ns 14ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4856

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.160 1,310.18 1,129.86

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.31μs 0.572ns 2.14ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.52μs 0.472ns 1.77ns 0.0121 0 0 912 B
master ExecuteAsync net472 1.74μs 0.833ns 3.23ns 0.138 0 0 875 B
#4856 ExecuteAsync net6.0 1.13μs 1.01ns 3.9ns 0.013 0 0 912 B
#4856 ExecuteAsync netcoreapp3.1 1.49μs 1.22ns 4.4ns 0.012 0 0 912 B
#4856 ExecuteAsync net472 1.71μs 0.398ns 1.49ns 0.139 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.8μs 1.3ns 5.04ns 0.0265 0 0 1.9 KB
master SendAsync netcoreapp3.1 4.61μs 1.8ns 6.99ns 0.0323 0 0 2.43 KB
master SendAsync net472 7.05μs 3.77ns 14.6ns 0.474 0 0 2.99 KB
#4856 SendAsync net6.0 3.76μs 1.64ns 6.35ns 0.0265 0 0 1.9 KB
#4856 SendAsync netcoreapp3.1 4.55μs 1.92ns 7.44ns 0.032 0 0 2.43 KB
#4856 SendAsync net472 7.06μs 2.49ns 9.31ns 0.475 0 0 2.99 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.34μs 0.635ns 2.46ns 0.0221 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.08μs 1.27ns 4.92ns 0.0208 0 0 1.57 KB
master EnrichedLog net472 2.34μs 3.15ns 12.2ns 0.236 0 0 1.49 KB
#4856 EnrichedLog net6.0 1.27μs 0.549ns 2.05ns 0.0221 0 0 1.57 KB
#4856 EnrichedLog netcoreapp3.1 2.01μs 1.36ns 5.28ns 0.0212 0 0 1.57 KB
#4856 EnrichedLog net472 2.31μs 1.42ns 5.49ns 0.236 0 0 1.49 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 90.3ns 350ns 0.0553 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 119μs 195ns 754ns 0.0588 0 0 4.21 KB
master EnrichedLog net472 146μs 78ns 281ns 0.655 0.218 0 4.38 KB
#4856 EnrichedLog net6.0 112μs 91ns 340ns 0.0568 0 0 4.21 KB
#4856 EnrichedLog netcoreapp3.1 118μs 190ns 713ns 0 0 0 4.21 KB
#4856 EnrichedLog net472 146μs 77.7ns 301ns 0.66 0.22 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.95μs 1.05ns 4.08ns 0.0297 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 3.96μs 1.54ns 5.98ns 0.0277 0 0 2.13 KB
master EnrichedLog net472 4.53μs 3.6ns 13.9ns 0.305 0 0 1.93 KB
#4856 EnrichedLog net6.0 2.91μs 1.02ns 3.82ns 0.0292 0 0 2.13 KB
#4856 EnrichedLog netcoreapp3.1 3.95μs 1.46ns 5.64ns 0.0275 0 0 2.13 KB
#4856 EnrichedLog net472 4.39μs 1.05ns 4.06ns 0.307 0 0 1.93 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.29μs 0.633ns 2.28ns 0.0154 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.55μs 0.592ns 2.21ns 0.0148 0 0 1.1 KB
master SendReceive net472 1.95μs 1.16ns 4.33ns 0.176 0 0 1.12 KB
#4856 SendReceive net6.0 1.24μs 0.935ns 3.62ns 0.0155 0 0 1.1 KB
#4856 SendReceive netcoreapp3.1 1.57μs 0.69ns 2.49ns 0.0148 0 0 1.1 KB
#4856 SendReceive net472 1.95μs 2.55ns 9.21ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 1.08ns 4.2ns 0.021 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.6μs 1.39ns 5.4ns 0.0197 0 0 1.58 KB
master EnrichedLog net472 3.97μs 1.7ns 6.37ns 0.309 0 0 1.96 KB
#4856 EnrichedLog net6.0 2.46μs 0.48ns 1.86ns 0.0209 0 0 1.53 KB
#4856 EnrichedLog netcoreapp3.1 3.66μs 3.83ns 14.8ns 0.0202 0 0 1.58 KB
#4856 EnrichedLog net472 4.02μs 1.75ns 6.56ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4856

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.148 672.86 772.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 396ns 0.157ns 0.587ns 0.00743 0 0 536 B
master StartFinishSpan netcoreapp3.1 586ns 0.257ns 0.995ns 0.00731 0 0 536 B
master StartFinishSpan net472 673ns 0.211ns 0.817ns 0.0854 0 0 538 B
master StartFinishScope net6.0 526ns 0.185ns 0.715ns 0.00919 0 0 656 B
master StartFinishScope netcoreapp3.1 673ns 0.271ns 1.05ns 0.00893 0 0 656 B
master StartFinishScope net472 879ns 0.407ns 1.58ns 0.0981 0 0 618 B
#4856 StartFinishSpan net6.0 404ns 0.148ns 0.573ns 0.00746 0 0 536 B
#4856 StartFinishSpan netcoreapp3.1 527ns 0.214ns 0.743ns 0.00729 0 0 536 B
#4856 StartFinishSpan net472 738ns 0.175ns 0.678ns 0.0852 0 0 538 B
#4856 StartFinishScope net6.0 475ns 0.403ns 1.56ns 0.00929 0 0 656 B
#4856 StartFinishScope netcoreapp3.1 773ns 0.45ns 1.74ns 0.00907 0 0 656 B
#4856 StartFinishScope net472 849ns 0.929ns 3.6ns 0.0981 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4856

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.214 714.51 867.54

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 560ns 0.306ns 1.19ns 0.00913 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 715ns 0.199ns 0.771ns 0.0088 0 0 656 B
master RunOnMethodBegin net472 953ns 0.487ns 1.82ns 0.0977 0 0 618 B
#4856 RunOnMethodBegin net6.0 540ns 0.187ns 0.698ns 0.00923 0 0 656 B
#4856 RunOnMethodBegin netcoreapp3.1 868ns 0.181ns 0.702ns 0.00888 0 0 656 B
#4856 RunOnMethodBegin net472 954ns 0.565ns 2.19ns 0.098 0 0 618 B

@NachoEchevarria NachoEchevarria merged commit 86bc483 into master Nov 17, 2023
52 of 54 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/AddCookieNameAsValue branch November 17, 2023 10:16
@github-actions github-actions bot added this to the vNext milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-romano-DD daniel-romano-DD daniel-romano-DD approved these changes

@robertpi robertpi robertpi approved these changes

Assignees
No one assigned
Labels
area:asm area:asm-iast
Projects
None yet
Milestone
2.42.0
Development

Successfully merging this pull request may close these issues.
4 participants
@NachoEchevarria @andrewlock @robertpi @daniel-romano-DD