[Profiler] Adjust profiler tests for .NET 8 #4908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area:profiler
andrewlock
approved these changes
Nov 22, 2023
| @@ -46,16 +46,11 @@ public void ThrowExceptionsInParallel(string appName, string framework, string a | |||
| new StackFrame("|lm:Samples.ExceptionGenerator |ns:Samples.ExceptionGenerator |ct:ParallelExceptionsScenario |cg: |fn:ThrowExceptions |fg: |sg:(object state)"), | |||
| new StackFrame("|lm:System.Private.CoreLib |ns:System.Threading |ct:Thread |cg: |fn:StartCallback |fg: |sg:()")); | |||
| } | |||
| else if (framework == "net7.0") | |||
| else if (framework == "net7.0" || framework == "net8.0") | |||
There was a problem hiding this comment.
Ok, I probably should have just tried that 😂 🤦♂️
Datadog ReportBranch report: ✅ |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (71ms) : 62, 79
. : milestone, 71,
master - mean (69ms) : 64, 75
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (1,002ms) : 986, 1019
. : milestone, 1002,
master - mean (1,001ms) : 983, 1018
. : milestone, 1001,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (106ms) : 103, 109
. : milestone, 106,
master - mean (106ms) : 102, 109
. : milestone, 106,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (688ms) : 676, 701
. : milestone, 688,
master - mean (683ms) : 662, 703
. : milestone, 683,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (90ms) : 87, 93
. : milestone, 90,
master - mean (89ms) : 85, 93
. : milestone, 89,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (657ms) : 635, 680
. : milestone, 657,
master - mean (645ms) : 626, 663
. : milestone, 645,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (188ms) : 185, 192
. : milestone, 188,
master - mean (188ms) : 185, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (1,133ms) : 1114, 1151
. : milestone, 1133,
master - mean (1,131ms) : 1107, 1154
. : milestone, 1131,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (271ms) : 267, 276
. : milestone, 271,
master - mean (271ms) : 267, 275
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (1,090ms) : 1066, 1115
. : milestone, 1090,
master - mean (1,093ms) : 1073, 1112
. : milestone, 1093,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4908) - mean (261ms) : 258, 264
. : milestone, 261,
master - mean (261ms) : 257, 264
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (4908) - mean (1,055ms) : 1031, 1078
. : milestone, 1055,
master - mean (1,052ms) : 1027, 1077
. : milestone, 1052,
|
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (4908) (11.122M) : 0, 11121584
master (10.396M) : 0, 10395672
benchmarks/2.9.0 (10.751M) : 0, 10751314
section Automatic
This PR (4908) (7.719M) : 0, 7718765
master (7.145M) : 0, 7145006
benchmarks/2.9.0 (7.729M) : 0, 7729266
section Trace stats
This PR (4908) (7.951M) : 0, 7951132
master (7.700M) : 0, 7700179
section Manual
This PR (4908) (9.735M) : 0, 9735140
master (9.446M) : 0, 9445718
section Manual + Automatic
This PR (4908) (7.260M) : 0, 7259909
master (6.911M) : 0, 6911059
section Version Conflict
This PR (4908) (6.522M) : 0, 6521606
master (6.211M) : 0, 6210835
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (4908) (9.578M) : 0, 9578446
master (9.572M) : 0, 9571510
benchmarks/2.9.0 (9.490M) : 0, 9489859
section Automatic
This PR (4908) (6.682M) : 0, 6682118
master (6.574M) : 0, 6573799
section Trace stats
This PR (4908) (6.776M) : 0, 6776217
master (6.837M) : 0, 6837209
section Manual
This PR (4908) (8.449M) : 0, 8448837
master (8.251M) : 0, 8251366
section Manual + Automatic
This PR (4908) (6.083M) : 0, 6083250
master (6.127M) : 0, 6127190
section Version Conflict
This PR (4908) (5.652M) : 0, 5652444
master (5.734M) : 0, 5734389
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (4908) (10.216M) : 0, 10215890
master (10.415M) : 0, 10415079
benchmarks/2.9.0 (10.713M) : 0, 10713473
section Automatic
This PR (4908) (7.434M) : 0, 7434458
master (7.469M) : 0, 7469260
benchmarks/2.9.0 (7.794M) : 0, 7793548
section Trace stats
This PR (4908) (7.849M) : 0, 7848729
master (7.782M) : 0, 7781517
section Manual
This PR (4908) (9.241M) : 0, 9240770
master (8.597M) : 0, 8597087
section Manual + Automatic
This PR (4908) (7.150M) : 0, 7150375
master (7.172M) : 0, 7171785
section Version Conflict
This PR (4908) (6.486M) : 0, 6485694
master (6.438M) : 0, 6438222
gantt
title Throughput Linux x64 (ASM) (Total requests)
dateFormat X
axisFormat %s
section Baseline
master (7.348M) : 0, 7347949
benchmarks/2.9.0 (7.740M) : 0, 7740230
section No attack
master (1.952M) : 0, 1951931
benchmarks/2.9.0 (3.137M) : 0, 3136803
section Attack
master (1.562M) : 0, 1561818
benchmarks/2.9.0 (2.515M) : 0, 2514667
section Blocking
master (3.244M) : 0, 3243575
section IAST default
master (6.423M) : 0, 6423099
section IAST full
master (5.770M) : 0, 5770131
section Base vuln
master (0.941M) : 0, 941404
section IAST vuln
master (0.886M) : 0, 885635
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adjust checks for profiler tests for .NET 8
Reason for change
really ?
Implementation details
Adjust the checks according to the CLR version.
Test coverage
The current tests.
Other details