Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout benchmarks #4919

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

anna-git
Copy link
Contributor

Summary of changes

Revert to older encoder makes benchmarks much slower, or timeout. Increase timeout for now

Reason for change

Implementation details

Test coverage

Other details

@anna-git anna-git requested a review from a team as a code owner November 23, 2023 10:23
@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Nov 23, 2023
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, now that's a timeout 😂

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 23, 2023

Datadog Report

Branch report: anna/increase-timeout-benchmarks
Commit report: c15ce51

dd-trace-dotnet: 0 Failed, 0 New Flaky, 302434 Passed, 941 Skipped, 49m 21.36s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (71ms)  : 62, 81
     .   : milestone, 71,
    master - mean (70ms)  : 62, 78
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (994ms)  : 971, 1018
     .   : milestone, 994,
    master - mean (998ms)  : 982, 1013
     .   : milestone, 998,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (686ms)  : 665, 706
     .   : milestone, 686,
    master - mean (686ms)  : 667, 705
     .   : milestone, 686,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (90ms)  : 86, 94
     .   : milestone, 90,
    master - mean (90ms)  : 87, 92
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (657ms)  : 635, 680
     .   : milestone, 657,
    master - mean (661ms)  : 634, 687
     .   : milestone, 661,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (188ms)  : 185, 192
     .   : milestone, 188,
    master - mean (188ms)  : 186, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (1,132ms)  : 1112, 1153
     .   : milestone, 1132,
    master - mean (1,136ms)  : 1115, 1157
     .   : milestone, 1136,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (1,091ms)  : 1063, 1120
     .   : milestone, 1091,
    master - mean (1,092ms)  : 1066, 1118
     .   : milestone, 1092,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4919) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (4919) - mean (1,058ms)  : 1032, 1083
     .   : milestone, 1058,
    master - mean (1,059ms)  : 1036, 1081
     .   : milestone, 1059,

Loading

@anna-git anna-git merged commit 6d7c135 into master Nov 23, 2023
51 of 54 checks passed
@anna-git anna-git deleted the anna/increase-timeout-benchmarks branch November 23, 2023 19:20
@github-actions github-actions bot added this to the vNext milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants