Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dd_dotnet version #4923

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Fix dd_dotnet version #4923

merged 1 commit into from
Nov 27, 2023

Conversation

andrewlock
Copy link
Member

Summary of changes

Fix the version of dd_dotnet and ensure it's updated correctly during release

Reason for change

We're shipping with an old version number embedded, because we forgot to set it to auto-update

Implementation details

  • Update the version
  • Update the update script
  • Update the verification script

Test coverage

Meh, I'm sure it's fine

Other details

It shouldn't really matter that we're embedded the wrong version. We're shipping the binary as part of the installers etc, so it's really just a nicety later. But better to fix to avoid any confusion later.

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tools labels Nov 24, 2023
@andrewlock andrewlock requested review from a team as code owners November 24, 2023 15:21
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Nov 24, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/fix-dd_dotnet-version
Commit report: d6a1c5c

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 303167 Passed, 941 Skipped, 30m 34.07s Wall Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (70ms)  : 60, 79
     .   : milestone, 70,
    master - mean (71ms)  : 61, 81
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (992ms)  : 969, 1014
     .   : milestone, 992,
    master - mean (988ms)  : 970, 1006
     .   : milestone, 988,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (105ms)  : 100, 109
     .   : milestone, 105,
    master - mean (106ms)  : 103, 109
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (684ms)  : 664, 703
     .   : milestone, 684,
    master - mean (684ms)  : 662, 707
     .   : milestone, 684,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (89ms)  : 86, 92
     .   : milestone, 89,
    master - mean (90ms)  : 86, 94
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (657ms)  : 636, 678
     .   : milestone, 657,
    master - mean (654ms)  : 628, 679
     .   : milestone, 654,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (188ms)  : 184, 192
     .   : milestone, 188,
    master - mean (189ms)  : 185, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (1,131ms)  : 1110, 1151
     .   : milestone, 1131,
    master - mean (1,132ms)  : 1111, 1152
     .   : milestone, 1132,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (272ms)  : 267, 276
     .   : milestone, 272,
    master - mean (272ms)  : 269, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (1,085ms)  : 1061, 1109
     .   : milestone, 1085,
    master - mean (1,088ms)  : 1063, 1112
     .   : milestone, 1088,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4923) - mean (261ms)  : 258, 264
     .   : milestone, 261,
    master - mean (261ms)  : 256, 266
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (4923) - mean (1,061ms)  : 1037, 1086
     .   : milestone, 1061,
    master - mean (1,056ms)  : 1022, 1091
     .   : milestone, 1056,
Loading

pierotibou
pierotibou approved these changes Nov 24, 2023
View reviewed changes
Copy link
Collaborator

@pierotibou pierotibou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted.
We could maybe have another check in the version bump PR, that lists all the location where we don't have the last version? We could be listing known cases to make sure we don't have miss any new use case?

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4923) (11.083M)   : 0, 11082714
    master (11.277M)   : 0, 11276600
    benchmarks/2.9.0 (11.363M)   : 0, 11362982

    section Automatic
    This PR (4923) (7.598M)   : 0, 7598062
    master (7.961M)   : 0, 7961421
    benchmarks/2.9.0 (8.259M)   : 0, 8258618

    section Trace stats
    This PR (4923) (7.883M)   : 0, 7882856
    master (8.292M)   : 0, 8292192

    section Manual
    This PR (4923) (9.637M)   : crit ,0, 9636562
    master (10.227M)   : 0, 10226578

    section Manual + Automatic
    This PR (4923) (7.211M)   : 0, 7210702
    master (7.570M)   : 0, 7569784

    section Version Conflict
    This PR (4923) (6.624M)   : 0, 6623511
    master (6.911M)   : 0, 6910659
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4923) (9.694M)   : 0, 9694328
    master (9.369M)   : 0, 9369406
    benchmarks/2.9.0 (9.602M)   : 0, 9602224

    section Automatic
    This PR (4923) (6.629M)   : 0, 6629187
    master (6.590M)   : 0, 6589721

    section Trace stats
    This PR (4923) (6.921M)   : 0, 6920763
    master (6.881M)   : 0, 6880601

    section Manual
    This PR (4923) (8.340M)   : 0, 8339793
    master (8.376M)   : 0, 8376065

    section Manual + Automatic
    This PR (4923) (6.158M)   : 0, 6157697
    master (6.280M)   : 0, 6279721

    section Version Conflict
    This PR (4923) (5.702M)   : 0, 5702135
    master (5.781M)   : 0, 5781273
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4923) (9.948M)   : 0, 9948176
    master (10.178M)   : 0, 10178082
    benchmarks/2.9.0 (10.259M)   : 0, 10259311

    section Automatic
    This PR (4923) (7.110M)   : 0, 7109608
    master (7.041M)   : 0, 7040704
    benchmarks/2.9.0 (7.710M)   : 0, 7709529

    section Trace stats
    This PR (4923) (7.491M)   : 0, 7490756
    master (7.380M)   : 0, 7380092

    section Manual
    This PR (4923) (8.812M)   : 0, 8812160
    master (8.704M)   : 0, 8704149

    section Manual + Automatic
    This PR (4923) (6.909M)   : 0, 6908629
    master (6.847M)   : 0, 6847196

    section Version Conflict
    This PR (4923) (6.370M)   : 0, 6370276
    master (6.173M)   : 0, 6172737
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.484M)   : 0, 7484299
    benchmarks/2.9.0 (7.830M)   : 0, 7830154

    section No attack
    master (1.976M)   : 0, 1976084
    benchmarks/2.9.0 (3.253M)   : 0, 3253296

    section Attack
    master (1.571M)   : 0, 1570756
    benchmarks/2.9.0 (2.541M)   : 0, 2540898

    section Blocking
    master (3.270M)   : 0, 3269537

    section IAST default
    master (6.526M)   : 0, 6526200

    section IAST full
    master (5.776M)   : 0, 5776176

    section Base vuln
    master (0.963M)   : 0, 962837

    section IAST vuln
    master (0.898M)   : 0, 897732
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report 🐌

Benchmarks for #4923 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.221
  • 1 benchmarks are slower, with geometric mean 1.260
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.79μs 45.4ns 208ns 0.0206 0.00822 0 7.48 KB
master StartStopWithChild netcoreapp3.1 10.9μs 60.7ns 359ns 0.0219 0.011 0 7.57 KB
master StartStopWithChild net472 17.3μs 42.7ns 165ns 1.35 0.356 0.127 7.96 KB
#4923 StartStopWithChild net6.0 8.8μs 48.9ns 305ns 0.0165 0.00823 0 7.48 KB
#4923 StartStopWithChild netcoreapp3.1 10.6μs 53.6ns 251ns 0.0262 0.0105 0 7.57 KB
#4923 StartStopWithChild net472 17μs 58.2ns 225ns 1.35 0.365 0.108 7.95 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 462μs 423ns 1.64μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 630μs 148ns 572ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 774μs 175ns 607ns 0.388 0 0 3.3 KB
#4923 WriteAndFlushEnrichedTraces net6.0 463μs 207ns 773ns 0 0 0 2.7 KB
#4923 WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 185ns 716ns 0 0 0 2.7 KB
#4923 WriteAndFlushEnrichedTraces net472 788μs 362ns 1.4μs 0.396 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 43.2μs 28.5ns 103ns 0.0219 0 0 1.77 KB
master AllCycleSimpleBody netcoreapp3.1 46.6μs 71.3ns 276ns 0.023 0 0 1.74 KB
master AllCycleSimpleBody net472 49.5μs 100ns 389ns 0.272 0 0 1.81 KB
master AllCycleMoreComplexBody net6.0 212μs 64.8ns 251ns 0.105 0 0 9.25 KB
master AllCycleMoreComplexBody netcoreapp3.1 224μs 204ns 763ns 0.112 0 0 9.14 KB
master AllCycleMoreComplexBody net472 237μs 108ns 375ns 1.42 0 0 9.32 KB
master ObjectExtractorSimpleBody net6.0 131ns 0.0561ns 0.21ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 183ns 0.108ns 0.373ns 0.00381 0 0 272 B
master ObjectExtractorSimpleBody net472 151ns 0.0564ns 0.203ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.77μs 1.05ns 3.93ns 0.0531 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.6μs 1.39ns 5.38ns 0.0505 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.46μs 3.84ns 14.9ns 0.602 0.00518 0 3.8 KB
#4923 AllCycleSimpleBody net6.0 42.4μs 27.9ns 108ns 0.0218 0 0 1.77 KB
#4923 AllCycleSimpleBody netcoreapp3.1 47.6μs 138ns 516ns 0.0233 0 0 1.74 KB
#4923 AllCycleSimpleBody net472 49.9μs 131ns 508ns 0.271 0 0 1.81 KB
#4923 AllCycleMoreComplexBody net6.0 214μs 538ns 1.86μs 0.105 0 0 9.25 KB
#4923 AllCycleMoreComplexBody netcoreapp3.1 237μs 1.61μs 16.1μs 0.112 0 0 9.14 KB
#4923 AllCycleMoreComplexBody net472 238μs 145ns 524ns 1.43 0 0 9.32 KB
#4923 ObjectExtractorSimpleBody net6.0 131ns 0.0574ns 0.215ns 0.00397 0 0 280 B
#4923 ObjectExtractorSimpleBody netcoreapp3.1 183ns 0.063ns 0.218ns 0.00373 0 0 272 B
#4923 ObjectExtractorSimpleBody net472 155ns 0.0935ns 0.362ns 0.0446 0 0 281 B
#4923 ObjectExtractorMoreComplexBody net6.0 2.82μs 1.71ns 6.39ns 0.0524 0 0 3.78 KB
#4923 ObjectExtractorMoreComplexBody netcoreapp3.1 3.6μs 1.39ns 5.18ns 0.0501 0 0 3.69 KB
#4923 ObjectExtractorMoreComplexBody net472 3.59μs 1.28ns 4.79ns 0.603 0.00538 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 51.2μs 290ns 1.99μs 0.221 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 67.1μs 318ns 1.27μs 0.198 0 0 16.06 KB
master RunWaf(args=NestedMap (10)) net472 93.9μs 42.2ns 158ns 2.53 0.0936 0 16.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 113μs 39.4ns 147ns 0.283 0 0 22.41 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 140μs 649ns 2.51μs 0.267 0 0 22.36 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 168μs 56.6ns 212ns 3.57 0.166 0 22.7 KB
master RunWaf(args=NestedMap (100)) net6.0 109μs 95.1ns 368ns 0.434 0 0 32.76 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 133μs 717ns 4.18μs 0.407 0 0 33.33 KB
master RunWaf(args=NestedMap (100)) net472 183μs 364ns 1.41μs 5.27 0.363 0 33.67 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 176μs 51.9ns 194ns 0.527 0 0 39.1 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 207μs 921ns 3.57μs 0.501 0 0 39.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 267μs 321ns 1.24μs 6.37 0.52 0 40.23 KB
master RunWaf(args=NestedMap (20)) net6.0 99μs 510ns 2.39μs 0.456 0 0 32.18 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 132μs 760ns 6.08μs 0.435 0 0 32.3 KB
master RunWaf(args=NestedMap (20)) net472 193μs 290ns 1.12μs 5.12 0.365 0 32.63 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 176μs 962ns 5.53μs 0.52 0 0 38.53 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 205μs 532ns 2.06μs 0.511 0 0 38.6 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 262μs 202ns 756ns 6.22 0.519 0 39.2 KB
#4923 RunWaf(args=NestedMap (10)) net6.0 53.8μs 125ns 483ns 0.222 0 0 16.06 KB
#4923 RunWaf(args=NestedMap (10)) netcoreapp3.1 65.5μs 368ns 2.5μs 0.222 0 0 16.06 KB
#4923 RunWaf(args=NestedMap (10)) net472 94.5μs 50.1ns 194ns 2.56 0.0948 0 16.14 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 113μs 28.9ns 104ns 0.29 0 0 22.41 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 140μs 583ns 2.02μs 0.282 0 0 22.36 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) net472 168μs 842ns 3.57μs 3.55 0.165 0 22.7 KB
#4923 RunWaf(args=NestedMap (100)) net6.0 105μs 44.2ns 165ns 0.407 0 0 32.76 KB
#4923 RunWaf(args=NestedMap (100)) netcoreapp3.1 132μs 712ns 3.7μs 0.466 0 0 33.33 KB
#4923 RunWaf(args=NestedMap (100)) net472 194μs 96.3ns 373ns 5.28 0.37 0 33.67 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 162μs 75.4ns 292ns 0.512 0 0 39.1 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 206μs 742ns 2.87μs 0.508 0 0 39.63 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [23]) net472 267μs 1.1μs 4.1μs 6.34 0.518 0 40.23 KB
#4923 RunWaf(args=NestedMap (20)) net6.0 103μs 589ns 4.64μs 0.45 0 0 32.18 KB
#4923 RunWaf(args=NestedMap (20)) netcoreapp3.1 136μs 288ns 1.12μs 0.406 0 0 32.3 KB
#4923 RunWaf(args=NestedMap (20)) net472 182μs 139ns 537ns 5.16 0.362 0 32.63 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 171μs 59.5ns 230ns 0.524 0 0 38.53 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 211μs 1.06μs 4.75μs 0.531 0 0 38.6 KB
#4923 RunWafWithAttack(args=Neste(...)tack) [22]) net472 257μs 151ns 524ns 6.21 0.518 0 39.2 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 174μs 125ns 482ns 0.259 0 0 18.24 KB
master SendRequest netcoreapp3.1 193μs 280ns 1.08μs 0.193 0 0 20.4 KB
master SendRequest net472 0.000361ns 0.00015ns 0.00052ns 0 0 0 0 b
#4923 SendRequest net6.0 173μs 149ns 576ns 0.259 0 0 18.24 KB
#4923 SendRequest netcoreapp3.1 192μs 273ns 1.06μs 0.192 0 0 20.4 KB
#4923 SendRequest net472 8.16E‑05ns 5.9E‑05ns 0.000221ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4923

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.56 KB 41.8 KB 242 B 0.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 538μs 163ns 631ns 0.551 0 0 41.56 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 1.36μs 5.28μs 0.332 0 0 41.68 KB
master WriteAndFlushEnrichedTraces net472 819μs 3.42μs 13.2μs 8.28 2.48 0.414 53.22 KB
#4923 WriteAndFlushEnrichedTraces net6.0 560μs 561ns 2.17μs 0.558 0 0 41.8 KB
#4923 WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 1.01μs 3.78μs 0.322 0 0 41.82 KB
#4923 WriteAndFlushEnrichedTraces net472 861μs 2.54μs 9.52μs 8.45 2.53 0.422 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.05μs 0.508ns 1.97ns 0.011 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.44μs 0.497ns 1.72ns 0.0101 0 0 768 B
master ExecuteNonQuery net472 1.7μs 0.651ns 2.52ns 0.116 0 0 730 B
#4923 ExecuteNonQuery net6.0 1.07μs 0.521ns 2.02ns 0.0107 0 0 768 B
#4923 ExecuteNonQuery netcoreapp3.1 1.43μs 0.45ns 1.74ns 0.0101 0 0 768 B
#4923 ExecuteNonQuery net472 1.71μs 2.64ns 9.88ns 0.115 0.000854 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 0.497ns 1.86ns 0.0129 0 0 936 B
master CallElasticsearch netcoreapp3.1 1.55μs 2.02ns 7.83ns 0.0126 0 0 936 B
master CallElasticsearch net472 2.58μs 0.663ns 2.57ns 0.151 0 0 955 B
master CallElasticsearchAsync net6.0 1.24μs 0.387ns 1.45ns 0.0124 0 0 912 B
master CallElasticsearchAsync netcoreapp3.1 1.61μs 4.71ns 18.2ns 0.0128 0 0 984 B
master CallElasticsearchAsync net472 2.68μs 1.34ns 5.2ns 0.16 0.00134 0 1.01 KB
#4923 CallElasticsearch net6.0 1.14μs 0.572ns 2.22ns 0.0132 0 0 936 B
#4923 CallElasticsearch netcoreapp3.1 1.47μs 0.704ns 2.63ns 0.0126 0 0 936 B
#4923 CallElasticsearch net472 2.48μs 0.679ns 2.54ns 0.151 0 0 955 B
#4923 CallElasticsearchAsync net6.0 1.27μs 0.507ns 1.9ns 0.0128 0 0 912 B
#4923 CallElasticsearchAsync netcoreapp3.1 1.63μs 1.01ns 3.8ns 0.0131 0 0 984 B
#4923 CallElasticsearchAsync net472 2.55μs 0.6ns 2.24ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 0.989ns 3.7ns 0.0129 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.62μs 0.668ns 2.41ns 0.012 0 0 912 B
master ExecuteAsync net472 1.79μs 0.621ns 2.41ns 0.139 0 0 875 B
#4923 ExecuteAsync net6.0 1.32μs 1.02ns 3.83ns 0.0126 0 0 912 B
#4923 ExecuteAsync netcoreapp3.1 1.72μs 1.29ns 4.98ns 0.0119 0 0 912 B
#4923 ExecuteAsync net472 1.92μs 1.11ns 4.17ns 0.138 0 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.99μs 1.9ns 6.86ns 0.0296 0 0 2.1 KB
master SendAsync netcoreapp3.1 5.05μs 1.72ns 6.21ns 0.0355 0 0 2.63 KB
master SendAsync net472 7.78μs 2.27ns 8.8ns 0.524 0 0 3.31 KB
#4923 SendAsync net6.0 3.97μs 1.58ns 6.12ns 0.0299 0 0 2.1 KB
#4923 SendAsync netcoreapp3.1 5μs 2.86ns 11.1ns 0.0348 0 0 2.63 KB
#4923 SendAsync net472 7.86μs 3.3ns 12.8ns 0.525 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #4923

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472 1.293 63,600.00 49,200.00
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net6.0 1.171 60,200.00 51,400.00 bimodal

More allocations ⚠️ in #4923

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472 57.34 KB 73.73 KB 16.38 KB 28.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 59.6μs 671ns 6.68μs 0 0 0 43.44 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 61.6μs 907ns 8.93μs 0 0 0 42.64 KB
master StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38.1μs 95.1ns 343ns 0 0 0 59.66 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 66.7μs 321ns 1.32μs 0 0 0 43.29 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 101μs 460ns 1.78μs 0 0 0 42.78 KB
master StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 63.8μs 213ns 766ns 0 0 0 57.34 KB
#4923 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net6.0 51.3μs 259ns 1.13μs 0 0 0 43.44 KB
#4923 StringConcatBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 62.5μs 923ns 9.05μs 0 0 0 42.64 KB
#4923 StringConcatBenchmark(parameters=Syste(...)ring] [48]) net472 38μs 144ns 539ns 0 0 0 59.66 KB
#4923 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net6.0 91.4μs 3.01μs 30.1μs 0 0 0 43.29 KB
#4923 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) netcoreapp3.1 100μs 2.8μs 28μs 0 0 0 42.64 KB
#4923 StringConcatAspectBenchmark(parameters=Syste(...)ring] [48]) net472 53.5μs 788ns 7.76μs 0 0 0 73.73 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.49μs 0.396ns 1.48ns 0.0223 0 0 1.57 KB
master EnrichedLog netcoreapp3.1 2.09μs 2.9ns 10.8ns 0.0209 0 0 1.57 KB
master EnrichedLog net472 2.63μs 2.85ns 11.1ns 0.237 0 0 1.5 KB
#4923 EnrichedLog net6.0 1.56μs 0.748ns 2.9ns 0.0224 0 0 1.57 KB
#4923 EnrichedLog netcoreapp3.1 2.13μs 1.25ns 4.67ns 0.0215 0 0 1.57 KB
#4923 EnrichedLog net472 2.58μs 1.4ns 5.24ns 0.237 0 0 1.5 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 59.8ns 224ns 0.0553 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 119μs 289ns 1.12μs 0.0589 0 0 4.21 KB
master EnrichedLog net472 147μs 164ns 634ns 0.671 0.224 0 4.39 KB
#4923 EnrichedLog net6.0 113μs 103ns 387ns 0.0564 0 0 4.21 KB
#4923 EnrichedLog netcoreapp3.1 118μs 150ns 580ns 0 0 0 4.21 KB
#4923 EnrichedLog net472 145μs 63ns 244ns 0.657 0.219 0 4.39 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.96μs 0.558ns 2.09ns 0.0294 0 0 2.13 KB
master EnrichedLog netcoreapp3.1 4.33μs 3.33ns 12.9ns 0.0281 0 0 2.13 KB
master EnrichedLog net472 4.88μs 3.86ns 14.5ns 0.308 0 0 1.95 KB
#4923 EnrichedLog net6.0 3μs 1.12ns 4.35ns 0.0298 0 0 2.13 KB
#4923 EnrichedLog netcoreapp3.1 4.21μs 2.74ns 10.6ns 0.0292 0 0 2.13 KB
#4923 EnrichedLog net472 4.78μs 3.15ns 12.2ns 0.308 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.32μs 0.552ns 2.14ns 0.0158 0 0 1.1 KB
master SendReceive netcoreapp3.1 1.79μs 0.548ns 2.12ns 0.0152 0 0 1.1 KB
master SendReceive net472 2.12μs 1.85ns 7.16ns 0.177 0.00105 0 1.12 KB
#4923 SendReceive net6.0 1.41μs 1.14ns 4.26ns 0.0156 0 0 1.1 KB
#4923 SendReceive netcoreapp3.1 1.71μs 1.71ns 6.61ns 0.0146 0 0 1.1 KB
#4923 SendReceive net472 2.18μs 1.9ns 7.34ns 0.177 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 1.86ns 7.2ns 0.0214 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.85μs 1ns 3.76ns 0.0212 0 0 1.58 KB
master EnrichedLog net472 4.36μs 1.59ns 6.17ns 0.312 0 0 1.97 KB
#4923 EnrichedLog net6.0 2.86μs 0.832ns 3.11ns 0.0209 0 0 1.53 KB
#4923 EnrichedLog netcoreapp3.1 3.89μs 1.45ns 5.62ns 0.0213 0 0 1.58 KB
#4923 EnrichedLog net472 4.21μs 3.5ns 13.6ns 0.312 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4923

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.260 520.15 655.34

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 523ns 0.282ns 1.06ns 0.00754 0 0 536 B
master StartFinishSpan netcoreapp3.1 675ns 0.247ns 0.925ns 0.00743 0 0 536 B
master StartFinishSpan net472 844ns 0.427ns 1.66ns 0.0852 0 0 538 B
master StartFinishScope net6.0 520ns 0.158ns 0.611ns 0.00917 0 0 656 B
master StartFinishScope netcoreapp3.1 794ns 0.22ns 0.854ns 0.00886 0 0 656 B
master StartFinishScope net472 1.01μs 0.563ns 2.11ns 0.0977 0 0 618 B
#4923 StartFinishSpan net6.0 487ns 0.151ns 0.585ns 0.00738 0 0 536 B
#4923 StartFinishSpan netcoreapp3.1 692ns 0.218ns 0.815ns 0.00698 0 0 536 B
#4923 StartFinishSpan net472 805ns 0.195ns 0.702ns 0.0851 0 0 538 B
#4923 StartFinishScope net6.0 655ns 0.197ns 0.764ns 0.0092 0 0 656 B
#4923 StartFinishScope netcoreapp3.1 871ns 0.376ns 1.46ns 0.00857 0 0 656 B
#4923 StartFinishScope net472 977ns 0.573ns 2.22ns 0.0982 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4923

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.202 744.99 619.85

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 745ns 0.25ns 0.968ns 0.00927 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 934ns 0.28ns 1.05ns 0.00896 0 0 656 B
master RunOnMethodBegin net472 1.24μs 0.448ns 1.74ns 0.0976 0 0 618 B
#4923 RunOnMethodBegin net6.0 620ns 0.282ns 1.09ns 0.00928 0 0 656 B
#4923 RunOnMethodBegin netcoreapp3.1 975ns 2ns 7.22ns 0.00862 0 0 656 B
#4923 RunOnMethodBegin net472 1.2μs 0.482ns 1.87ns 0.098 0 0 618 B

@andrewlock
Copy link
Member Author

We could maybe have another check in the version bump PR, that lists all the location where we don't have the last version? We could be listing known cases to make sure we don't have miss any new use case?

It's a nice idea, but the heuristics could be tricky. How do we find "not last version"? Bearing in mind that we intentionally don't have "last version" in lots of places...

I think we'd basically be searching every file for something that looks like a version number, but there will be thousands, so then we try to filter out ones we don't care about... Tbh, we so rarely create new projects, I'm not sure it's worth it...

@andrewlock andrewlock merged commit d7189f2 into master Nov 27, 2023
54 checks passed
@andrewlock andrewlock deleted the andrew/fix-dd_dotnet-version branch November 27, 2023 12:46
@github-actions github-actions bot added this to the vNext milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierotibou pierotibou pierotibou approved these changes

@kevingosse kevingosse kevingosse approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tools
Projects
None yet
Milestone
2.43.0
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewlock @kevingosse @pierotibou