[Version Bump] 3.0.0-prerelease #4924

github-actions · 2023-11-24T15:35:11Z

The following files were found to be modified (as expected)

profiler/src/ProfilerEngine/Datadog.Profiler.Native.Linux/CMakeLists.txt
profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/Resource.rc
profiler/src/ProfilerEngine/Datadog.Profiler.Native/dd_profiler_version.h
profiler/src/ProfilerEngine/Datadog.Linux.ApiWrapper/CMakeLists.txt
profiler/src/ProfilerEngine/ProductVersion.props
shared/src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt
shared/src/Datadog.Trace.ClrProfiler.Native/Resource.rc
shared/src/msi-installer/WindowsInstaller.wixproj
tracer/build/artifacts/dd-dotnet.sh
tracer/build/_build/Build.cs
tracer/samples/AutomaticTraceIdInjection/MicrosoftExtensionsExample/MicrosoftExtensionsExample.csproj
tracer/samples/AutomaticTraceIdInjection/Log4NetExample/Log4NetExample.csproj
tracer/samples/AutomaticTraceIdInjection/NLog40Example/NLog40Example.csproj
tracer/samples/AutomaticTraceIdInjection/NLog45Example/NLog45Example.csproj
tracer/samples/AutomaticTraceIdInjection/NLog46Example/NLog46Example.csproj
tracer/samples/AutomaticTraceIdInjection/SerilogExample/SerilogExample.csproj
tracer/samples/ConsoleApp/Alpine3.10.dockerfile
tracer/samples/ConsoleApp/Alpine3.9.dockerfile
tracer/samples/ConsoleApp/Debian.dockerfile
tracer/samples/WindowsContainer/Dockerfile
tracer/src/Datadog.Trace.Bundle/Datadog.Trace.Bundle.csproj
tracer/src/Datadog.Trace.AspNet/Datadog.Trace.AspNet.csproj
tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Datadog.Trace.ClrProfiler.Managed.Loader.csproj
tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs
tracer/src/Datadog.Tracer.Native/CMakeLists.txt
tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h
tracer/src/Datadog.Tracer.Native/Resource.rc
tracer/src/Datadog.Tracer.Native/version.h
tracer/src/Datadog.Trace.MSBuild/Datadog.Trace.MSBuild.csproj
tracer/src/Datadog.Trace.BenchmarkDotNet/Datadog.Trace.BenchmarkDotNet.csproj
tracer/src/Datadog.Trace.OpenTracing/Datadog.Trace.OpenTracing.csproj
tracer/src/Datadog.Trace.Tools.Runner/Datadog.Trace.Tools.Runner.csproj
tracer/src/Datadog.Trace/Datadog.Trace.csproj
tracer/src/Datadog.Trace/TracerConstants.cs
tracer/src/Datadog.Trace.Trimming/Datadog.Trace.Trimming.csproj
tracer/tools/PipelineMonitor/PipelineMonitor.csproj

@DataDog/apm-dotnet

andrewlock

OK, the title was created a bit weird, but it's fine 😅

Need to think about version mismatch issues in the samples, but otherwise, it'll do for now

datadog-ddstaging · 2023-11-24T15:56:21Z

Datadog Report

Branch report: version-bump-2.43.0
Commit report: 74f65c0

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 304891 Passed, 1666 Skipped, 46m 13.79s Wall Time

andrewlock · 2023-11-24T16:11:18Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (71ms)  : 63, 80
     .   : milestone, 71,
    master - mean (70ms)  : 62, 79
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (1,002ms)  : 989, 1016
     .   : milestone, 1002,
    master - mean (996ms)  : 973, 1019
     .   : milestone, 996,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (106ms)  : 103, 109
     .   : milestone, 106,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (690ms)  : 673, 706
     .   : milestone, 690,
    master - mean (685ms)  : 667, 703
     .   : milestone, 685,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (92ms)  : 80, 105
     .   : milestone, 92,
    master - mean (89ms)  : 86, 92
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (659ms)  : 636, 681
     .   : milestone, 659,
    master - mean (656ms)  : 631, 680
     .   : milestone, 656,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (189ms)  : 186, 193
     .   : milestone, 189,
    master - mean (188ms)  : 182, 195
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (1,133ms)  : 1115, 1152
     .   : milestone, 1133,
    master - mean (1,131ms)  : 1112, 1150
     .   : milestone, 1131,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (271ms)  : 268, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (1,094ms)  : 1072, 1117
     .   : milestone, 1094,
    master - mean (1,089ms)  : 1059, 1119
     .   : milestone, 1089,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4924) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (261ms)  : 257, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (4924) - mean (1,051ms)  : 1024, 1078
     .   : milestone, 1051,
    master - mean (1,056ms)  : 1030, 1082
     .   : milestone, 1056,

andrewlock · 2023-11-24T18:09:05Z

Benchmarks Report 🐌

Benchmarks for #4924 compared to master:

1 benchmarks are faster, with geometric mean 1.171
7 benchmarks are slower, with geometric mean 1.153
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.53μs	48ns	311ns	0.0215	0.0086	0	7.48 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	46.5ns	180ns	0.0254	0.00508	0	7.58 KB
master	`StartStopWithChild`	net472	17μs	39.1ns	151ns	1.32	0.321	0.104	7.95 KB
#4924	`StartStopWithChild`	net6.0	8.41μs	39.1ns	161ns	0.0208	0.00416	0	7.48 KB
#4924	`StartStopWithChild`	netcoreapp3.1	10.7μs	51.5ns	219ns	0.0269	0.0108	0	7.57 KB
#4924	`StartStopWithChild`	net472	16.7μs	39.9ns	154ns	1.34	0.352	0.117	7.95 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	476μs	555ns	2.15μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	631μs	341ns	1.32μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	776μs	242ns	938ns	0.388	3.3 KB
#4924	`WriteAndFlushEnrichedTraces`	net6.0	461μs	496ns	1.86μs	0	2.7 KB
#4924	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	1.57μs	6.09μs	0	2.7 KB
#4924	`WriteAndFlushEnrichedTraces`	net472	780μs	449ns	1.74μs	0.388	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1	1.250	185.39	231.74

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	43.7μs	12.2ns	45.6ns	0.0218	0	1.77 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	46.6μs	37.8ns	141ns	0.0233	0	1.74 KB
master	`AllCycleSimpleBody`	net472	48.8μs	118ns	456ns	0.265	0	1.81 KB
master	`AllCycleMoreComplexBody`	net6.0	213μs	66.8ns	250ns	0.106	0	9.25 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	225μs	192ns	744ns	0.113	0	9.14 KB
master	`AllCycleMoreComplexBody`	net472	238μs	80.8ns	313ns	1.42	0	9.32 KB
master	`ObjectExtractorSimpleBody`	net6.0	131ns	0.0609ns	0.228ns	0.00396	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	185ns	0.0859ns	0.333ns	0.00374	0	272 B
master	`ObjectExtractorSimpleBody`	net472	151ns	0.104ns	0.402ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.78μs	0.908ns	3.4ns	0.0527	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.74μs	1.75ns	6.06ns	0.0503	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.49μs	2.68ns	9.66ns	0.603	0.00523	3.8 KB
#4924	`AllCycleSimpleBody`	net6.0	43.9μs	25.5ns	98.7ns	0.0221	0	1.77 KB
#4924	`AllCycleSimpleBody`	netcoreapp3.1	47.3μs	28.6ns	107ns	0	0	1.74 KB
#4924	`AllCycleSimpleBody`	net472	49.7μs	19.4ns	75.1ns	0.268	0	1.81 KB
#4924	`AllCycleMoreComplexBody`	net6.0	212μs	290ns	1.12μs	0.106	0	9.25 KB
#4924	`AllCycleMoreComplexBody`	netcoreapp3.1	225μs	340ns	1.22μs	0.112	0	9.14 KB
#4924	`AllCycleMoreComplexBody`	net472	242μs	805ns	3.42μs	1.43	0	9.32 KB
#4924	`ObjectExtractorSimpleBody`	net6.0	130ns	0.0823ns	0.308ns	0.00393	0	280 B
#4924	`ObjectExtractorSimpleBody`	netcoreapp3.1	232ns	0.0948ns	0.355ns	0.00376	0	272 B
#4924	`ObjectExtractorSimpleBody`	net472	153ns	0.116ns	0.45ns	0.0446	0	281 B
#4924	`ObjectExtractorMoreComplexBody`	net6.0	2.76μs	1.72ns	6.42ns	0.0538	0	3.78 KB
#4924	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.75μs	1.41ns	5.26ns	0.0504	0	3.69 KB
#4924	`ObjectExtractorMoreComplexBody`	net472	3.55μs	2.31ns	8.95ns	0.602	0.00531	3.8 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	52.4μs	293ns	2.01μs	0.219	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	67.3μs	369ns	2.18μs	0.198	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	net472	96.7μs	539ns	3.28μs	2.53	0.0938	16.14 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	117μs	510ns	1.98μs	0.287	0	22.41 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	135μs	551ns	1.91μs	0.275	0	22.36 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	172μs	72.1ns	279ns	3.56	0.166	22.7 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	103μs	386ns	1.5μs	0.45	0	32.76 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	133μs	693ns	3.25μs	0.397	0	33.33 KB
master	`RunWaf(args=NestedMap (100))`	net472	191μs	919ns	3.79μs	5.29	0.365	33.67 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	175μs	60.8ns	236ns	0.524	0	39.1 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	206μs	1μs	4.25μs	0.506	0	39.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	262μs	150ns	580ns	6.39	0.522	40.23 KB
master	`RunWaf(args=NestedMap (20))`	net6.0	102μs	21.8ns	84.6ns	0.423	0	32.18 KB
master	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	131μs	545ns	2.11μs	0.387	0	32.3 KB
master	`RunWaf(args=NestedMap (20))`	net472	190μs	62.1ns	240ns	5.1	0.371	32.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	178μs	84.7ns	328ns	0.522	0	38.53 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	209μs	1.1μs	5.61μs	0.511	0	38.6 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	268μs	166ns	644ns	6.15	0.523	39.2 KB
#4924	`RunWaf(args=NestedMap (10))`	net6.0	51μs	38.3ns	148ns	0.204	0	16.06 KB
#4924	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	70.3μs	102ns	393ns	0.213	0	16.06 KB
#4924	`RunWaf(args=NestedMap (10))`	net472	92.4μs	39.4ns	152ns	2.54	0.0924	16.14 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	115μs	25.6ns	95.9ns	0.301	0	22.41 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	139μs	468ns	1.75μs	0.28	0	22.36 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	171μs	886ns	4.15μs	3.54	0.164	22.7 KB
#4924	`RunWaf(args=NestedMap (100))`	net6.0	106μs	112ns	432ns	0.419	0	32.76 KB
#4924	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	130μs	643ns	2.87μs	0.446	0	33.33 KB
#4924	`RunWaf(args=NestedMap (100))`	net472	186μs	82.2ns	308ns	5.34	0.368	33.67 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	162μs	51ns	198ns	0.499	0	39.1 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	213μs	170ns	637ns	0.516	0	39.63 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	261μs	94.5ns	366ns	6.35	0.519	40.23 KB
#4924	`RunWaf(args=NestedMap (20))`	net6.0	102μs	47.2ns	183ns	0.441	0	32.18 KB
#4924	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	133μs	691ns	3.45μs	0.393	0	32.3 KB
#4924	`RunWaf(args=NestedMap (20))`	net472	189μs	90.2ns	349ns	5.17	0.363	32.63 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	171μs	490ns	1.9μs	0.513	0	38.53 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	213μs	1.16μs	6.36μs	0.506	0	38.6 KB
#4924	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	258μs	475ns	1.65μs	6.21	0.518	39.2 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	200ns	775ns	0.174	18.24 KB
master	`SendRequest`	netcoreapp3.1	192μs	357ns	1.38μs	0.193	20.41 KB
master	`SendRequest`	net472	0.000402ns	0.000184ns	0.000687ns	0	0 b
#4924	`SendRequest`	net6.0	175μs	333ns	1.29μs	0.174	18.24 KB
#4924	`SendRequest`	netcoreapp3.1	193μs	407ns	1.58μs	0.191	20.4 KB
#4924	`SendRequest`	net472	0.000492ns	0.000225ns	0.000871ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	545μs	1.31μs	5.08μs	0.543	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	628ns	2.43μs	0.329	0	0	41.79 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	3.35μs	13μs	8.17	2.45	0.408	53.26 KB
#4924	`WriteAndFlushEnrichedTraces`	net6.0	556μs	1.68μs	6.52μs	0.551	0	0	41.91 KB
#4924	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	653μs	2.49μs	9.64μs	0.321	0	0	41.87 KB
#4924	`WriteAndFlushEnrichedTraces`	net472	818μs	3.05μs	11.8μs	8.31	2.37	0.396	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.04μs	0.744ns	2.88ns	0.0109	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	0.939ns	3.38ns	0.0105	768 B
master	`ExecuteNonQuery`	net472	1.85μs	1.35ns	4.68ns	0.116	730 B
#4924	`ExecuteNonQuery`	net6.0	1.06μs	1.02ns	3.8ns	0.0108	768 B
#4924	`ExecuteNonQuery`	netcoreapp3.1	1.46μs	1.27ns	4.91ns	0.0102	768 B
#4924	`ExecuteNonQuery`	net472	1.73μs	0.612ns	2.37ns	0.115	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.141	1,124.90	1,283.46

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.12μs	0.897ns	3.35ns	0.0131	936 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.793ns	3.07ns	0.0131	936 B
master	`CallElasticsearch`	net472	2.35μs	1.32ns	5.13ns	0.152	955 B
master	`CallElasticsearchAsync`	net6.0	1.28μs	0.407ns	1.52ns	0.0128	912 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.58μs	0.882ns	3.3ns	0.0133	984 B
master	`CallElasticsearchAsync`	net472	2.61μs	1.18ns	4.55ns	0.16	1.01 KB
#4924	`CallElasticsearch`	net6.0	1.28μs	0.553ns	2.07ns	0.0131	936 B
#4924	`CallElasticsearch`	netcoreapp3.1	1.55μs	0.498ns	1.86ns	0.0124	936 B
#4924	`CallElasticsearch`	net472	2.38μs	0.403ns	1.51ns	0.152	955 B
#4924	`CallElasticsearchAsync`	net6.0	1.24μs	1.54ns	5.75ns	0.0125	912 B
#4924	`CallElasticsearchAsync`	netcoreapp3.1	1.74μs	0.625ns	2.34ns	0.0131	984 B
#4924	`CallElasticsearchAsync`	net472	2.68μs	0.644ns	2.49ns	0.16	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.116	1,172.83	1,308.78

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	1.17μs	0.708ns	2.74ns	0.013	0	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	0.602ns	2.25ns	0.0123	0	912 B
master	`ExecuteAsync`	net472	1.85μs	1.01ns	3.79ns	0.139	0	875 B
#4924	`ExecuteAsync`	net6.0	1.31μs	0.884ns	3.42ns	0.013	0	912 B
#4924	`ExecuteAsync`	netcoreapp3.1	1.65μs	0.783ns	2.93ns	0.0124	0	912 B
#4924	`ExecuteAsync`	net472	1.81μs	1.48ns	5.73ns	0.139	0.000902	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.05μs	1.75ns	6.55ns	0.0288	2.1 KB
master	`SendAsync`	netcoreapp3.1	5.01μs	1.74ns	6.73ns	0.0352	2.63 KB
master	`SendAsync`	net472	7.81μs	1.93ns	7.22ns	0.524	3.31 KB
#4924	`SendAsync`	net6.0	4.06μs	1.56ns	6.05ns	0.0282	2.1 KB
#4924	`SendAsync`	netcoreapp3.1	5.05μs	1.09ns	4.22ns	0.0354	2.63 KB
#4924	`SendAsync`	net472	7.67μs	1.26ns	4.35ns	0.525	3.31 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #4924

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑netcoreapp3.1	1.171	62,400.00	53,300.00	bimodal

More allocations ⚠️ in #4924

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark(parameters: System.Collections.Generic.List`1[System.String])‑net472	59.7 KB	60.13 KB	432 B	0.72%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	net6.0	58.5μs	748ns	7.44μs	43.44 KB
master	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	netcoreapp3.1	61.9μs	720ns	7.02μs	42.64 KB
master	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	net472	37.6μs	110ns	411ns	59.7 KB
master	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	net6.0	64.9μs	324ns	1.38μs	43.29 KB
master	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	netcoreapp3.1	106μs	3.87μs	38.5μs	42.64 KB
master	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	net472	64.5μs	296ns	1.18μs	57.34 KB
#4924	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	net6.0	57.7μs	813ns	7.93μs	43.44 KB
#4924	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	netcoreapp3.1	53.1μs	236ns	850ns	42.64 KB
#4924	`StringConcatBenchmark(parameters=Syste(...)ring] [48])`	net472	37.9μs	68.6ns	257ns	60.13 KB
#4924	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	net6.0	93.7μs	2.73μs	27.3μs	43.29 KB
#4924	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	netcoreapp3.1	97.4μs	3.51μs	34.7μs	42.64 KB
#4924	`StringConcatAspectBenchmark(parameters=Syste(...)ring] [48])`	net472	63.6μs	336ns	1.61μs	57.34 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.120	1,493.65	1,672.84

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.49μs	1.02ns	3.96ns	0.0218	1.57 KB
master	`EnrichedLog`	netcoreapp3.1	2.19μs	1.07ns	4.01ns	0.0219	1.57 KB
master	`EnrichedLog`	net472	2.47μs	2.41ns	9.32ns	0.238	1.5 KB
#4924	`EnrichedLog`	net6.0	1.67μs	1.09ns	4.09ns	0.0217	1.57 KB
#4924	`EnrichedLog`	netcoreapp3.1	2.23μs	0.856ns	3.2ns	0.0213	1.57 KB
#4924	`EnrichedLog`	net472	2.62μs	0.979ns	3.66ns	0.238	1.5 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	41.1ns	154ns	0.0563	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	119μs	347ns	1.3μs	0	0	4.21 KB
master	`EnrichedLog`	net472	148μs	220ns	853ns	0.661	0.22	4.39 KB
#4924	`EnrichedLog`	net6.0	112μs	92.7ns	359ns	0.0563	0	4.21 KB
#4924	`EnrichedLog`	netcoreapp3.1	118μs	185ns	669ns	0.0595	0	4.21 KB
#4924	`EnrichedLog`	net472	149μs	222ns	859ns	0.664	0.221	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	0.95ns	3.68ns	0.0296	2.13 KB
master	`EnrichedLog`	netcoreapp3.1	4.14μs	1.47ns	5.7ns	0.029	2.13 KB
master	`EnrichedLog`	net472	4.93μs	4.73ns	18.3ns	0.309	1.95 KB
#4924	`EnrichedLog`	net6.0	3.04μs	1.26ns	4.89ns	0.0289	2.13 KB
#4924	`EnrichedLog`	netcoreapp3.1	4.34μs	1.9ns	7.11ns	0.0283	2.13 KB
#4924	`EnrichedLog`	net472	4.87μs	2.35ns	9.11ns	0.308	1.95 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.27μs	0.742ns	2.77ns	0.0152	1.1 KB
master	`SendReceive`	netcoreapp3.1	1.68μs	1.2ns	4.64ns	0.015	1.1 KB
master	`SendReceive`	net472	2.16μs	2.62ns	10.1ns	0.177	1.12 KB
#4924	`SendReceive`	net6.0	1.38μs	0.871ns	3.37ns	0.0152	1.1 KB
#4924	`SendReceive`	netcoreapp3.1	1.75μs	0.759ns	2.84ns	0.0148	1.1 KB
#4924	`SendReceive`	net472	2.12μs	2.83ns	10.6ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.61μs	1.49ns	5.78ns	0.0208	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.9μs	2.4ns	9.3ns	0.0215	1.58 KB
master	`EnrichedLog`	net472	4.48μs	1.94ns	7.51ns	0.312	1.97 KB
#4924	`EnrichedLog`	net6.0	2.73μs	1.67ns	6.23ns	0.0205	1.53 KB
#4924	`EnrichedLog`	netcoreapp3.1	3.94μs	1.19ns	4.47ns	0.0197	1.58 KB
#4924	`EnrichedLog`	net472	4.38μs	1.05ns	3.94ns	0.311	1.97 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.149	517.25	594.49
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472	1.149	920.03	1,057.29

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	514ns	0.095ns	0.342ns	0.00753	536 B
master	`StartFinishSpan`	netcoreapp3.1	686ns	0.179ns	0.644ns	0.00703	536 B
master	`StartFinishSpan`	net472	710ns	0.225ns	0.871ns	0.0852	538 B
master	`StartFinishScope`	net6.0	517ns	0.127ns	0.49ns	0.00905	656 B
master	`StartFinishScope`	netcoreapp3.1	863ns	0.575ns	2.23ns	0.00896	656 B
master	`StartFinishScope`	net472	920ns	0.366ns	1.42ns	0.0978	618 B
#4924	`StartFinishSpan`	net6.0	530ns	0.131ns	0.473ns	0.00742	536 B
#4924	`StartFinishSpan`	netcoreapp3.1	707ns	0.225ns	0.811ns	0.00705	536 B
#4924	`StartFinishSpan`	net472	722ns	0.313ns	1.21ns	0.0852	538 B
#4924	`StartFinishScope`	net6.0	594ns	0.64ns	2.48ns	0.00928	656 B
#4924	`StartFinishScope`	netcoreapp3.1	789ns	0.796ns	3.08ns	0.00857	656 B
#4924	`StartFinishScope`	net472	1.06μs	0.329ns	1.27ns	0.0977	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4924

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.149	618.84	710.91

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	619ns	0.199ns	0.769ns	0.00906	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	991ns	0.178ns	0.667ns	0.00905	656 B
master	`RunOnMethodBegin`	net472	1.02μs	0.581ns	2.25ns	0.0982	618 B
#4924	`RunOnMethodBegin`	net6.0	711ns	0.22ns	0.854ns	0.00924	656 B
#4924	`RunOnMethodBegin`	netcoreapp3.1	918ns	0.296ns	1.11ns	0.00887	656 B
#4924	`RunOnMethodBegin`	net472	1.13μs	0.274ns	1.03ns	0.0979	618 B

andrewlock · 2023-11-26T18:31:55Z

...est/Datadog.Trace.ClrProfiler.IntegrationTests/VersionConflict/AspNetVersionConflictTests.cs

@@ -35,7 +35,7 @@ public AspNetVersionConflictTests(IisFixture iisFixture, ITestOutputHelper outpu
            _iisFixture.TryStartIis(this, IisAppType.AspNetClassic);
        }

-        [SkippableFact]
+        [SkippableFact(Skip = "FIXME: THIS IS CURRENTLY BROKEN IN THE 3.0 version bump")]


I'm not sure why this gets broken by the version bump, but I suspect it's related to older vs. newer versions. Will investigate that later

gleocadie

2 questions
otherwise LGTM

gleocadie · 2023-11-27T08:50:49Z

tracer/samples/ConsoleApp/Alpine3.10.dockerfile

@@ -16,7 +16,7 @@ COPY --from=build /app/out .

 # Set up Datadog APM
 RUN apk --no-cache update && apk add curl
-ARG TRACER_VERSION=2.42.0
+ARG TRACER_VERSION=2.43.0


Oh there is something I'm missing:
the previous value was 2.42 instead of 2.43. And now we go for 2.43 instead of 3.0.0 in all dockerfiles.
why shouldn't it be 3.0.0 ?

Basically, this is just what the automation did 😆 but I agree, I should revert all 2.42 -> 2.43 changes. Apart from anything else, it'll make it easier to rebase later!

tracer/samples/AutomaticTraceIdInjection/Log4NetExample/Log4NetExample.csproj

* Temporarily Skip version conflict tests * [Version Bump] 2.43.0 * Revert samples that shouldn't have been bumped * Fix dd_dotnet version --------- Co-authored-by: Andrew Lock <andrew.lock@datadoghq.com> Co-authored-by: andrewlock <andrewlock@users.noreply.github.com>

github-actions bot requested review from a team as code owners November 24, 2023 15:35

andrewlock changed the title ~~[Version Bump] 2.43.0~~ [Version Bump] 3.0.0-prerelease Nov 24, 2023

andrewlock approved these changes Nov 24, 2023

View reviewed changes

andrewlock reviewed Nov 26, 2023

View reviewed changes

gleocadie approved these changes Nov 27, 2023

View reviewed changes

andrewlock force-pushed the version-bump-2.43.0 branch from 5a35c68 to 38bcefe Compare November 27, 2023 12:39

andrewlock changed the base branch from v3-main to master November 27, 2023 12:41

andrewlock changed the base branch from master to v3-main November 27, 2023 12:41

andrewlock force-pushed the version-bump-2.43.0 branch from da1934f to 2957433 Compare November 27, 2023 12:44

andrewlock and others added 4 commits November 27, 2023 12:47

Temporarily Skip version conflict tests

e3d0316

[Version Bump] 2.43.0

c8ee235

Revert samples that shouldn't have been bumped

4cbce39

Fix dd_dotnet version

74f65c0

andrewlock force-pushed the version-bump-2.43.0 branch from 2957433 to 74f65c0 Compare November 27, 2023 12:48

andrewlock merged commit b85f02f into v3-main Nov 28, 2023
60 of 61 checks passed

andrewlock deleted the version-bump-2.43.0 branch November 28, 2023 13:14

andrewlock added this to the vNext-v3 milestone Apr 22, 2024

andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jul 29, 2024

[Version Bump] 3.0.0-prerelease #4924

[Version Bump] 3.0.0-prerelease #4924

Conversation

github-actions bot commented Nov 24, 2023

andrewlock left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 24, 2023 • edited Loading

Datadog Report

andrewlock commented Nov 24, 2023 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Nov 24, 2023 • edited Loading

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Slower ⚠️ in #4924

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4924

Raw results

Slower ⚠️ in #4924

Raw results

Raw results

Faster 🎉 in #4924

More allocations ⚠️ in #4924

Raw results

Slower ⚠️ in #4924

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4924

Raw results

Slower ⚠️ in #4924

Raw results

andrewlock Nov 26, 2023

Choose a reason for hiding this comment

gleocadie left a comment

Choose a reason for hiding this comment

gleocadie Nov 27, 2023

Choose a reason for hiding this comment

andrewlock Nov 27, 2023

Choose a reason for hiding this comment

gleocadie Nov 27, 2023

Choose a reason for hiding this comment

datadog-ddstaging bot commented Nov 24, 2023 •

edited

Loading

andrewlock commented Nov 24, 2023 •

edited

Loading

andrewlock commented Nov 24, 2023 •

edited

Loading