Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send some error logs to telemetry #4934

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Don't send some error logs to telemetry #4934

merged 6 commits into from
Nov 30, 2023

Commits on Nov 29, 2023

  1. Downgrade "Error occured sending data to the agent" 

    It's an error, but one we can't do anything about. Warnings are written to the logs in the same way, so this shouldn't be a big deal hopefully?

Alternatively, we could apply a filter to the log telemetry logs
    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    caf4a7a View commit details
    Browse the repository at this point in the history

  2. Downgrade "The process does not have sufficient permissions to read p… 

    …erformance counters" to warning

It's an error, but one we can't do anything about. Warnings are written to the logs in the same way, so this shouldn't be a big deal hopefully?

Alternatively, we could apply a filter to the log telemetry logs
    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    16e5b13 View commit details
    Browse the repository at this point in the history

  3. Revert "Downgrade "Error occured sending data to the agent"" 

    This reverts commit bef6b34.
    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    591808c View commit details
    Browse the repository at this point in the history

  4. Revert "Downgrade "The process does not have sufficient permissions t… 

    …o read performance counters" to warning"

This reverts commit 677fa4e.
    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9d1ff96 View commit details
    Browse the repository at this point in the history

  5. Exclude specific logs that we can't do anything about

    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e57b1a6 View commit details
    Browse the repository at this point in the history

  6. Add unit test for not sending the message

    @andrewlock
    andrewlock committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    4a263b0 View commit details
    Browse the repository at this point in the history