Clean up MockTraceAgent, add event-based API #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaspimentel
added
the
status:work-in-progress
lucaspimentel
changed the base branch from
master
to
lpimentel/dictionary-extensions
lucaspimentel
added
the
status:do-not-merge
lucaspimentel
force-pushed
the
lpimentel/dictionary-extensions
branch
from
4453b14
to
196015e
Compare
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
2 times, most recently
from
8d41198
to
43dc66d
Compare
lucaspimentel
force-pushed
the
lpimentel/dictionary-extensions
branch
from
c696677
to
67774d7
Compare
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
from
43dc66d
to
a52ea35
Compare
lucaspimentel
added
area:tests
lucaspimentel
changed the title
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
from
a52ea35
to
516fd06
Compare
lucaspimentel
changed the base branch from
lpimentel/dictionary-extensions
to
master
lucaspimentel
added
the
status:work-in-progress
lucaspimentel
changed the title
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
from
516fd06
to
5ed8ac2
Compare
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
2 times, most recently
from
c2ace3e
to
543bf9b
Compare
lucaspimentel
force-pushed
the
lpimentel/refactor-mock-trace-agent
branch
from
543bf9b
to
d7d7b83
Compare
lucaspimentel
removed
status:do-not-merge
3 tasks
zacharycmontoya
approved these changes
Nov 18, 2019
colin-higgins
approved these changes
Nov 18, 2019
lucaspimentel
changed the title
MikeGoldsmith
pushed a commit
to lightstep/ls-trace-dotnet
that referenced
this pull request
Mar 20, 2020
- refactor MockTracerAgent.ToSpans() to stop using "dynamic" and be more static - add missing properties to the mock Span (ParentId, Error, and the Metrics dictionary) - add MockTracerAgent.RequestDeserialized event as a "push" alternative to WaitForSpans()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
MockTracerAgent.ToSpans()to be lessmagicaldynamicand be more staticSpan(ParentId,Error, and theMetricsdictionary)MockTracerAgent.RequestDeserializedevent as a "push" alternative toWaitForSpans()