Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require additional Windows SDK for Nuke desktop notification #5192

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Don't require additional Windows SDK for Nuke desktop notification #5192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab9368
Stop requiring the specific Windows SDK when building on Windows
andrewlock Feb 14, 2024
fe90f60
Don't use an old Windows SDK
andrewlock Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracer/build/_build/BuildFinishedNotificationAttribute.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

#if IS_WINDOWS
#if NUKE_NOTIFY
#nullable enable

using System;
Expand Down
2 changes: 1 addition & 1 deletion tracer/build/_build/BuildFinishedNotificationAttribute.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

public partial class BuildFinishedNotificationAttribute : BuildExtensionAttributeBase, IOnBuildFinished
{
#if !IS_WINDOWS
#if !NUKE_NOTIFY
public void OnBuildFinished(NukeBuild build)
{}
#endif
Expand Down
10 changes: 5 additions & 5 deletions tracer/build/_build/_build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net7.0</TargetFramework>
<TargetFramework Condition="$(OS.StartsWith('Windows'))">$(TargetFramework)-windows10.0.17763</TargetFramework>
<DefineConstants Condition="$(OS.StartsWith('Windows'))">IS_WINDOWS</DefineConstants>
<TargetFramework Condition="$(OS.StartsWith('Windows')) AND '$(NUKE_NOTIFY)' != ''">$(TargetFramework)-windows10.0.19041</TargetFramework>
<DefineConstants Condition="$(OS.StartsWith('Windows')) AND '$(NUKE_NOTIFY)' != ''">$(DefineConstants);NUKE_NOTIFY</DefineConstants>
<RollForward>LatestMajor</RollForward>
<RootNamespace></RootNamespace>
<!-- NU* are workaround for Rider bug: https://youtrack.jetbrains.com/issue/RIDER-103207/Cannot-suppress-vulnerable-package-errors -->
Expand Down Expand Up @@ -40,9 +40,9 @@
<PackageReference Include="ByteSize" Version="2.1.0" />
</ItemGroup>

<ItemGroup>
<!-- on it's own, since windows only and just used for notifications -->
<PackageReference Include="Microsoft.Toolkit.Uwp.Notifications" Version="7.1.3" Condition="$(OS.StartsWith('Windows'))" />
<!-- On it's own, since windows only and just used for notifications -->
<ItemGroup Condition="$(OS.StartsWith('Windows')) AND '$(NUKE_NOTIFY)' != ''">
<PackageReference Include="Microsoft.Toolkit.Uwp.Notifications" Version="7.1.3" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading