[v3] Change manual instrumentation approach to not use reverse duck-typing #5214
Commits on Mar 4, 2024
-
-
-
-
-
Revert the changes to benchmark stat types
Seeing as we're not reverse duck-typing any more, we don't need to do this
-
Update manual Ci Visibility to not rely on reverse duck-typing
This is made rather irritating by the fact we _can't_ ducktype Test as an ITest. That, coupled with the APIs that connect module + suite + test together means we need to duplicate the interfaces in their entirety. It seems to work though 🎉
-
-
Use instrumentation of DuckType.DuckCast<T> in Datadog.Trace.Manual.c…
…sproj Means we can avoid having to include the whole DuckTyping library inside Datadog.Trace.Manual The downside is that it's hard to test in unit tests. as everything requires auto instrumentation
-
Instead of having wrapper ManualScope implementations etc, we can just use duck typing instead directly. This reduces one level of indirection and reduces the allocations
-
Redesign approach with CI Visibility
- Use the standard duck typing approach instead of reverse duck typing - Remove the ManualTest etc - Move methods that we _can't_ duck type to be extension methods that we instrument
-
-
Apply suggestions from code review
Co-authored-by: Kevin Gosse <kevin.gosse@datadoghq.com>
-
- Fix previous PR feedback suggestions ;) - Add [Instrumented] to Tracer.ctor - Fix merge conflict in IntegrationIdExtensions - Add missing telemetry integration - Move TracerSettingsPopulateDictionaryIntegration into correct folder, and rename to PopulateDictionaryIntegration - Add a unit test for SetTag
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.