-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use vendored unsafe class instead of emitting IL #5215
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 306733 Passed, 1571 Skipped, 41m 6.7s Wall Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (74ms) : 64, 85
. : milestone, 74,
master - mean (75ms) : 65, 86
. : milestone, 75,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (982ms) : 962, 1001
. : milestone, 982,
master - mean (989ms) : 969, 1009
. : milestone, 989,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (111ms) : 107, 114
. : milestone, 111,
master - mean (111ms) : 107, 115
. : milestone, 111,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (718ms) : 696, 741
. : milestone, 718,
master - mean (710ms) : 691, 728
. : milestone, 710,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (95ms) : 91, 99
. : milestone, 95,
master - mean (93ms) : 90, 96
. : milestone, 93,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (668ms) : 642, 695
. : milestone, 668,
master - mean (671ms) : 646, 696
. : milestone, 671,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (188ms) : 184, 191
. : milestone, 188,
master - mean (188ms) : 184, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (1,062ms) : 1038, 1086
. : milestone, 1062,
master - mean (1,057ms) : 1033, 1082
. : milestone, 1057,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (270ms) : 265, 275
. : milestone, 270,
master - mean (271ms) : 266, 275
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (1,057ms) : 1033, 1081
. : milestone, 1057,
master - mean (1,055ms) : 1024, 1085
. : milestone, 1055,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5215) - mean (259ms) : 255, 263
. : milestone, 259,
master - mean (259ms) : 253, 264
. : milestone, 259,
section CallTarget+Inlining+NGEN
This PR (5215) - mean (999ms) : 976, 1022
. : milestone, 999,
master - mean (994ms) : 967, 1022
. : milestone, 994,
|
Summary of changes
This PR remove emitting IL and replace it with the use of the vendored unsafe class.