Fix scenario where dogstatsd tries to send to the wrong hostname #5222

andrewlock · 2024-02-21T13:00:28Z

Summary of changes

Fixes a scenario where we try to send runtime metrics to the wrong host
nit: switch to fluent assertions in ExporterSettingsTests

Reason for change

We recently had an escalation where the customer had set three properties (via single-step instrumentation)

DD_TRACE_AGENT_URL=unix:///var/run/datadog/apm.socket
DD_AGENT_HOST=1.2.3.4
DD_DOGSTATSD_URL=unix:///var/run/datadog/dsd.socket (not currently supported)

The resulting configuration was:

Traces: UDS: /var/run/datadog/apm.socket ✔️
Metrics: UDP: 127.0.01:8125 ❌ Should be UDP: 1.2.3.4:8125

The big problem in the the above is that the metrics is sending to localhost, which is incorrect.

Ideally we would send to the UDS socket actually, but we'll add support for DD_DOGSTATSD_URL in a subsequent PR

Implementation details

The problem was that we had this code to determine the host to use for metrics:

var traceHostname = settings.ExporterInternal.AgentUriInternal.DnsSafeHost;
config.StatsdServerName = string.IsNullOrEmpty(traceHostname) ? "127.0.0.1" : traceHostname;

However, when we're using UDS traces, AgentUriInternal is unix:///var/run/datadog/apm.socket and AgentUriInternal.DnsSafeHost returns "" so we fallback to "127.0.0.1". In the current scenario, we don't actually store DD_AGENT_HOST anywhere.

The implementation changes that to explicitly record the metrics host in ExporterSettings when it's being configured. That means we can use the value of DD_AGENT_HOST if it's set and fixes the bug.

Test coverage

Updated ExporterSettingsTests to assert that we are setting the hostname correctly in ExporterSettings I haven't tested that TracerManagerFactory uses it correctly when creating the dogstatsd client, as that's a bit of a PITA and I think the change is simple enough to not worry about (famous last words?)

Other details

I'll do a PR to add support for DD_DOGSTATSD_URL stacked on this

kevingosse · 2024-02-21T13:06:21Z

tracer/src/Datadog.Trace/Configuration/ExporterSettings.cs

+        /// <summary>
+        /// Gets or sets the agent host to use when <see cref="MetricsTransport"/> is <see cref="TransportType.UDP"/>
+        /// </summary>
+        [IgnoreForSnapshot] // We don't record this in telemetry currently, but if we do, we'll record it when we set its


Its what? the suspense is killing me

Dunno, whatever it is that we'll do with MetricsTransport too

FWIW, fixed the comment typo in both in the stacked PR

Add support for DD_DOGSTATSD_URL #5224

datadog-ddstaging · 2024-02-21T13:15:29Z

Datadog Report

Branch report: andrew/exporter-settings
Commit report: 680621a
Test service: dd-trace-dotnet

✅ 0 Failed, 307234 Passed, 1578 Skipped, 40m 36.6s Wall Time

andrewlock · 2024-02-21T13:30:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (76ms)  : 70, 83
     .   : milestone, 76,
    master - mean (74ms)  : 65, 82
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (987ms)  : 969, 1005
     .   : milestone, 987,
    master - mean (979ms)  : 952, 1006
     .   : milestone, 979,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (113ms)  : 109, 116
     .   : milestone, 113,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (722ms)  : 697, 747
     .   : milestone, 722,
    master - mean (712ms)  : 691, 732
     .   : milestone, 712,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (96ms)  : 92, 99
     .   : milestone, 96,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (675ms)  : 654, 696
     .   : milestone, 675,
    master - mean (664ms)  : 644, 684
     .   : milestone, 664,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (187ms)  : 184, 190
     .   : milestone, 187,
    master - mean (187ms)  : 183, 191
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (1,061ms)  : 1027, 1095
     .   : milestone, 1061,
    master - mean (1,055ms)  : 1028, 1082
     .   : milestone, 1055,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (270ms)  : 265, 276
     .   : milestone, 270,
    master - mean (269ms)  : 264, 275
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (1,055ms)  : 1037, 1074
     .   : milestone, 1055,
    master - mean (1,053ms)  : 1028, 1077
     .   : milestone, 1053,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5222) - mean (258ms)  : 252, 264
     .   : milestone, 258,
    master - mean (258ms)  : 254, 262
     .   : milestone, 258,

    section CallTarget+Inlining+NGEN
    This PR (5222) - mean (990ms)  : 961, 1020
     .   : milestone, 990,
    master - mean (988ms)  : 962, 1014
     .   : milestone, 988,

andrewlock · 2024-02-21T16:50:01Z

Benchmarks Report 🐌

Benchmarks for #5222 compared to master:

2 benchmarks are slower, with geometric mean 1.152
2 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.75μs	48.7ns	312ns	0.0211	0.00845	0	7.49 KB
master	`StartStopWithChild`	netcoreapp3.1	10.5μs	38.7ns	145ns	0.0248	0.00992	0	7.58 KB
master	`StartStopWithChild`	net472	16.9μs	61.1ns	237ns	1.33	0.342	0.125	7.96 KB
#5222	`StartStopWithChild`	net6.0	8.61μs	46.9ns	269ns	0.0179	0.00894	0	7.49 KB
#5222	`StartStopWithChild`	netcoreapp3.1	10.7μs	53.2ns	232ns	0.0315	0.0157	0	7.59 KB
#5222	`StartStopWithChild`	net472	16.8μs	45.6ns	171ns	1.34	0.351	0.117	7.96 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	466μs	656ns	2.54μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	605μs	242ns	937ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	800μs	421ns	1.57μs	0.398	3.3 KB
#5222	`WriteAndFlushEnrichedTraces`	net6.0	454μs	498ns	1.79μs	0	2.7 KB
#5222	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	623μs	424ns	1.59μs	0	2.7 KB
#5222	`WriteAndFlushEnrichedTraces`	net472	806μs	385ns	1.49μs	0.398	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	40.8μs	14.1ns	54.7ns	0.0203	0	2.36 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	43.9μs	53.9ns	209ns	0.0218	0	2.34 KB
master	`AllCycleSimpleBody`	net472	46.8μs	22.7ns	88ns	0.373	0	2.41 KB
master	`AllCycleMoreComplexBody`	net6.0	213μs	325ns	1.17μs	0.106	0	9.84 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	225μs	87ns	326ns	0.112	0	9.73 KB
master	`AllCycleMoreComplexBody`	net472	241μs	88.7ns	343ns	1.57	0	9.91 KB
master	`ObjectExtractorSimpleBody`	net6.0	144ns	0.0908ns	0.328ns	0.00395	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	196ns	0.124ns	0.464ns	0.00375	0	272 B
master	`ObjectExtractorSimpleBody`	net472	171ns	0.0749ns	0.29ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.99μs	1.71ns	6.39ns	0.0529	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.97μs	1.83ns	6.83ns	0.0496	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.92μs	2.44ns	9.47ns	0.601	0.00586	3.8 KB
#5222	`AllCycleSimpleBody`	net6.0	41.4μs	17.2ns	64.4ns	0.0209	0	2.36 KB
#5222	`AllCycleSimpleBody`	netcoreapp3.1	44.2μs	51.7ns	186ns	0.0222	0	2.34 KB
#5222	`AllCycleSimpleBody`	net472	47.7μs	25.8ns	99.8ns	0.381	0	2.41 KB
#5222	`AllCycleMoreComplexBody`	net6.0	214μs	61.5ns	230ns	0.106	0	9.84 KB
#5222	`AllCycleMoreComplexBody`	netcoreapp3.1	225μs	209ns	811ns	0.112	0	9.73 KB
#5222	`AllCycleMoreComplexBody`	net472	241μs	66.2ns	256ns	1.56	0	9.91 KB
#5222	`ObjectExtractorSimpleBody`	net6.0	141ns	0.126ns	0.488ns	0.00393	0	280 B
#5222	`ObjectExtractorSimpleBody`	netcoreapp3.1	206ns	0.148ns	0.573ns	0.0037	0	272 B
#5222	`ObjectExtractorSimpleBody`	net472	172ns	0.0577ns	0.216ns	0.0446	0	281 B
#5222	`ObjectExtractorMoreComplexBody`	net6.0	3.01μs	2.07ns	7.46ns	0.0527	0	3.78 KB
#5222	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.98μs	2.99ns	11.6ns	0.0499	0	3.69 KB
#5222	`ObjectExtractorMoreComplexBody`	net472	3.81μs	1.43ns	5.37ns	0.603	0.00576	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EncodeArgs`	net6.0	52μs	85.6ns	332ns	0.416	0	30.94 KB
master	`EncodeArgs`	netcoreapp3.1	69.4μs	77.4ns	300ns	0.417	0	31.47 KB
master	`EncodeArgs`	net472	84.1μs	38.8ns	145ns	5.09	0.0841	32.27 KB
master	`EncodeLegacyArgs`	net6.0	125μs	211ns	730ns	0.438	0	33.89 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	153μs	202ns	755ns	0.455	0	34.09 KB
master	`EncodeLegacyArgs`	net472	211μs	130ns	470ns	5.46	0.42	34.99 KB
#5222	`EncodeArgs`	net6.0	51.3μs	70.3ns	272ns	0.433	0	30.94 KB
#5222	`EncodeArgs`	netcoreapp3.1	69.2μs	81.5ns	316ns	0.416	0	31.47 KB
#5222	`EncodeArgs`	net472	84.7μs	55.6ns	208ns	5.09	0.0848	32.27 KB
#5222	`EncodeLegacyArgs`	net6.0	128μs	232ns	836ns	0.478	0	33.89 KB
#5222	`EncodeLegacyArgs`	netcoreapp3.1	154μs	233ns	872ns	0.471	0	34.09 KB
#5222	`EncodeLegacyArgs`	net472	212μs	83.2ns	300ns	5.51	0.433	34.99 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunWafRealisticBenchmark`	net6.0	190μs	200ns	774ns	0.0943	6.51 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	203μs	325ns	1.21μs	0	6.49 KB
master	`RunWafRealisticBenchmark`	net472	222μs	84ns	314ns	0.999	6.59 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	127μs	50.2ns	194ns	0.0626	4.15 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	134μs	184ns	713ns	0	4.14 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	146μs	38.8ns	145ns	0.659	4.19 KB
#5222	`RunWafRealisticBenchmark`	net6.0	191μs	189ns	733ns	0.0956	6.51 KB
#5222	`RunWafRealisticBenchmark`	netcoreapp3.1	203μs	206ns	800ns	0	6.49 KB
#5222	`RunWafRealisticBenchmark`	net472	223μs	74.6ns	289ns	1	6.59 KB
#5222	`RunWafRealisticBenchmarkWithAttack`	net6.0	127μs	99.5ns	385ns	0.0623	4.15 KB
#5222	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	135μs	180ns	697ns	0	4.14 KB
#5222	`RunWafRealisticBenchmarkWithAttack`	net472	146μs	76.8ns	297ns	0.656	4.19 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	170μs	135ns	525ns	0.254	18.26 KB
master	`SendRequest`	netcoreapp3.1	189μs	316ns	1.23μs	0.191	20.42 KB
master	`SendRequest`	net472	0.000679ns	0.000335ns	0.0013ns	0	0 b
#5222	`SendRequest`	net6.0	173μs	135ns	524ns	0.169	18.26 KB
#5222	`SendRequest`	netcoreapp3.1	188μs	258ns	964ns	0.188	20.42 KB
#5222	`SendRequest`	net472	0.000213ns	0.000118ns	0.000457ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	551μs	1.09μs	4.23μs	0.543	0	0	41.55 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	1.95μs	7.55μs	0.322	0	0	41.76 KB
master	`WriteAndFlushEnrichedTraces`	net472	845μs	4.19μs	17.8μs	8.08	2.55	0.425	53.24 KB
#5222	`WriteAndFlushEnrichedTraces`	net6.0	546μs	220ns	792ns	0.546	0	0	41.51 KB
#5222	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	646μs	1.38μs	5.36μs	0.321	0	0	41.77 KB
#5222	`WriteAndFlushEnrichedTraces`	net472	847μs	3.24μs	12.6μs	8.33	2.5	0.417	53.21 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.09μs	0.689ns	2.67ns	0.0104	776 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.57μs	0.871ns	3.37ns	0.0103	776 B
master	`ExecuteNonQuery`	net472	1.78μs	1.47ns	5.5ns	0.117	738 B
#5222	`ExecuteNonQuery`	net6.0	1.04μs	0.927ns	3.59ns	0.0108	776 B
#5222	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	1.19ns	4.6ns	0.0103	776 B
#5222	`ExecuteNonQuery`	net472	1.74μs	1.02ns	3.69ns	0.117	738 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.17μs	0.65ns	2.43ns	0.0134	944 B
master	`CallElasticsearch`	netcoreapp3.1	1.52μs	0.937ns	3.63ns	0.0129	944 B
master	`CallElasticsearch`	net472	2.41μs	0.879ns	3.4ns	0.152	963 B
master	`CallElasticsearchAsync`	net6.0	1.24μs	0.758ns	2.83ns	0.0125	920 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.56μs	1.4ns	5.25ns	0.0132	992 B
master	`CallElasticsearchAsync`	net472	2.7μs	1.08ns	4.17ns	0.161	1.02 KB
#5222	`CallElasticsearch`	net6.0	1.28μs	0.677ns	2.62ns	0.0129	944 B
#5222	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.975ns	3.65ns	0.0131	944 B
#5222	`CallElasticsearch`	net472	2.48μs	0.731ns	2.74ns	0.152	963 B
#5222	`CallElasticsearchAsync`	net6.0	1.32μs	0.937ns	3.51ns	0.0127	920 B
#5222	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	0.639ns	2.39ns	0.013	992 B
#5222	`CallElasticsearchAsync`	net472	2.62μs	1.07ns	4.02ns	0.162	1.02 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.4μs	1.4ns	5.24ns	0.0125	920 B
master	`ExecuteAsync`	netcoreapp3.1	1.72μs	1.76ns	6.58ns	0.0119	920 B
master	`ExecuteAsync`	net472	1.82μs	0.669ns	2.5ns	0.14	883 B
#5222	`ExecuteAsync`	net6.0	1.31μs	0.625ns	2.42ns	0.0125	920 B
#5222	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.7ns	2.71ns	0.0123	920 B
#5222	`ExecuteAsync`	net472	1.74μs	0.764ns	2.96ns	0.139	883 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.04μs	1.59ns	5.95ns	0.0283	2.1 KB
master	`SendAsync`	netcoreapp3.1	4.86μs	1.78ns	6.65ns	0.0341	2.64 KB
master	`SendAsync`	net472	7.87μs	4.39ns	17ns	0.524	3.31 KB
#5222	`SendAsync`	net6.0	4.13μs	2.31ns	8.63ns	0.0288	2.1 KB
#5222	`SendAsync`	netcoreapp3.1	5.02μs	3.34ns	12.9ns	0.035	2.64 KB
#5222	`SendAsync`	net472	7.86μs	2.57ns	9.97ns	0.526	3.31 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5222

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472	221.18 KB	229.38 KB	8.19 KB	3.70%

Fewer allocations 🎉 in #5222

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	203.4 KB	202.37 KB	-1.03 KB	-0.51%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	60.95 KB	60.53 KB	-424 B	-0.70%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	64.6μs	973ns	9.68μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	52.7μs	238ns	857ns	42.64 KB
master	`StringConcatBenchmark`	net472	37.5μs	69.7ns	261ns	60.95 KB
master	`StringConcatAspectBenchmark`	net6.0	267μs	1.24μs	8.03μs	204.12 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	286μs	1.5μs	7.78μs	203.4 KB
master	`StringConcatAspectBenchmark`	net472	239μs	2.96μs	28.1μs	221.18 KB
#5222	`StringConcatBenchmark`	net6.0	56.8μs	588ns	5.85μs	43.44 KB
#5222	`StringConcatBenchmark`	netcoreapp3.1	58.9μs	804ns	7.83μs	42.64 KB
#5222	`StringConcatBenchmark`	net472	37.3μs	91.9ns	331ns	60.53 KB
#5222	`StringConcatAspectBenchmark`	net6.0	278μs	1.48μs	9.34μs	204.88 KB
#5222	`StringConcatAspectBenchmark`	netcoreapp3.1	283μs	1.15μs	3.98μs	202.37 KB
#5222	`StringConcatAspectBenchmark`	net472	227μs	1.22μs	6.35μs	229.38 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.5μs	0.622ns	2.33ns	0.0225	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	2.18μs	5.22ns	20.2ns	0.0218	1.58 KB
master	`EnrichedLog`	net472	2.59μs	1.6ns	5.98ns	0.239	1.51 KB
#5222	`EnrichedLog`	net6.0	1.5μs	0.882ns	3.42ns	0.0219	1.58 KB
#5222	`EnrichedLog`	netcoreapp3.1	2.32μs	1.48ns	5.74ns	0.0207	1.58 KB
#5222	`EnrichedLog`	net472	2.57μs	8.01ns	31ns	0.24	1.51 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	125ns	485ns	0.0571	0	4.22 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	90.3ns	350ns	0.0579	0	4.22 KB
master	`EnrichedLog`	net472	147μs	101ns	376ns	0.658	0.219	4.4 KB
#5222	`EnrichedLog`	net6.0	113μs	62.7ns	217ns	0.0564	0	4.22 KB
#5222	`EnrichedLog`	netcoreapp3.1	117μs	111ns	428ns	0.0584	0	4.22 KB
#5222	`EnrichedLog`	net472	147μs	65.9ns	247ns	0.661	0.22	4.4 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.91μs	1.89ns	7.33ns	0.0291	2.14 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	2.03ns	7.87ns	0.0273	2.14 KB
master	`EnrichedLog`	net472	4.83μs	1.91ns	7.14ns	0.309	1.95 KB
#5222	`EnrichedLog`	net6.0	2.89μs	1.36ns	5.28ns	0.0304	2.14 KB
#5222	`EnrichedLog`	netcoreapp3.1	4.22μs	1.11ns	3.99ns	0.0295	2.14 KB
#5222	`EnrichedLog`	net472	4.76μs	1.38ns	5.17ns	0.309	1.95 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	2.17ns	8.41ns	0.0154	1.11 KB
master	`SendReceive`	netcoreapp3.1	1.72μs	0.806ns	3.02ns	0.0145	1.11 KB
master	`SendReceive`	net472	2.19μs	2.68ns	10.4ns	0.178	1.12 KB
#5222	`SendReceive`	net6.0	1.42μs	0.706ns	2.64ns	0.0157	1.11 KB
#5222	`SendReceive`	netcoreapp3.1	1.76μs	1.64ns	6.13ns	0.015	1.11 KB
#5222	`SendReceive`	net472	1.99μs	0.716ns	2.77ns	0.178	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.73μs	0.705ns	2.64ns	0.0219	1.54 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	0.787ns	3.05ns	0.0213	1.58 KB
master	`EnrichedLog`	net472	4.32μs	2.39ns	9.26ns	0.313	1.97 KB
#5222	`EnrichedLog`	net6.0	2.69μs	1.05ns	3.94ns	0.0216	1.54 KB
#5222	`EnrichedLog`	netcoreapp3.1	3.91μs	3.75ns	14.5ns	0.0212	1.58 KB
#5222	`EnrichedLog`	net472	4.42μs	3.03ns	11.7ns	0.312	1.97 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5222

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.121	533.29	597.63

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	590ns	0.848ns	3.28ns	0.00749	544 B
master	`StartFinishSpan`	netcoreapp3.1	803ns	1.17ns	4.54ns	0.00725	544 B
master	`StartFinishSpan`	net472	764ns	2.17ns	8.39ns	0.0864	546 B
master	`StartFinishScope`	net6.0	533ns	0.882ns	3.41ns	0.0093	664 B
master	`StartFinishScope`	netcoreapp3.1	827ns	1.5ns	5.82ns	0.00866	664 B
master	`StartFinishScope`	net472	985ns	2.43ns	9.42ns	0.0994	626 B
#5222	`StartFinishSpan`	net6.0	534ns	0.993ns	3.84ns	0.00753	544 B
#5222	`StartFinishSpan`	netcoreapp3.1	744ns	2.03ns	7.85ns	0.00737	544 B
#5222	`StartFinishSpan`	net472	772ns	1.86ns	7.22ns	0.0865	546 B
#5222	`StartFinishScope`	net6.0	598ns	1.01ns	3.92ns	0.00922	664 B
#5222	`StartFinishScope`	netcoreapp3.1	852ns	1.96ns	7.61ns	0.00897	664 B
#5222	`StartFinishScope`	net472	996ns	2.35ns	9.09ns	0.0993	626 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5222

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.183	601.81	712.11

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	602ns	1.45ns	5.62ns	0.00943	664 B
master	`RunOnMethodBegin`	netcoreapp3.1	910ns	1.78ns	6.89ns	0.00909	664 B
master	`RunOnMethodBegin`	net472	1.08μs	3.27ns	12.7ns	0.0994	626 B
#5222	`RunOnMethodBegin`	net6.0	711ns	0.873ns	3.38ns	0.00939	664 B
#5222	`RunOnMethodBegin`	netcoreapp3.1	931ns	2.15ns	8.32ns	0.009	664 B
#5222	`RunOnMethodBegin`	net472	1.04μs	2.04ns	7.91ns	0.0992	626 B

andrewlock · 2024-02-21T21:48:09Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5222) (11.381M)   : 0, 11381193
    master (11.338M)   : 0, 11337631
    benchmarks/2.9.0 (11.425M)   : 0, 11424847

    section Automatic
    This PR (5222) (7.849M)   : 0, 7848740
    master (7.650M)   : 0, 7650211
    benchmarks/2.9.0 (8.301M)   : 0, 8300659

    section Trace stats
    This PR (5222) (8.115M)   : 0, 8114860
    master (7.922M)   : 0, 7922321

    section Manual
    This PR (5222) (9.635M)   : 0, 9634926
    master (9.709M)   : 0, 9709219

    section Manual + Automatic
    This PR (5222) (7.353M)   : 0, 7353409
    master (7.392M)   : 0, 7392190

    section Version Conflict
    This PR (5222) (6.654M)   : 0, 6654264
    master (6.646M)   : 0, 6646482

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5222) (9.419M)   : 0, 9419046
    master (9.487M)   : 0, 9487398
    benchmarks/2.9.0 (9.641M)   : 0, 9641077

    section Automatic
    This PR (5222) (6.460M)   : 0, 6459518
    master (6.605M)   : 0, 6605442

    section Trace stats
    This PR (5222) (6.966M)   : 0, 6966224
    master (6.935M)   : 0, 6935276

    section Manual
    This PR (5222) (7.967M)   : 0, 7966793
    master (8.153M)   : 0, 8152949

    section Manual + Automatic
    This PR (5222) (6.191M)   : 0, 6191334
    master (6.217M)   : 0, 6217066

    section Version Conflict
    This PR (5222) (5.713M)   : 0, 5713061
    master (5.420M)   : 0, 5419699

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5222) (10.056M)   : 0, 10055759
    master (9.981M)   : 0, 9981056
    benchmarks/2.9.0 (9.812M)   : 0, 9811640

    section Automatic
    This PR (5222) (7.304M)   : 0, 7304242
    master (7.169M)   : 0, 7169119
    benchmarks/2.9.0 (7.410M)   : 0, 7410467

    section Trace stats
    This PR (5222) (7.510M)   : 0, 7510324
    master (7.448M)   : 0, 7447972

    section Manual
    This PR (5222) (9.111M)   : 0, 9110912
    master (8.860M)   : 0, 8859810

    section Manual + Automatic
    This PR (5222) (7.021M)   : 0, 7020799
    master (6.977M)   : 0, 6977328

    section Version Conflict
    This PR (5222) (6.255M)   : 0, 6254825
    master (6.377M)   : 0, 6377341

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.452M)   : 0, 7452193
    benchmarks/2.9.0 (7.805M)   : 0, 7805433

    section No attack
    master (1.888M)   : 0, 1887644
    benchmarks/2.9.0 (3.184M)   : 0, 3183762

    section Attack
    master (1.505M)   : 0, 1505387
    benchmarks/2.9.0 (2.497M)   : 0, 2497002

    section Blocking
    master (3.200M)   : 0, 3199507

    section IAST default
    master (6.679M)   : 0, 6678778

    section IAST full
    master (5.786M)   : 0, 5786316

    section Base vuln
    master (0.982M)   : 0, 981556

    section IAST vuln
    master (0.917M)   : 0, 917350

link04

LGTM, would love to go over it in a meeting!

andrewlock added type:bug area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:runtime-metrics labels Feb 21, 2024

andrewlock requested a review from a team as a code owner February 21, 2024 13:00

kevingosse approved these changes Feb 21, 2024

View reviewed changes

andrewlock force-pushed the andrew/exporter-settings branch from 67f4b1f to 8eecfa6 Compare February 21, 2024 15:44

andrewlock requested a review from a team as a code owner February 21, 2024 15:44

andrewlock force-pushed the andrew/exporter-settings branch from 8eecfa6 to 98e405c Compare February 21, 2024 17:26

andrewlock mentioned this pull request Feb 21, 2024

Add support for DD_DOGSTATSD_URL #5224

Merged

3 tasks

link04 approved these changes Feb 21, 2024

View reviewed changes

andrewlock added 2 commits February 26, 2024 09:27

minor: switch to fluent assertions

408cc75

Fix scenario where dogstatsd tries to send to the wrong hostname

680621a

andrewlock force-pushed the andrew/exporter-settings branch from 98e405c to 680621a Compare February 26, 2024 09:27

andrewlock merged commit a1568ad into master Feb 26, 2024
55 checks passed

andrewlock deleted the andrew/exporter-settings branch February 26, 2024 11:06

github-actions bot added this to the vNext milestone Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scenario where dogstatsd tries to send to the wrong hostname #5222

Fix scenario where dogstatsd tries to send to the wrong hostname #5222

andrewlock commented Feb 21, 2024

kevingosse Feb 21, 2024

andrewlock Feb 21, 2024

andrewlock Feb 22, 2024

datadog-ddstaging bot commented Feb 21, 2024 •

edited

Loading

andrewlock commented Feb 21, 2024 •

edited

Loading

andrewlock commented Feb 21, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5222

Fewer allocations 🎉 in #5222

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5222

Raw results

Slower ⚠️ in #5222

Raw results

andrewlock commented Feb 21, 2024 •

edited

Loading

link04 left a comment

Fix scenario where dogstatsd tries to send to the wrong hostname #5222

Fix scenario where dogstatsd tries to send to the wrong hostname #5222

Conversation

andrewlock commented Feb 21, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

kevingosse Feb 21, 2024

Choose a reason for hiding this comment

andrewlock Feb 21, 2024

Choose a reason for hiding this comment

andrewlock Feb 22, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Feb 21, 2024 • edited Loading

Datadog Report

andrewlock commented Feb 21, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Feb 21, 2024 • edited Loading

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #5222

Fewer allocations 🎉 in #5222

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5222

Raw results

Slower ⚠️ in #5222

Raw results

andrewlock commented Feb 21, 2024 • edited Loading

Throughput/Crank Report:zap:

link04 left a comment

Choose a reason for hiding this comment

datadog-ddstaging bot commented Feb 21, 2024 •

edited

Loading

andrewlock commented Feb 21, 2024 •

edited

Loading

andrewlock commented Feb 21, 2024 •

edited

Loading

andrewlock commented Feb 21, 2024 •

edited

Loading