Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing generated aspects #5225

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Missing generated aspects #5225

merged 1 commit into from
Feb 22, 2024

Conversation

robertpi
Copy link
Member

Summary of changes

Some generate code that wasn't committed.

@robertpi robertpi requested a review from a team as a code owner February 22, 2024 10:21
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Feb 22, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Feb 22, 2024 •
edited
Loading

Datadog Report

Branch report: robert/asm/missing-generated-code
Commit report: 79dd231
Test service: dd-trace-dotnet

✅ 0 Failed, 311463 Passed, 1591 Skipped, 40m 48.08s Wall Time

e-n-0
e-n-0 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@e-n-0 e-n-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the oversight

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (73ms)  : 67, 80
     .   : milestone, 73,
    master - mean (73ms)  : 64, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (989ms)  : 966, 1011
     .   : milestone, 989,
    master - mean (980ms)  : 961, 999
     .   : milestone, 980,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (111ms)  : 108, 115
     .   : milestone, 111,
    master - mean (110ms)  : 106, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (714ms)  : 690, 737
     .   : milestone, 714,
    master - mean (708ms)  : 687, 728
     .   : milestone, 708,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (671ms)  : 647, 695
     .   : milestone, 671,
    master - mean (662ms)  : 646, 678
     .   : milestone, 662,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (187ms)  : 183, 190
     .   : milestone, 187,
    master - mean (188ms)  : 184, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (1,055ms)  : 1030, 1079
     .   : milestone, 1055,
    master - mean (1,059ms)  : 1037, 1081
     .   : milestone, 1059,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (270ms)  : 265, 274
     .   : milestone, 270,
    master - mean (270ms)  : 264, 276
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (1,055ms)  : 1031, 1080
     .   : milestone, 1055,
    master - mean (1,055ms)  : 1030, 1080
     .   : milestone, 1055,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5225) - mean (258ms)  : 253, 263
     .   : milestone, 258,
    master - mean (259ms)  : 255, 263
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5225) - mean (998ms)  : 970, 1025
     .   : milestone, 998,
    master - mean (1,005ms)  : 985, 1026
     .   : milestone, 1005,
Loading

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #5225 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.135
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 9.02μs 51.2ns 362ns 0.0222 0.00886 0 7.5 KB
master StartStopWithChild netcoreapp3.1 10.3μs 51.4ns 241ns 0.0201 0.00503 0 7.59 KB
master StartStopWithChild net472 17.1μs 71.9ns 279ns 1.31 0.323 0.102 7.97 KB
#5225 StartStopWithChild net6.0 8.76μs 47.8ns 262ns 0.026 0.013 0 7.49 KB
#5225 StartStopWithChild netcoreapp3.1 10.6μs 58ns 410ns 0.02 0.00499 0 7.59 KB
#5225 StartStopWithChild net472 17μs 69.8ns 270ns 1.35 0.357 0.111 7.96 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 461μs 384ns 1.49μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 617μs 311ns 1.21μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 809μs 255ns 954ns 0.406 0 0 3.3 KB
#5225 WriteAndFlushEnrichedTraces net6.0 448μs 597ns 2.31μs 0 0 0 2.7 KB
#5225 WriteAndFlushEnrichedTraces netcoreapp3.1 644μs 328ns 1.23μs 0 0 0 2.7 KB
#5225 WriteAndFlushEnrichedTraces net472 807μs 164ns 637ns 0.401 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 40.7μs 29.9ns 112ns 0.02 0 0 2.36 KB
master AllCycleSimpleBody netcoreapp3.1 43.4μs 153ns 592ns 0.0214 0 0 2.34 KB
master AllCycleSimpleBody net472 47.1μs 27.7ns 107ns 0.372 0 0 2.41 KB
master AllCycleMoreComplexBody net6.0 213μs 70.4ns 273ns 0.107 0 0 9.84 KB
master AllCycleMoreComplexBody netcoreapp3.1 226μs 192ns 742ns 0.112 0 0 9.73 KB
master AllCycleMoreComplexBody net472 242μs 98.4ns 355ns 1.57 0 0 9.91 KB
master ObjectExtractorSimpleBody net6.0 156ns 0.174ns 0.673ns 0.00393 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 199ns 0.113ns 0.422ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 172ns 0.144ns 0.559ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 3.01μs 3.13ns 11.3ns 0.0525 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.05μs 1.59ns 5.93ns 0.0505 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.8μs 1.44ns 5.4ns 0.603 0.0057 0 3.8 KB
#5225 AllCycleSimpleBody net6.0 40.8μs 14.4ns 55.8ns 0.0201 0 0 2.36 KB
#5225 AllCycleSimpleBody netcoreapp3.1 43.2μs 49.7ns 192ns 0.0222 0 0 2.34 KB
#5225 AllCycleSimpleBody net472 46.8μs 26.1ns 101ns 0.374 0 0 2.41 KB
#5225 AllCycleMoreComplexBody net6.0 212μs 61.7ns 239ns 0.107 0 0 9.84 KB
#5225 AllCycleMoreComplexBody netcoreapp3.1 226μs 358ns 1.39μs 0.112 0 0 9.73 KB
#5225 AllCycleMoreComplexBody net472 239μs 38.4ns 138ns 1.55 0 0 9.91 KB
#5225 ObjectExtractorSimpleBody net6.0 146ns 0.0721ns 0.27ns 0.00394 0 0 280 B
#5225 ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.089ns 0.345ns 0.00367 0 0 272 B
#5225 ObjectExtractorSimpleBody net472 171ns 0.102ns 0.395ns 0.0446 0 0 281 B
#5225 ObjectExtractorMoreComplexBody net6.0 3.01μs 2.49ns 9.64ns 0.0527 0 0 3.78 KB
#5225 ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 2ns 7.76ns 0.0487 0 0 3.69 KB
#5225 ObjectExtractorMoreComplexBody net472 3.84μs 4.94ns 19.1ns 0.603 0.00576 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 51.9μs 51.5ns 193ns 0.418 0 0 30.94 KB
master EncodeArgs netcoreapp3.1 70.1μs 101ns 390ns 0.418 0 0 31.47 KB
master EncodeArgs net472 85μs 41.9ns 162ns 5.12 0.0846 0 32.27 KB
master EncodeLegacyArgs net6.0 131μs 311ns 1.16μs 0.487 0 0 33.89 KB
master EncodeLegacyArgs netcoreapp3.1 155μs 296ns 1.15μs 0.472 0 0 34.08 KB
master EncodeLegacyArgs net472 217μs 327ns 1.27μs 5.46 0.42 0 35 KB
#5225 EncodeArgs net6.0 54.4μs 69.9ns 262ns 0.438 0 0 30.94 KB
#5225 EncodeArgs netcoreapp3.1 69.5μs 60.5ns 234ns 0.415 0 0 31.47 KB
#5225 EncodeArgs net472 84.2μs 51.8ns 194ns 5.13 0.0847 0 32.27 KB
#5225 EncodeLegacyArgs net6.0 125μs 416ns 1.56μs 0.439 0 0 33.89 KB
#5225 EncodeLegacyArgs netcoreapp3.1 158μs 121ns 436ns 0.479 0 0 34.08 KB
#5225 EncodeLegacyArgs net472 217μs 497ns 1.93μs 5.5 0.423 0 34.99 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 189μs 104ns 391ns 0.0947 0 0 6.51 KB
master RunWafRealisticBenchmark netcoreapp3.1 205μs 324ns 1.26μs 0 0 0 6.49 KB
master RunWafRealisticBenchmark net472 224μs 522ns 2.02μs 0.997 0 0 6.59 KB
master RunWafRealisticBenchmarkWithAttack net6.0 126μs 193ns 839ns 0.0635 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 134μs 198ns 768ns 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack net472 147μs 39.7ns 143ns 0.659 0 0 4.19 KB
#5225 RunWafRealisticBenchmark net6.0 190μs 135ns 506ns 0.094 0 0 6.51 KB
#5225 RunWafRealisticBenchmark netcoreapp3.1 205μs 364ns 1.41μs 0 0 0 6.49 KB
#5225 RunWafRealisticBenchmark net472 224μs 146ns 566ns 1 0 0 6.59 KB
#5225 RunWafRealisticBenchmarkWithAttack net6.0 126μs 274ns 1.06μs 0.0636 0 0 4.15 KB
#5225 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 133μs 129ns 502ns 0 0 0 4.14 KB
#5225 RunWafRealisticBenchmarkWithAttack net472 146μs 66.1ns 256ns 0.659 0 0 4.19 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 194ns 750ns 0.253 0 0 18.26 KB
master SendRequest netcoreapp3.1 188μs 150ns 563ns 0.187 0 0 20.42 KB
master SendRequest net472 0.000841ns 0.000381ns 0.00143ns 0 0 0 0 b
#5225 SendRequest net6.0 171μs 134ns 502ns 0.255 0 0 18.26 KB
#5225 SendRequest netcoreapp3.1 192μs 336ns 1.3μs 0.189 0 0 20.42 KB
#5225 SendRequest net472 0.000518ns 0.000187ns 0.000726ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 548μs 1.46μs 5.65μs 0.548 0 0 41.86 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 1.85μs 7.15μs 0.324 0 0 41.69 KB
master WriteAndFlushEnrichedTraces net472 833μs 4.15μs 18.1μs 8.17 2.45 0.408 53.25 KB
#5225 WriteAndFlushEnrichedTraces net6.0 559μs 435ns 1.69μs 0.561 0 0 41.88 KB
#5225 WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 2.41μs 9.33μs 0.324 0 0 41.77 KB
#5225 WriteAndFlushEnrichedTraces net472 847μs 2.96μs 11.5μs 8.45 2.53 0.422 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.12μs 0.927ns 3.59ns 0.0106 0 0 776 B
master ExecuteNonQuery netcoreapp3.1 1.49μs 1.21ns 4.67ns 0.0105 0 0 776 B
master ExecuteNonQuery net472 1.73μs 0.999ns 3.87ns 0.117 0 0 738 B
#5225 ExecuteNonQuery net6.0 1.08μs 0.879ns 3.4ns 0.0107 0 0 776 B
#5225 ExecuteNonQuery netcoreapp3.1 1.49μs 0.957ns 3.71ns 0.0104 0 0 776 B
#5225 ExecuteNonQuery net472 1.74μs 0.769ns 2.98ns 0.117 0 0 738 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.28μs 0.669ns 2.5ns 0.0128 0 0 944 B
master CallElasticsearch netcoreapp3.1 1.56μs 1.48ns 5.14ns 0.0126 0 0 944 B
master CallElasticsearch net472 2.59μs 1.4ns 5.25ns 0.153 0 0 963 B
master CallElasticsearchAsync net6.0 1.25μs 0.757ns 2.83ns 0.013 0 0 920 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 0.519ns 1.87ns 0.0135 0 0 992 B
master CallElasticsearchAsync net472 2.61μs 0.814ns 3.15ns 0.162 0 0 1.02 KB
#5225 CallElasticsearch net6.0 1.19μs 0.541ns 2.02ns 0.0132 0 0 944 B
#5225 CallElasticsearch netcoreapp3.1 1.51μs 0.419ns 1.45ns 0.0122 0 0 944 B
#5225 CallElasticsearch net472 2.46μs 0.561ns 2.1ns 0.152 0 0 963 B
#5225 CallElasticsearchAsync net6.0 1.23μs 0.74ns 2.86ns 0.0129 0 0 920 B
#5225 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.835ns 3.23ns 0.0128 0 0 992 B
#5225 CallElasticsearchAsync net472 2.53μs 1.16ns 4.5ns 0.162 0 0 1.02 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.617ns 2.39ns 0.0127 0 0 920 B
master ExecuteAsync netcoreapp3.1 1.71μs 1.15ns 4.31ns 0.0121 0 0 920 B
master ExecuteAsync net472 1.95μs 0.821ns 3.18ns 0.139 0 0 883 B
#5225 ExecuteAsync net6.0 1.26μs 0.499ns 1.87ns 0.0126 0 0 920 B
#5225 ExecuteAsync netcoreapp3.1 1.61μs 1.3ns 5.05ns 0.012 0 0 920 B
#5225 ExecuteAsync net472 1.8μs 1.1ns 4.26ns 0.14 0 0 883 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.98μs 2.34ns 8.45ns 0.0279 0 0 2.1 KB
master SendAsync netcoreapp3.1 4.91μs 1.54ns 5.78ns 0.0345 0 0 2.64 KB
master SendAsync net472 7.75μs 1.59ns 6.17ns 0.526 0 0 3.31 KB
#5225 SendAsync net6.0 4.15μs 1.63ns 6.08ns 0.029 0 0 2.1 KB
#5225 SendAsync netcoreapp3.1 5μs 1.29ns 5ns 0.0349 0 0 2.64 KB
#5225 SendAsync net472 7.76μs 4.02ns 15.6ns 0.524 0 0 3.31 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5225

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 55.75 KB 57.9 KB 2.14 KB 3.85%

Fewer allocations 🎉 in #5225

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 204.86 KB 201.94 KB -2.93 KB -1.43%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 51.1μs 208ns 749ns 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 61μs 869ns 8.56μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 37.3μs 67.1ns 242ns 0 0 0 55.75 KB
master StringConcatAspectBenchmark net6.0 271μs 2.98μs 27.5μs 0 0 0 204.86 KB
master StringConcatAspectBenchmark netcoreapp3.1 277μs 1.17μs 5.46μs 0 0 0 201.66 KB
master StringConcatAspectBenchmark net472 233μs 1.23μs 7.19μs 0 0 0 221.18 KB
#5225 StringConcatBenchmark net6.0 50.8μs 223ns 805ns 0 0 0 43.44 KB
#5225 StringConcatBenchmark netcoreapp3.1 57.4μs 671ns 6.47μs 0 0 0 42.64 KB
#5225 StringConcatBenchmark net472 38.4μs 78.8ns 284ns 0 0 0 57.9 KB
#5225 StringConcatAspectBenchmark net6.0 264μs 1.03μs 5.16μs 0 0 0 201.94 KB
#5225 StringConcatAspectBenchmark netcoreapp3.1 277μs 1.56μs 10.2μs 0 0 0 201.45 KB
#5225 StringConcatAspectBenchmark net472 246μs 3.06μs 28.7μs 0 0 0 221.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.832ns 3.11ns 0.022 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 2.27μs 1.08ns 4.03ns 0.0214 0 0 1.58 KB
master EnrichedLog net472 2.47μs 4.55ns 17.6ns 0.239 0 0 1.51 KB
#5225 EnrichedLog net6.0 1.54μs 0.78ns 2.92ns 0.0224 0 0 1.58 KB
#5225 EnrichedLog netcoreapp3.1 2.29μs 0.674ns 2.52ns 0.0216 0 0 1.58 KB
#5225 EnrichedLog net472 2.47μs 1.26ns 4.56ns 0.238 0 0 1.51 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 113μs 86.7ns 324ns 0.0564 0 0 4.22 KB
master EnrichedLog netcoreapp3.1 118μs 126ns 488ns 0.0592 0 0 4.22 KB
master EnrichedLog net472 147μs 52ns 202ns 0.659 0.22 0 4.4 KB
#5225 EnrichedLog net6.0 116μs 111ns 416ns 0.0577 0 0 4.22 KB
#5225 EnrichedLog netcoreapp3.1 120μs 141ns 508ns 0 0 0 4.22 KB
#5225 EnrichedLog net472 147μs 57.8ns 224ns 0.658 0.219 0 4.4 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.98μs 1ns 3.76ns 0.0298 0 0 2.14 KB
master EnrichedLog netcoreapp3.1 4.43μs 17.8ns 69.1ns 0.0277 0 0 2.14 KB
master EnrichedLog net472 4.96μs 0.882ns 3.42ns 0.309 0 0 1.95 KB
#5225 EnrichedLog net6.0 2.94μs 0.958ns 3.71ns 0.0294 0 0 2.14 KB
#5225 EnrichedLog netcoreapp3.1 4.34μs 10.6ns 41.1ns 0.0289 0 0 2.14 KB
#5225 EnrichedLog net472 4.87μs 1.28ns 4.78ns 0.31 0 0 1.95 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.34μs 0.237ns 0.856ns 0.0154 0 0 1.11 KB
master SendReceive netcoreapp3.1 1.81μs 1.5ns 5.8ns 0.0153 0 0 1.11 KB
master SendReceive net472 2.17μs 3.06ns 11.9ns 0.178 0 0 1.12 KB
#5225 SendReceive net6.0 1.35μs 0.508ns 1.9ns 0.0156 0 0 1.11 KB
#5225 SendReceive netcoreapp3.1 1.72μs 1.88ns 7.02ns 0.0153 0 0 1.11 KB
#5225 SendReceive net472 2.07μs 1.33ns 4.98ns 0.178 0 0 1.12 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.85μs 0.725ns 2.71ns 0.0215 0 0 1.54 KB
master EnrichedLog netcoreapp3.1 3.92μs 1.14ns 4.26ns 0.0214 0 0 1.58 KB
master EnrichedLog net472 4.26μs 2.28ns 8.85ns 0.313 0 0 1.97 KB
#5225 EnrichedLog net6.0 2.71μs 0.563ns 2.03ns 0.0216 0 0 1.54 KB
#5225 EnrichedLog netcoreapp3.1 3.91μs 1.23ns 4.78ns 0.0217 0 0 1.58 KB
#5225 EnrichedLog net472 4.25μs 1.66ns 6.42ns 0.313 0 0 1.97 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5225

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.151 622.30 540.54

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 501ns 0.462ns 1.79ns 0.0076 0 0 544 B
master StartFinishSpan netcoreapp3.1 732ns 0.808ns 3.02ns 0.00728 0 0 544 B
master StartFinishSpan net472 760ns 1.33ns 5.15ns 0.0866 0 0 546 B
master StartFinishScope net6.0 621ns 0.7ns 2.71ns 0.00928 0 0 664 B
master StartFinishScope netcoreapp3.1 809ns 0.389ns 1.51ns 0.00893 0 0 664 B
master StartFinishScope net472 992ns 1.72ns 6.66ns 0.099 0 0 626 B
#5225 StartFinishSpan net6.0 473ns 0.86ns 3.33ns 0.00759 0 0 544 B
#5225 StartFinishSpan netcoreapp3.1 765ns 1.39ns 5.37ns 0.0073 0 0 544 B
#5225 StartFinishSpan net472 809ns 2.1ns 8.12ns 0.0866 0 0 546 B
#5225 StartFinishScope net6.0 540ns 0.78ns 3.02ns 0.00941 0 0 664 B
#5225 StartFinishScope netcoreapp3.1 792ns 1.52ns 5.89ns 0.00882 0 0 664 B
#5225 StartFinishScope net472 947ns 2.06ns 7.96ns 0.0991 0 0 626 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5225

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.119 1,032.27 922.36

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 655ns 0.975ns 3.78ns 0.00916 0 0 664 B
master RunOnMethodBegin netcoreapp3.1 1.03μs 1.2ns 4.64ns 0.00898 0 0 664 B
master RunOnMethodBegin net472 1.08μs 1.71ns 6.62ns 0.0994 0 0 626 B
#5225 RunOnMethodBegin net6.0 593ns 1.22ns 4.74ns 0.00939 0 0 664 B
#5225 RunOnMethodBegin netcoreapp3.1 918ns 2.83ns 11ns 0.00881 0 0 664 B
#5225 RunOnMethodBegin net472 1.12μs 2.26ns 8.75ns 0.0994 0 0 626 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5225) (10.670M)   : 0, 10669547
    master (11.053M)   : 0, 11052820
    benchmarks/2.9.0 (10.979M)   : 0, 10979446

    section Automatic
    This PR (5225) (7.250M)   : 0, 7249888
    master (7.530M)   : 0, 7530391
    benchmarks/2.9.0 (7.859M)   : 0, 7859038

    section Trace stats
    This PR (5225) (7.745M)   : 0, 7745363
    master (7.884M)   : 0, 7884293

    section Manual
    This PR (5225) (9.206M)   : 0, 9205557
    master (9.459M)   : 0, 9459364

    section Manual + Automatic
    This PR (5225) (6.959M)   : 0, 6959276
    master (7.041M)   : 0, 7040592

    section Version Conflict
    This PR (5225) (6.235M)   : 0, 6234804
    master (6.348M)   : 0, 6347921
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5225) (9.673M)   : 0, 9672828
    master (9.499M)   : 0, 9498623
    benchmarks/2.9.0 (9.584M)   : 0, 9584350

    section Automatic
    This PR (5225) (6.567M)   : 0, 6566700
    master (6.616M)   : 0, 6616463

    section Trace stats
    This PR (5225) (6.773M)   : 0, 6772783
    master (6.746M)   : 0, 6745954

    section Manual
    This PR (5225) (8.357M)   : 0, 8357045
    master (8.055M)   : 0, 8055213

    section Manual + Automatic
    This PR (5225) (6.108M)   : 0, 6108253
    master (6.248M)   : 0, 6248342

    section Version Conflict
    This PR (5225) (5.735M)   : 0, 5734797
    master (5.714M)   : 0, 5714359
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5225) (9.906M)   : 0, 9906288
    master (10.382M)   : 0, 10381892
    benchmarks/2.9.0 (10.208M)   : 0, 10207519

    section Automatic
    This PR (5225) (6.896M)   : crit ,0, 6895883
    master (7.344M)   : 0, 7343803
    benchmarks/2.9.0 (7.459M)   : 0, 7458789

    section Trace stats
    This PR (5225) (7.319M)   : 0, 7318794
    master (7.700M)   : 0, 7700057

    section Manual
    This PR (5225) (9.116M)   : 0, 9116350
    master (9.131M)   : 0, 9131037

    section Manual + Automatic
    This PR (5225) (7.120M)   : 0, 7120490
    master (7.165M)   : 0, 7164860

    section Version Conflict
    This PR (5225) (6.390M)   : 0, 6390141
    master (6.399M)   : 0, 6399272
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    master (7.408M)   : 0, 7408055
    benchmarks/2.9.0 (7.796M)   : 0, 7796204

    section No attack
    master (1.828M)   : 0, 1827588
    benchmarks/2.9.0 (3.173M)   : 0, 3173080

    section Attack
    master (1.470M)   : 0, 1470225
    benchmarks/2.9.0 (2.461M)   : 0, 2460599

    section Blocking
    master (3.121M)   : 0, 3121169

    section IAST default
    master (6.311M)   : 0, 6310654

    section IAST full
    master (5.513M)   : 0, 5512612

    section Base vuln
    master (0.930M)   : 0, 929851

    section IAST vuln
    master (0.849M)   : 0, 849115
Loading

@robertpi robertpi merged commit efc8182 into master Feb 22, 2024
55 checks passed
@robertpi robertpi deleted the robert/asm/missing-generated-code branch February 22, 2024 15:50
@github-actions github-actions bot added this to the vNext milestone Feb 22, 2024
@andrewlock andrewlock added area:asm area:asm-iast and removed area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlock andrewlock andrewlock approved these changes

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees
No one assigned
Labels
area:asm area:asm-iast
Projects
None yet
Milestone
2.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robertpi @andrewlock @e-n-0