Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Running AspNetCore5IastTestsFullSampling Tests Serially #5333

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[Test] Running AspNetCore5IastTestsFullSampling Tests Serially #5333

merged 1 commit into from
Mar 21, 2024

Conversation

link04
Copy link
Contributor

@link04 link04 commented Mar 21, 2024

Summary of changes

Updated AspNetCore5IastTestsFullSampling class to run serially and try to prevent flakes due to timeout.

@link04 link04 added the area:tests unit tests, integration tests label Mar 21, 2024
@link04 link04 requested a review from a team as a code owner March 21, 2024 13:14
NachoEchevarria
NachoEchevarria approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 21, 2024 •
edited
Loading

Datadog Report

Branch report: maximo/running-iast-test-serially
Commit report: 06ac28e
Test service: dd-trace-dotnet

✅ 0 Failed, 311880 Passed, 1530 Skipped, 41m 52.47s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (73ms)  : 65, 80
     .   : milestone, 73,
    master - mean (73ms)  : 64, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (1,005ms)  : 978, 1032
     .   : milestone, 1005,
    master - mean (1,002ms)  : 980, 1024
     .   : milestone, 1002,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 106, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (721ms)  : 704, 738
     .   : milestone, 721,
    master - mean (718ms)  : 697, 738
     .   : milestone, 718,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (94ms)  : 90, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (680ms)  : 660, 699
     .   : milestone, 680,
    master - mean (680ms)  : 661, 699
     .   : milestone, 680,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 185, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (1,076ms)  : 1057, 1094
     .   : milestone, 1076,
    master - mean (1,078ms)  : 1060, 1097
     .   : milestone, 1078,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (271ms)  : 267, 276
     .   : milestone, 271,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (877ms)  : 850, 905
     .   : milestone, 877,
    master - mean (872ms)  : 849, 894
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5333) - mean (260ms)  : 256, 264
     .   : milestone, 260,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5333) - mean (858ms)  : 835, 880
     .   : milestone, 858,
    master - mean (856ms)  : 830, 882
     .   : milestone, 856,
Loading

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5333 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.131
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 9.67μs 59.4ns 591ns 0.0185 0.00461 0 7.51 KB
master StartStopWithChild netcoreapp3.1 11μs 57.8ns 289ns 0.022 0.011 0 7.61 KB
master StartStopWithChild net472 18.7μs 128ns 1.27μs 1.33 0.333 0.0965 8.05 KB
#5333 StartStopWithChild net6.0 8.64μs 44.9ns 220ns 0.0175 0.00873 0 7.5 KB
#5333 StartStopWithChild netcoreapp3.1 11.1μs 56.5ns 259ns 0.0273 0.0109 0 7.6 KB
#5333 StartStopWithChild net472 17.2μs 55.8ns 216ns 1.36 0.36 0.126 8.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 471μs 162ns 626ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 622μs 300ns 1.16μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 825μs 328ns 1.23μs 0.408 0 0 3.3 KB
#5333 WriteAndFlushEnrichedTraces net6.0 467μs 167ns 649ns 0 0 0 2.7 KB
#5333 WriteAndFlushEnrichedTraces netcoreapp3.1 628μs 289ns 1.08μs 0 0 0 2.7 KB
#5333 WriteAndFlushEnrichedTraces net472 813μs 240ns 897ns 0.406 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 226ns 844ns 0.17 0 0 18.33 KB
master SendRequest netcoreapp3.1 196μs 237ns 918ns 0.195 0 0 20.49 KB
master SendRequest net472 0.000187ns 0.00014ns 0.000522ns 0 0 0 0 b
#5333 SendRequest net6.0 169μs 142ns 532ns 0.252 0 0 18.33 KB
#5333 SendRequest netcoreapp3.1 192μs 271ns 1.05μs 0.192 0 0 20.49 KB
#5333 SendRequest net472 0.000398ns 0.000163ns 0.000631ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5333

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.7 KB 41.46 KB -237 B -0.57%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 553μs 259ns 967ns 0.546 0 0 41.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 1.2μs 4.66μs 0.324 0 0 41.81 KB
master WriteAndFlushEnrichedTraces net472 858μs 2.83μs 10.6μs 8.19 2.59 0.431 53.24 KB
#5333 WriteAndFlushEnrichedTraces net6.0 543μs 292ns 1.09μs 0.546 0 0 41.46 KB
#5333 WriteAndFlushEnrichedTraces netcoreapp3.1 668μs 950ns 3.68μs 0.329 0 0 41.8 KB
#5333 WriteAndFlushEnrichedTraces net472 863μs 4.13μs 17μs 8.3 2.62 0.437 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.18μs 1.03ns 4.01ns 0.0112 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.64μs 0.402ns 1.45ns 0.0107 0 0 784 B
master ExecuteNonQuery net472 1.78μs 0.905ns 3.5ns 0.119 0 0 746 B
#5333 ExecuteNonQuery net6.0 1.27μs 0.831ns 3.22ns 0.0111 0 0 784 B
#5333 ExecuteNonQuery netcoreapp3.1 1.57μs 0.75ns 2.91ns 0.0103 0 0 784 B
#5333 ExecuteNonQuery net472 1.76μs 0.441ns 1.65ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 1.95ns 7.54ns 0.014 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.66μs 1.13ns 4.39ns 0.0136 0 0 1.01 KB
master CallElasticsearch net472 2.57μs 0.802ns 3ns 0.161 0.00129 0 1.02 KB
master CallElasticsearchAsync net6.0 1.42μs 1.11ns 4.3ns 0.0142 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 2.61ns 9.78ns 0.0141 0 0 1.06 KB
master CallElasticsearchAsync net472 2.68μs 1.54ns 5.55ns 0.171 0.00134 0 1.08 KB
#5333 CallElasticsearch net6.0 1.27μs 0.772ns 2.99ns 0.0142 0 0 1.01 KB
#5333 CallElasticsearch netcoreapp3.1 1.63μs 0.624ns 2.34ns 0.0138 0 0 1.01 KB
#5333 CallElasticsearch net472 2.56μs 0.664ns 2.3ns 0.161 0 0 1.02 KB
#5333 CallElasticsearchAsync net6.0 1.43μs 0.398ns 1.54ns 0.0137 0 0 984 B
#5333 CallElasticsearchAsync netcoreapp3.1 1.69μs 1.97ns 7.62ns 0.0144 0 0 1.06 KB
#5333 CallElasticsearchAsync net472 2.69μs 1.58ns 6.13ns 0.17 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.28μs 0.967ns 3.74ns 0.0128 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.67μs 1.58ns 5.9ns 0.0124 0 0 928 B
master ExecuteAsync net472 1.9μs 0.762ns 2.95ns 0.141 0 0 891 B
#5333 ExecuteAsync net6.0 1.33μs 0.392ns 1.52ns 0.0126 0 0 928 B
#5333 ExecuteAsync netcoreapp3.1 1.77μs 0.871ns 3.14ns 0.0125 0 0 928 B
#5333 ExecuteAsync net472 1.89μs 0.76ns 2.84ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.2μs 2.79ns 10.8ns 0.0294 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.18μs 2.42ns 9.39ns 0.0361 0 0 2.7 KB
master SendAsync net472 7.73μs 4.03ns 15.1ns 0.484 0 0 3.05 KB
#5333 SendAsync net6.0 4.1μs 1.64ns 6.34ns 0.0288 0 0 2.16 KB
#5333 SendAsync netcoreapp3.1 5.16μs 2.07ns 7.48ns 0.0367 0 0 2.7 KB
#5333 SendAsync net472 7.65μs 2.08ns 8.05ns 0.483 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.695ns 2.6ns 0.0229 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.3μs 8.34ns 32.3ns 0.0227 0 0 1.65 KB
master EnrichedLog net472 2.83μs 3.61ns 14ns 0.249 0 0 1.57 KB
#5333 EnrichedLog net6.0 1.42μs 0.681ns 2.55ns 0.0229 0 0 1.65 KB
#5333 EnrichedLog netcoreapp3.1 2.31μs 1.42ns 5.52ns 0.022 0 0 1.65 KB
#5333 EnrichedLog net472 2.62μs 1.62ns 6.27ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 64.4ns 241ns 0.0562 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 155ns 599ns 0 0 0 4.23 KB
master EnrichedLog net472 147μs 127ns 494ns 0.657 0.219 0 4.41 KB
#5333 EnrichedLog net6.0 112μs 57.5ns 215ns 0.0567 0 0 4.23 KB
#5333 EnrichedLog netcoreapp3.1 118μs 137ns 529ns 0 0 0 4.23 KB
#5333 EnrichedLog net472 147μs 70.5ns 273ns 0.66 0.22 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.07μs 1.03ns 3.85ns 0.0307 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.29μs 4.46ns 17.3ns 0.0299 0 0 2.21 KB
master EnrichedLog net472 5.09μs 1.85ns 7.18ns 0.32 0 0 2.02 KB
#5333 EnrichedLog net6.0 3.05μs 2.23ns 8.35ns 0.0303 0 0 2.21 KB
#5333 EnrichedLog netcoreapp3.1 4.27μs 3.15ns 12.2ns 0.0296 0 0 2.21 KB
#5333 EnrichedLog net472 4.92μs 1ns 3.61ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.867ns 3.36ns 0.0164 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.89μs 0.891ns 3.34ns 0.016 0 0 1.18 KB
master SendReceive net472 2.36μs 1.76ns 6.81ns 0.187 0 0 1.18 KB
#5333 SendReceive net6.0 1.4μs 0.483ns 1.87ns 0.0162 0 0 1.18 KB
#5333 SendReceive netcoreapp3.1 1.81μs 3.93ns 15.2ns 0.0155 0 0 1.18 KB
#5333 SendReceive net472 2.21μs 2.39ns 9.25ns 0.187 0.0011 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.64μs 0.717ns 2.68ns 0.0211 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 4.06μs 1.01ns 3.66ns 0.0205 0 0 1.6 KB
master EnrichedLog net472 4.51μs 1.97ns 7.37ns 0.316 0 0 1.99 KB
#5333 EnrichedLog net6.0 2.8μs 0.83ns 2.99ns 0.0212 0 0 1.55 KB
#5333 EnrichedLog netcoreapp3.1 4.07μs 3.65ns 14.1ns 0.0203 0 0 1.6 KB
#5333 EnrichedLog net472 4.35μs 2.74ns 10.6ns 0.315 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5333

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.131 709.07 802.17

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 483ns 0.807ns 3.02ns 0.00761 0 0 552 B
master StartFinishSpan netcoreapp3.1 710ns 0.615ns 2.38ns 0.00752 0 0 552 B
master StartFinishSpan net472 782ns 0.396ns 1.53ns 0.0878 0 0 554 B
master StartFinishScope net6.0 620ns 0.915ns 3.55ns 0.00928 0 0 672 B
master StartFinishScope netcoreapp3.1 840ns 0.78ns 3.02ns 0.00918 0 0 672 B
master StartFinishScope net472 1.05μs 1.14ns 4.28ns 0.101 0 0 634 B
#5333 StartFinishSpan net6.0 465ns 0.418ns 1.56ns 0.00766 0 0 552 B
#5333 StartFinishSpan netcoreapp3.1 803ns 0.623ns 2.33ns 0.00749 0 0 552 B
#5333 StartFinishSpan net472 840ns 0.446ns 1.73ns 0.0878 0 0 554 B
#5333 StartFinishScope net6.0 621ns 0.372ns 1.39ns 0.00943 0 0 672 B
#5333 StartFinishScope netcoreapp3.1 810ns 0.755ns 2.83ns 0.00931 0 0 672 B
#5333 StartFinishScope net472 953ns 0.513ns 1.99ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 683ns 0.781ns 3.03ns 0.00958 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 955ns 0.782ns 3.03ns 0.00911 0 0 672 B
master RunOnMethodBegin net472 1.17μs 1.6ns 5.76ns 0.1 0 0 634 B
#5333 RunOnMethodBegin net6.0 703ns 0.699ns 2.71ns 0.00948 0 0 672 B
#5333 RunOnMethodBegin netcoreapp3.1 983ns 1.21ns 4.69ns 0.00886 0 0 672 B
#5333 RunOnMethodBegin net472 1.13μs 1.4ns 5.44ns 0.1 0 0 634 B

@andrewlock
Copy link
Member

Benchmarks Report for appsec 🐌

Benchmarks for #5333 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.135
  • 2 benchmarks are slower, with geometric mean 1.186
  • 3 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5333

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.168 171.35 200.08

Faster 🎉 in #5333

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.135 5,087.57 4,484.09

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 561ns 0.417ns 1.56ns 0.0153 0 0 1.08 KB
master AllCycleSimpleBody netcoreapp3.1 785ns 0.428ns 1.48ns 0.0145 0 0 1.06 KB
master AllCycleSimpleBody net472 667ns 0.314ns 1.22ns 0.175 0.000331 0 1.1 KB
master AllCycleMoreComplexBody net6.0 3.59μs 2.91ns 10.9ns 0.0647 0 0 4.58 KB
master AllCycleMoreComplexBody netcoreapp3.1 4.58μs 2.66ns 9.96ns 0.0618 0 0 4.48 KB
master AllCycleMoreComplexBody net472 5.09μs 2.55ns 9.86ns 0.731 0.00764 0 4.61 KB
master ObjectExtractorSimpleBody net6.0 147ns 0.134ns 0.518ns 0.00394 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 203ns 0.116ns 0.433ns 0.00368 0 0 272 B
master ObjectExtractorSimpleBody net472 171ns 0.311ns 1.21ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.99μs 2.67ns 10.3ns 0.0525 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.09μs 9.52ns 36.9ns 0.0505 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 4.53μs 2.06ns 7.41ns 0.601 0.00452 0 3.8 KB
#5333 AllCycleSimpleBody net6.0 615ns 0.608ns 2.35ns 0.0152 0 0 1.08 KB
#5333 AllCycleSimpleBody netcoreapp3.1 808ns 0.62ns 2.32ns 0.0143 0 0 1.06 KB
#5333 AllCycleSimpleBody net472 666ns 0.279ns 1.08ns 0.175 0.000333 0 1.1 KB
#5333 AllCycleMoreComplexBody net6.0 3.61μs 1.48ns 5.52ns 0.0648 0 0 4.58 KB
#5333 AllCycleMoreComplexBody netcoreapp3.1 4.64μs 2.38ns 8.9ns 0.0604 0 0 4.48 KB
#5333 AllCycleMoreComplexBody net472 4.54μs 25.1ns 150ns 0.732 0.00872 0 4.61 KB
#5333 ObjectExtractorSimpleBody net6.0 145ns 0.176ns 0.682ns 0.00396 0 0 280 B
#5333 ObjectExtractorSimpleBody netcoreapp3.1 209ns 0.146ns 0.567ns 0.00377 0 0 272 B
#5333 ObjectExtractorSimpleBody net472 200ns 0.149ns 0.558ns 0.0446 0 0 281 B
#5333 ObjectExtractorMoreComplexBody net6.0 3.11μs 8.94ns 34.6ns 0.0523 0 0 3.78 KB
#5333 ObjectExtractorMoreComplexBody netcoreapp3.1 4.04μs 1.83ns 7.09ns 0.0491 0 0 3.69 KB
#5333 ObjectExtractorMoreComplexBody net472 4.46μs 2.51ns 9.73ns 0.602 0.00667 0 3.8 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 191μs 43.7ns 169ns 0.0956 0 0 6.51 KB
master RunWafRealisticBenchmark netcoreapp3.1 201μs 164ns 615ns 0 0 0 6.49 KB
master RunWafRealisticBenchmark net472 225μs 371ns 1.44μs 0.996 0 0 6.59 KB
master RunWafRealisticBenchmarkWithAttack net6.0 124μs 42.5ns 165ns 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 133μs 279ns 1.08μs 0 0 0 4.15 KB
master RunWafRealisticBenchmarkWithAttack net472 145μs 114ns 413ns 0.661 0 0 4.19 KB
#5333 RunWafRealisticBenchmark net6.0 187μs 102ns 397ns 0 0 0 6.51 KB
#5333 RunWafRealisticBenchmark netcoreapp3.1 207μs 387ns 1.5μs 0 0 0 6.49 KB
#5333 RunWafRealisticBenchmark net472 227μs 252ns 975ns 1 0 0 6.59 KB
#5333 RunWafRealisticBenchmarkWithAttack net6.0 127μs 114ns 443ns 0.0628 0 0 4.15 KB
#5333 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 137μs 275ns 1.07μs 0 0 0 4.15 KB
#5333 RunWafRealisticBenchmarkWithAttack net472 146μs 201ns 780ns 0.65 0 0 4.19 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #5333

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.204 54,000.00 65,000.00 bimodal

Fewer allocations 🎉 in #5333

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 204.09 KB 202.86 KB -1.22 KB -0.60%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 204.98 KB 202.47 KB -2.51 KB -1.23%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 59.22 KB 57.8 KB -1.42 KB -2.40%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 60.7μs 625ns 6.13μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 54μs 162ns 582ns 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.2μs 170ns 636ns 0 0 0 59.22 KB
master StringConcatAspectBenchmark net6.0 278μs 4.54μs 43.6μs 0 0 0 204.98 KB
master StringConcatAspectBenchmark netcoreapp3.1 308μs 1.27μs 4.74μs 0 0 0 204.09 KB
master StringConcatAspectBenchmark net472 258μs 3.75μs 35.7μs 0 0 0 221.18 KB
#5333 StringConcatBenchmark net6.0 64.7μs 804ns 8μs 0 0 0 43.44 KB
#5333 StringConcatBenchmark netcoreapp3.1 66.2μs 754ns 7.5μs 0 0 0 42.64 KB
#5333 StringConcatBenchmark net472 39.1μs 204ns 1.02μs 0 0 0 57.8 KB
#5333 StringConcatAspectBenchmark net6.0 284μs 1.08μs 3.73μs 0 0 0 202.47 KB
#5333 StringConcatAspectBenchmark netcoreapp3.1 324μs 1.47μs 5.52μs 0 0 0 202.86 KB
#5333 StringConcatAspectBenchmark net472 260μs 4.37μs 41.2μs 0 0 0 221.18 KB

@link04 link04 merged commit c00327b into master Mar 21, 2024
54 of 57 checks passed
@link04 link04 deleted the maximo/running-iast-test-serially branch March 21, 2024 14:35
@github-actions github-actions bot added this to the vNext milestone Mar 21, 2024
@andrewlock andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
3 participants
@link04 @andrewlock @NachoEchevarria