[Test Package Versions Bump] Updating package versions #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Datadog ReportBranch report: ✅ 0 Failed, 332357 Passed, 1589 Skipped, 43m 45.94s Wall Time New Flaky Tests (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (74ms) : 64, 83
. : milestone, 74,
master - mean (75ms) : 67, 83
. : milestone, 75,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (1,005ms) : 985, 1025
. : milestone, 1005,
master - mean (1,012ms) : 989, 1035
. : milestone, 1012,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (111ms) : 108, 114
. : milestone, 111,
master - mean (112ms) : 109, 115
. : milestone, 112,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (721ms) : 701, 740
. : milestone, 721,
master - mean (729ms) : 709, 750
. : milestone, 729,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (95ms) : 91, 98
. : milestone, 95,
master - mean (96ms) : 91, 100
. : milestone, 96,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (679ms) : 657, 701
. : milestone, 679,
master - mean (684ms) : 662, 705
. : milestone, 684,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (189ms) : 187, 192
. : milestone, 189,
master - mean (188ms) : 185, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (1,084ms) : 1064, 1104
. : milestone, 1084,
master - mean (1,079ms) : 1056, 1102
. : milestone, 1079,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (272ms) : 269, 275
. : milestone, 272,
master - mean (271ms) : 265, 276
. : milestone, 271,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (875ms) : 851, 899
. : milestone, 875,
master - mean (874ms) : 844, 905
. : milestone, 874,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5338) - mean (261ms) : 257, 264
. : milestone, 261,
master - mean (260ms) : 256, 264
. : milestone, 260,
section CallTarget+Inlining+NGEN
This PR (5338) - mean (860ms) : 830, 890
. : milestone, 860,
master - mean (855ms) : 836, 875
. : milestone, 855,
|
Benchmarks Report for tracer 🐌Benchmarks for #5338 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
|
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.191 | 904.66 | 759.67 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.167 | 635.86 | 545.08 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 559ns | 0.422ns | 1.58ns | 0.00768 | 0 | 0 | 552 B |
| master | StartFinishSpan |
netcoreapp3.1 | 727ns | 1.79ns | 6.93ns | 0.00751 | 0 | 0 | 552 B |
| master | StartFinishSpan |
net472 | 766ns | 0.733ns | 2.84ns | 0.0879 | 0 | 0 | 554 B |
| master | StartFinishScope |
net6.0 | 636ns | 0.549ns | 2.13ns | 0.00953 | 0 | 0 | 672 B |
| master | StartFinishScope |
netcoreapp3.1 | 905ns | 0.766ns | 2.97ns | 0.00898 | 0 | 0 | 672 B |
| master | StartFinishScope |
net472 | 1E+03ns | 0.934ns | 3.62ns | 0.1 | 0 | 0 | 634 B |
| #5338 | StartFinishSpan |
net6.0 | 530ns | 0.619ns | 2.4ns | 0.00776 | 0 | 0 | 552 B |
| #5338 | StartFinishSpan |
netcoreapp3.1 | 736ns | 0.773ns | 2.89ns | 0.0075 | 0 | 0 | 552 B |
| #5338 | StartFinishSpan |
net472 | 767ns | 0.934ns | 3.62ns | 0.0879 | 0 | 0 | 554 B |
| #5338 | StartFinishScope |
net6.0 | 544ns | 0.831ns | 3.11ns | 0.00931 | 0 | 0 | 672 B |
| #5338 | StartFinishScope |
netcoreapp3.1 | 760ns | 1.33ns | 4.98ns | 0.00878 | 0 | 0 | 672 B |
| #5338 | StartFinishScope |
net472 | 1.01μs | 1.02ns | 3.95ns | 0.101 | 0 | 0 | 634 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 620ns | 0.34ns | 1.32ns | 0.00955 | 0 | 0 | 672 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 932ns | 0.609ns | 2.36ns | 0.0092 | 0 | 0 | 672 B |
| master | RunOnMethodBegin |
net472 | 1.13μs | 0.751ns | 2.91ns | 0.1 | 0 | 0 | 634 B |
| #5338 | RunOnMethodBegin |
net6.0 | 629ns | 0.592ns | 2.29ns | 0.00926 | 0 | 0 | 672 B |
| #5338 | RunOnMethodBegin |
netcoreapp3.1 | 975ns | 0.958ns | 3.58ns | 0.00904 | 0 | 0 | 672 B |
| #5338 | RunOnMethodBegin |
net472 | 1.05μs | 1.17ns | 4.54ns | 0.1 | 0 | 0 | 634 B |
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5338) (11.150M) : 0, 11150382
master (11.411M) : 0, 11411178
benchmarks/2.9.0 (10.973M) : 0, 10972668
section Automatic
This PR (5338) (7.580M) : 0, 7580389
master (7.859M) : 0, 7859423
benchmarks/2.9.0 (7.971M) : 0, 7971440
section Trace stats
This PR (5338) (8.013M) : 0, 8013128
master (8.134M) : 0, 8134073
section Manual
This PR (5338) (9.607M) : 0, 9606711
master (9.798M) : 0, 9798189
section Manual + Automatic
This PR (5338) (7.161M) : 0, 7160562
master (7.190M) : 0, 7189592
section Version Conflict
This PR (5338) (6.493M) : 0, 6492507
master (6.720M) : 0, 6719891
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5338) (9.705M) : 0, 9705306
master (9.571M) : 0, 9570918
benchmarks/2.9.0 (9.671M) : 0, 9670561
section Automatic
This PR (5338) (6.596M) : 0, 6595923
master (6.602M) : 0, 6602249
section Trace stats
This PR (5338) (6.809M) : 0, 6808977
master (6.799M) : 0, 6798848
section Manual
This PR (5338) (8.314M) : 0, 8314347
master (8.239M) : 0, 8239331
section Manual + Automatic
This PR (5338) (6.284M) : 0, 6284013
master (6.238M) : 0, 6237897
section Version Conflict
This PR (5338) (5.805M) : 0, 5804502
master (5.738M) : 0, 5738020
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5338) (9.858M) : 0, 9857819
master (9.679M) : 0, 9678812
benchmarks/2.9.0 (9.723M) : 0, 9723215
section Automatic
This PR (5338) (6.929M) : 0, 6929114
master (6.883M) : 0, 6882686
benchmarks/2.9.0 (7.095M) : 0, 7094697
section Trace stats
This PR (5338) (7.178M) : 0, 7177594
master (7.322M) : 0, 7322242
section Manual
This PR (5338) (8.689M) : 0, 8689317
master (8.455M) : 0, 8454868
section Manual + Automatic
This PR (5338) (6.668M) : 0, 6667952
master (6.596M) : 0, 6595880
section Version Conflict
This PR (5338) (5.975M) : 0, 5975007
master (5.971M) : 0, 5970564
gantt
title Throughput Linux x64 (ASM) (Total requests)
dateFormat X
axisFormat %s
section Baseline
benchmarks/2.9.0 (20.689M) : 0, 20689363
section No attack
benchmarks/2.9.0 (20.448M) : 0, 20448059
section Attack
benchmarks/2.9.0 (17.167M) : 0, 17166673
|
andrewlock
force-pushed
the
bot/test-package-versions-bump
branch
from
528dec3
to
dcc7987
Compare
andrewlock
approved these changes
Mar 22, 2024
Comment on lines
+256
to
257
| <!-- Latest package https://www.nuget.org/packages/xunit/2.7.0 --> | ||
| <PackageReference Include="xunit" Version="2.6.6" /> |
There was a problem hiding this comment.
I excluded the xunit update, because it's not currently working (likely requires a test SDK update)
andrewlock
added
area:test-apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the package versions for integration tests.