-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dogstatsd support #535
Conversation
…dardTransform() that will be used for another library
|
||
// Don't expose anything we don't intend to | ||
// by replacing all "public" access modifiers with "internal" | ||
return Regex.Replace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement
} | ||
} | ||
|
||
private static string GetSolutionDirectory() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not the EnvironmentHelper?
@@ -2,11 +2,7 @@ | |||
|
|||
<PropertyGroup> | |||
<OutputType>Exe</OutputType> | |||
<TargetFramework>netcoreapp2.2</TargetFramework> | |||
<TargetFramework>netcoreapp3.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR add files from release 3.3.0 of dogstatsd-csharp-client to
Datadog.Trace
as a vendor library using theUpdateVendors
tool.Changes to
UpdateVendors
tool:enum
,struct
,delegate
, andpartial
typesasync
/await
instead ofTask.Wait()
Datadog.Trace.TestHelpers
project (which depends onDatadog.Trace
)netcoreapp3.0
-> use newSystem.Text.Json
-> remove dependency onNewtonsoft.Json
dogstatsd-csharp-client
to list of downloadsSerilog
anddogstatsd-csharp-client
Changes to
Datadog.Trace
:dogstatsd-csharp-client