Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dogstatsd support #535

Merged
merged 13 commits into from
Oct 24, 2019
Merged

add dogstatsd support #535

merged 13 commits into from
Oct 24, 2019

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Oct 22, 2019

This PR add files from release 3.3.0 of dogstatsd-csharp-client to Datadog.Trace as a vendor library using the UpdateVendors tool.

Changes to UpdateVendors tool:

  • add support for enum, struct, delegate, and partial types
  • use async/await instead of Task.Wait()
  • remove dependency on Datadog.Trace.TestHelpers project (which depends on Datadog.Trace)
  • target netcoreapp3.0 -> use new System.Text.Json -> remove dependency on Newtonsoft.Json
  • add dogstatsd-csharp-client to list of downloads
  • refactor code to allow sharing file transforms between Serilog and dogstatsd-csharp-client

Changes to Datadog.Trace:

  • add vendor files from dogstatsd-csharp-client

@lucaspimentel lucaspimentel added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 22, 2019
@lucaspimentel lucaspimentel added this to the 1.9.0 milestone Oct 22, 2019
@lucaspimentel lucaspimentel self-assigned this Oct 22, 2019
@lucaspimentel lucaspimentel marked this pull request as ready for review October 23, 2019 00:28
@lucaspimentel lucaspimentel requested a review from a team as a code owner October 23, 2019 00:28

// Don't expose anything we don't intend to
// by replacing all "public" access modifiers with "internal"
return Regex.Replace(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement

}
}

private static string GetSolutionDirectory()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the EnvironmentHelper?

@@ -2,11 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.2</TargetFramework>
<TargetFramework>netcoreapp3.0</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:P

Copy link
Collaborator

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaspimentel lucaspimentel merged commit 9e85129 into master Oct 24, 2019
@lucaspimentel lucaspimentel deleted the lpimentel/add-dogstatsd branch October 24, 2019 21:41
@lucaspimentel lucaspimentel added area:health-metrics type:new-feature and removed area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) labels Nov 25, 2019
@lucaspimentel lucaspimentel added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) type:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants