Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] Acknowledge log probe capture limits #5364

Merged
merged 2 commits into from
Apr 4, 2024
Merged

[Dynamic Instrumentation] Acknowledge log probe capture limits #5364

merged 2 commits into from
Apr 4, 2024

Conversation

shurivich
Copy link
Contributor

Summary of changes

The log probe capture configuration was previously ignored. This PR fix that issue.
Also, the capture structure has now been consolidated with other libraries.

Reason for change

Acknowledge log probe capture limits.

Implementation details

@shurivich shurivich self-assigned this Mar 28, 2024
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Mar 28, 2024 •
edited
Loading

Datadog Report

Branch report: shurivich/limits
Commit report: 84f72ad
Test service: dd-trace-dotnet

✅ 0 Failed, 329888 Passed, 2078 Skipped, 49m 41.33s Wall Time

@andrewlock
Copy link
Member

andrewlock commented Mar 28, 2024 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (74ms)  : 65, 83
     .   : milestone, 74,
    master - mean (75ms)  : 65, 84
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (991ms)  : 966, 1016
     .   : milestone, 991,
    master - mean (990ms)  : 970, 1011
     .   : milestone, 990,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (110ms)  : 107, 113
     .   : milestone, 110,
    master - mean (110ms)  : 106, 115
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (715ms)  : 689, 742
     .   : milestone, 715,
    master - mean (712ms)  : 687, 738
     .   : milestone, 712,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (93ms)  : 90, 97
     .   : milestone, 93,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (671ms)  : 651, 690
     .   : milestone, 671,
    master - mean (669ms)  : 650, 688
     .   : milestone, 669,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (188ms)  : 183, 192
     .   : milestone, 188,
    master - mean (188ms)  : 185, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (1,078ms)  : 1053, 1104
     .   : milestone, 1078,
    master - mean (1,073ms)  : 1043, 1102
     .   : milestone, 1073,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (270ms)  : 265, 275
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (868ms)  : 837, 898
     .   : milestone, 868,
    master - mean (872ms)  : 838, 906
     .   : milestone, 872,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5364) - mean (260ms)  : 254, 266
     .   : milestone, 260,
    master - mean (260ms)  : 254, 265
     .   : milestone, 260,

    section CallTarget+Inlining+NGEN
    This PR (5364) - mean (852ms)  : 823, 881
     .   : milestone, 852,
    master - mean (853ms)  : 829, 877
     .   : milestone, 853,
Loading

@andrewlock
Copy link
Member

andrewlock commented Mar 28, 2024 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #5364 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.130
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.75μs 47.4ns 264ns 0.0222 0.00889 0 7.51 KB
master StartStopWithChild netcoreapp3.1 10.8μs 58.6ns 316ns 0.0268 0.0107 0 7.6 KB
master StartStopWithChild net472 17μs 78ns 302ns 1.37 0.357 0.0912 8.05 KB
#5364 StartStopWithChild net6.0 8.63μs 47.4ns 284ns 0.0209 0.00834 0 7.5 KB
#5364 StartStopWithChild netcoreapp3.1 10.8μs 51.7ns 207ns 0.0201 0.0101 0 7.61 KB
#5364 StartStopWithChild net472 16.9μs 53.8ns 208ns 1.36 0.346 0.0823 8.05 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 472μs 60.5ns 218ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 614μs 261ns 1.01μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 811μs 327ns 1.27μs 0.403 0 0 3.3 KB
#5364 WriteAndFlushEnrichedTraces net6.0 456μs 437ns 1.69μs 0 0 0 2.7 KB
#5364 WriteAndFlushEnrichedTraces netcoreapp3.1 608μs 186ns 695ns 0 0 0 2.7 KB
#5364 WriteAndFlushEnrichedTraces net472 806μs 463ns 1.79μs 0.403 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 171μs 160ns 620ns 0.171 0 0 18.33 KB
master SendRequest netcoreapp3.1 190μs 362ns 1.4μs 0.189 0 0 20.49 KB
master SendRequest net472 0.00164ns 0.000539ns 0.00209ns 0 0 0 0 b
#5364 SendRequest net6.0 174μs 195ns 754ns 0.262 0 0 18.33 KB
#5364 SendRequest netcoreapp3.1 193μs 271ns 1.05μs 0.193 0 0 20.49 KB
#5364 SendRequest net472 0.000438ns 0.000133ns 0.000498ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5364

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.55 KB 41.77 KB 218 B 0.52%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 530μs 521ns 2.02μs 0.539 0 0 41.55 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 653μs 591ns 2.29μs 0.326 0 0 41.59 KB
master WriteAndFlushEnrichedTraces net472 861μs 2.65μs 9.92μs 8.25 2.6 0.434 53.25 KB
#5364 WriteAndFlushEnrichedTraces net6.0 540μs 577ns 2.24μs 0.546 0 0 41.77 KB
#5364 WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 1.3μs 5.02μs 0.326 0 0 41.74 KB
#5364 WriteAndFlushEnrichedTraces net472 854μs 2.87μs 11.1μs 8.3 2.62 0.437 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.25μs 0.79ns 3.06ns 0.0111 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.59μs 1.98ns 7.65ns 0.0102 0 0 784 B
master ExecuteNonQuery net472 1.84μs 0.943ns 3.53ns 0.118 0 0 746 B
#5364 ExecuteNonQuery net6.0 1.17μs 0.327ns 1.27ns 0.0111 0 0 784 B
#5364 ExecuteNonQuery netcoreapp3.1 1.59μs 0.489ns 1.76ns 0.0103 0 0 784 B
#5364 ExecuteNonQuery net472 1.89μs 1.41ns 5.45ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.31μs 1.22ns 4.56ns 0.0145 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.63μs 0.735ns 2.75ns 0.0134 0 0 1.01 KB
master CallElasticsearch net472 2.51μs 0.969ns 3.63ns 0.161 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.36μs 0.792ns 2.96ns 0.0136 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 1.1ns 3.96ns 0.0139 0 0 1.06 KB
master CallElasticsearchAsync net472 2.72μs 1.31ns 4.9ns 0.17 0 0 1.08 KB
#5364 CallElasticsearch net6.0 1.28μs 1.7ns 6.6ns 0.0139 0 0 1.01 KB
#5364 CallElasticsearch netcoreapp3.1 1.61μs 0.309ns 1.16ns 0.0135 0 0 1.01 KB
#5364 CallElasticsearch net472 2.49μs 1.35ns 5.06ns 0.161 0 0 1.02 KB
#5364 CallElasticsearchAsync net6.0 1.48μs 0.888ns 3.32ns 0.014 0 0 984 B
#5364 CallElasticsearchAsync netcoreapp3.1 1.74μs 0.76ns 2.84ns 0.0146 0 0 1.06 KB
#5364 CallElasticsearchAsync net472 2.68μs 0.863ns 3.11ns 0.171 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.27μs 0.373ns 1.44ns 0.0127 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.65μs 1.83ns 7.08ns 0.0123 0 0 928 B
master ExecuteAsync net472 2μs 1.03ns 3.87ns 0.141 0 0 891 B
#5364 ExecuteAsync net6.0 1.31μs 0.645ns 2.5ns 0.0126 0 0 928 B
#5364 ExecuteAsync netcoreapp3.1 1.65μs 1.46ns 5.67ns 0.0124 0 0 928 B
#5364 ExecuteAsync net472 1.96μs 1.34ns 5.21ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.27μs 2.33ns 9.04ns 0.0299 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.02μs 2.05ns 7.92ns 0.0352 0 0 2.7 KB
master SendAsync net472 7.74μs 4.27ns 16ns 0.481 0.00388 0 3.05 KB
#5364 SendAsync net6.0 4.15μs 3.11ns 11.2ns 0.031 0 0 2.16 KB
#5364 SendAsync netcoreapp3.1 4.97μs 2.96ns 11.1ns 0.035 0 0 2.7 KB
#5364 SendAsync net472 7.74μs 3.72ns 14.4ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.56μs 0.71ns 2.66ns 0.0233 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.42μs 1.11ns 4.01ns 0.0218 0 0 1.65 KB
master EnrichedLog net472 2.66μs 0.502ns 1.81ns 0.249 0 0 1.57 KB
#5364 EnrichedLog net6.0 1.52μs 0.88ns 3.29ns 0.023 0 0 1.65 KB
#5364 EnrichedLog netcoreapp3.1 2.19μs 0.615ns 2.38ns 0.0218 0 0 1.65 KB
#5364 EnrichedLog net472 2.55μs 1.09ns 4.07ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 110μs 96.6ns 361ns 0.0553 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 101ns 376ns 0 0 0 4.23 KB
master EnrichedLog net472 146μs 99.5ns 385ns 0.654 0.218 0 4.41 KB
#5364 EnrichedLog net6.0 112μs 241ns 932ns 0.0555 0 0 4.23 KB
#5364 EnrichedLog netcoreapp3.1 119μs 229ns 859ns 0 0 0 4.23 KB
#5364 EnrichedLog net472 146μs 96.4ns 373ns 0.657 0.219 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.91μs 1.6ns 6.19ns 0.0305 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.24μs 1.74ns 6.51ns 0.03 0 0 2.21 KB
master EnrichedLog net472 4.83μs 7.61ns 29.5ns 0.32 0 0 2.02 KB
#5364 EnrichedLog net6.0 3.06μs 1.03ns 3.98ns 0.0307 0 0 2.21 KB
#5364 EnrichedLog netcoreapp3.1 4.16μs 1.89ns 6.8ns 0.0291 0 0 2.21 KB
#5364 EnrichedLog net472 4.88μs 7.94ns 30.7ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.43μs 1.69ns 6.56ns 0.0164 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.83μs 0.82ns 3.18ns 0.0154 0 0 1.18 KB
master SendReceive net472 2.31μs 2.19ns 8.18ns 0.187 0 0 1.18 KB
#5364 SendReceive net6.0 1.42μs 0.947ns 3.67ns 0.0164 0 0 1.18 KB
#5364 SendReceive netcoreapp3.1 1.73μs 1.96ns 7.57ns 0.0162 0 0 1.18 KB
#5364 SendReceive net472 2.17μs 2.07ns 8.01ns 0.187 0 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.82μs 0.837ns 3.13ns 0.0211 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 4.03μs 1.19ns 4.6ns 0.0222 0 0 1.6 KB
master EnrichedLog net472 4.55μs 1.53ns 5.71ns 0.315 0 0 1.99 KB
#5364 EnrichedLog net6.0 2.71μs 0.894ns 3.35ns 0.0216 0 0 1.55 KB
#5364 EnrichedLog netcoreapp3.1 4.04μs 2.13ns 7.98ns 0.0202 0 0 1.6 KB
#5364 EnrichedLog net472 4.51μs 2.08ns 7.79ns 0.314 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5364

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.130 460.89 520.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 461ns 0.823ns 3.19ns 0.00776 0 0 552 B
master StartFinishSpan netcoreapp3.1 747ns 1.15ns 4.44ns 0.00762 0 0 552 B
master StartFinishSpan net472 721ns 1.03ns 3.98ns 0.0877 0 0 554 B
master StartFinishScope net6.0 615ns 1.02ns 3.82ns 0.00929 0 0 672 B
master StartFinishScope netcoreapp3.1 789ns 0.932ns 3.61ns 0.00903 0 0 672 B
master StartFinishScope net472 1.03μs 2.19ns 8.47ns 0.101 0 0 634 B
#5364 StartFinishSpan net6.0 521ns 0.607ns 2.35ns 0.0078 0 0 552 B
#5364 StartFinishSpan netcoreapp3.1 725ns 1.34ns 5.19ns 0.00733 0 0 552 B
#5364 StartFinishSpan net472 762ns 1.61ns 6.23ns 0.0878 0 0 554 B
#5364 StartFinishScope net6.0 611ns 1.16ns 4.48ns 0.00953 0 0 672 B
#5364 StartFinishScope netcoreapp3.1 865ns 1.4ns 5.41ns 0.00902 0 0 672 B
#5364 StartFinishScope net472 956ns 2.14ns 8.28ns 0.1 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 643ns 0.823ns 3.19ns 0.00956 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 917ns 1.18ns 4.56ns 0.00921 0 0 672 B
master RunOnMethodBegin net472 1.09μs 1.88ns 7.29ns 0.1 0 0 634 B
#5364 RunOnMethodBegin net6.0 629ns 0.947ns 3.67ns 0.0093 0 0 672 B
#5364 RunOnMethodBegin netcoreapp3.1 951ns 2.37ns 9.2ns 0.00886 0 0 672 B
#5364 RunOnMethodBegin net472 1.2μs 1.15ns 4.45ns 0.101 0 0 634 B

@andrewlock
Copy link
Member

andrewlock commented Mar 28, 2024 •
edited
Loading

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5364) (7.737M)   : 0, 7736837
    master (11.713M)   : 0, 11712713
    benchmarks/2.9.0 (11.269M)   : 0, 11269029

    section Automatic
    This PR (5364) (7.801M)   : 0, 7801306
    master (7.970M)   : 0, 7970298
    benchmarks/2.9.0 (8.101M)   : 0, 8100962

    section Trace stats
    This PR (5364) (8.271M)   : 0, 8271438
    master (8.309M)   : 0, 8309370

    section Manual
    This PR (5364) (9.841M)   : 0, 9840910
    master (10.107M)   : 0, 10107374

    section Manual + Automatic
    This PR (5364) (7.354M)   : 0, 7354446
    master (7.592M)   : 0, 7591882

    section Version Conflict
    This PR (5364) (6.643M)   : 0, 6643176
    master (6.799M)   : 0, 6799241
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5364) (9.305M)   : 0, 9304590
    master (9.521M)   : 0, 9520620
    benchmarks/2.9.0 (9.648M)   : 0, 9648037

    section Automatic
    This PR (5364) (6.613M)   : 0, 6613054
    master (6.557M)   : 0, 6557237

    section Trace stats
    This PR (5364) (6.854M)   : 0, 6854428
    master (6.958M)   : 0, 6958067

    section Manual
    This PR (5364) (8.153M)   : 0, 8153046
    master (8.209M)   : 0, 8209424

    section Manual + Automatic
    This PR (5364) (6.107M)   : 0, 6106735
    master (6.187M)   : 0, 6187080

    section Version Conflict
    This PR (5364) (5.649M)   : 0, 5649182
    master (5.613M)   : 0, 5612669
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5364) (8.946M)   : 0, 8945986
    master (8.806M)   : 0, 8806035
    benchmarks/2.9.0 (8.991M)   : 0, 8990879

    section Automatic
    This PR (5364) (6.209M)   : 0, 6209489
    master (6.106M)   : 0, 6106236
    benchmarks/2.9.0 (6.362M)   : 0, 6361714

    section Trace stats
    This PR (5364) (6.476M)   : 0, 6476371
    master (6.459M)   : 0, 6458941

    section Manual
    This PR (5364) (7.510M)   : 0, 7509686
    master (7.422M)   : 0, 7422112

    section Manual + Automatic
    This PR (5364) (5.970M)   : 0, 5970058
    master (5.963M)   : 0, 5962899

    section Version Conflict
    This PR (5364) (5.256M)   : 0, 5255687
    master (5.237M)   : 0, 5237367
Loading

@shurivich shurivich requested review from GreenMatan, dudikeleti and OmerRaviv and removed request for GreenMatan March 28, 2024 10:34
@shurivich shurivich marked this pull request as ready for review March 31, 2024 13:52
@shurivich shurivich requested a review from a team as a code owner March 31, 2024 13:52
dudikeleti
dudikeleti approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@dudikeleti dudikeleti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments.

tracer/src/Datadog.Trace/Debugger/Expressions/ProbeProcessor.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Debugger/Expressions/ProbeInfo.cs Outdated Show resolved Hide resolved
tracer/src/Datadog.Trace/Debugger/ExceptionAutoInstrumentation/TrackedStackFrameNode.cs Outdated Show resolved Hide resolved
@shurivich shurivich force-pushed the shurivich/limits branch 2 times, most recently from 48965c5 to 6583abc Compare April 4, 2024 07:06
@shurivich shurivich merged commit d7b256c into master Apr 4, 2024
59 of 61 checks passed
@shurivich shurivich deleted the shurivich/limits branch April 4, 2024 12:16
@github-actions github-actions bot added this to the vNext-v2 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudikeleti dudikeleti dudikeleti approved these changes

@OmerRaviv OmerRaviv Awaiting requested review from OmerRaviv

Assignees

@shurivich shurivich

Labels
area:debugger
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shurivich @andrewlock @dudikeleti