[Exception Replay] Better communicate non-captured exceptions #5371

GreenMatan · 2024-03-31T12:50:23Z

Summary of changes

In Exception Replay we may fail to capture all the frames of an exception. The reasons vary and could be instrumentation failure (native level), blocklisting, .NET 6+ with non-optimized code, etc - of all the participating frames in the exception stack trace.

To communicate that, a new tag was introduced - _dd.debug.error.<FRAME_NUMBER>.no_capture_reason:<REASON>.
In this PR, I've added this tag for every frame we've failed to capture.

Reason for change

Communicating to the customers why there are no frame data for a given exception.

…play

datadog-ddstaging · 2024-03-31T13:05:04Z

Datadog Report

Branch report: matang/exception-replay/better-handle-not-captured-exceptions
Commit report: 06c8024
Test service: dd-trace-dotnet

✅ 0 Failed, 332313 Passed, 2056 Skipped, 41m 31.49s Wall Time

andrewlock · 2024-03-31T13:13:00Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (74ms)  : 64, 84
     .   : milestone, 74,
    master - mean (75ms)  : 67, 84
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (1,004ms)  : 978, 1030
     .   : milestone, 1004,
    master - mean (1,000ms)  : 979, 1021
     .   : milestone, 1000,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (110ms)  : 107, 112
     .   : milestone, 110,
    master - mean (110ms)  : 107, 114
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (724ms)  : 701, 748
     .   : milestone, 724,
    master - mean (719ms)  : 697, 740
     .   : milestone, 719,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (677ms)  : 654, 700
     .   : milestone, 677,
    master - mean (676ms)  : 654, 698
     .   : milestone, 676,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (187ms)  : 181, 192
     .   : milestone, 187,
    master - mean (188ms)  : 184, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (1,067ms)  : 1040, 1094
     .   : milestone, 1067,
    master - mean (1,076ms)  : 1052, 1101
     .   : milestone, 1076,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (270ms)  : 264, 275
     .   : milestone, 270,
    master - mean (271ms)  : 266, 276
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (867ms)  : 847, 886
     .   : milestone, 867,
    master - mean (874ms)  : 852, 897
     .   : milestone, 874,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5371) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (261ms)  : 256, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5371) - mean (853ms)  : 829, 878
     .   : milestone, 853,
    master - mean (857ms)  : 834, 881
     .   : milestone, 857,

andrewlock · 2024-03-31T13:26:01Z

Benchmarks Report for tracer 🐌

Benchmarks for #5371 compared to master:

1 benchmarks are faster, with geometric mean 1.146
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.7μs	47.5ns	281ns	0.0342	0.0171	0	7.51 KB
master	`StartStopWithChild`	netcoreapp3.1	10.6μs	57.5ns	335ns	0.0203	0.0102	0	7.6 KB
master	`StartStopWithChild`	net472	16.8μs	45.4ns	164ns	1.36	0.343	0.117	8.06 KB
#5371	`StartStopWithChild`	net6.0	8.85μs	49.6ns	325ns	0.0213	0.00854	0	7.5 KB
#5371	`StartStopWithChild`	netcoreapp3.1	10.5μs	56ns	291ns	0.0267	0.0107	0	7.6 KB
#5371	`StartStopWithChild`	net472	17μs	57.9ns	224ns	1.35	0.353	0.121	8.04 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	481μs	192ns	742ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	610μs	139ns	520ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	813μs	347ns	1.3μs	0.406	3.3 KB
#5371	`WriteAndFlushEnrichedTraces`	net6.0	458μs	195ns	757ns	0	2.7 KB
#5371	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	589μs	123ns	461ns	0	2.7 KB
#5371	`WriteAndFlushEnrichedTraces`	net472	822μs	314ns	1.21μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	181ns	700ns	0.191	18.33 KB
master	`SendRequest`	netcoreapp3.1	194μs	247ns	957ns	0.191	20.49 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#5371	`SendRequest`	net6.0	173μs	231ns	864ns	0.172	18.33 KB
#5371	`SendRequest`	netcoreapp3.1	191μs	390ns	1.51μs	0.189	20.49 KB
#5371	`SendRequest`	net472	0.00131ns	0.00034ns	0.00127ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	550μs	332ns	1.24μs	0.566	0	0	41.56 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	1.46μs	5.64μs	0.327	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	net472	884μs	3.56μs	13.3μs	8.42	2.66	0.443	53.23 KB
#5371	`WriteAndFlushEnrichedTraces`	net6.0	556μs	285ns	1.03μs	0.556	0	0	41.47 KB
#5371	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	652μs	1.04μs	4.01μs	0.326	0	0	41.78 KB
#5371	`WriteAndFlushEnrichedTraces`	net472	860μs	3.14μs	12.2μs	8.45	2.53	0.422	53.24 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.13μs	0.293ns	1.1ns	0.0107	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.58μs	3.4ns	12.7ns	0.0102	784 B
master	`ExecuteNonQuery`	net472	1.82μs	1.54ns	5.95ns	0.118	746 B
#5371	`ExecuteNonQuery`	net6.0	1.19μs	0.545ns	2.11ns	0.0109	784 B
#5371	`ExecuteNonQuery`	netcoreapp3.1	1.5μs	0.704ns	2.73ns	0.0103	784 B
#5371	`ExecuteNonQuery`	net472	1.8μs	1.19ns	4.46ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.37μs	1.18ns	4.58ns	0.0138	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.5μs	0.727ns	2.82ns	0.0135	1.01 KB
master	`CallElasticsearch`	net472	2.38μs	2.12ns	7.94ns	0.162	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.29μs	0.602ns	2.33ns	0.0143	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	0.84ns	3.14ns	0.0145	1.06 KB
master	`CallElasticsearchAsync`	net472	2.65μs	1.8ns	6.75ns	0.171	1.08 KB
#5371	`CallElasticsearch`	net6.0	1.36μs	1.32ns	4.96ns	0.0144	1.01 KB
#5371	`CallElasticsearch`	netcoreapp3.1	1.6μs	0.511ns	1.91ns	0.0137	1.01 KB
#5371	`CallElasticsearch`	net472	2.49μs	0.994ns	3.85ns	0.161	1.02 KB
#5371	`CallElasticsearchAsync`	net6.0	1.41μs	0.619ns	2.31ns	0.0134	984 B
#5371	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.765ns	2.76ns	0.0141	1.06 KB
#5371	`CallElasticsearchAsync`	net472	2.62μs	2.33ns	9.04ns	0.171	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.38μs	0.639ns	2.48ns	0.0125	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.522ns	1.88ns	0.0124	928 B
master	`ExecuteAsync`	net472	1.9μs	1.03ns	3.99ns	0.141	891 B
#5371	`ExecuteAsync`	net6.0	1.39μs	1.07ns	4.16ns	0.013	928 B
#5371	`ExecuteAsync`	netcoreapp3.1	1.64μs	0.633ns	2.45ns	0.0123	928 B
#5371	`ExecuteAsync`	net472	1.89μs	0.964ns	3.74ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.17μs	3.72ns	14.4ns	0.0309	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.16μs	7ns	26.2ns	0.0362	2.7 KB
master	`SendAsync`	net472	7.84μs	1.73ns	6.69ns	0.482	3.05 KB
#5371	`SendAsync`	net6.0	4.08μs	2.64ns	10.2ns	0.0287	2.16 KB
#5371	`SendAsync`	netcoreapp3.1	5.09μs	2.48ns	9.59ns	0.0356	2.7 KB
#5371	`SendAsync`	net472	7.69μs	1.43ns	5.15ns	0.481	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.55μs	0.564ns	2.11ns	0.0229	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.27μs	3.22ns	12.1ns	0.0226	1.65 KB
master	`EnrichedLog`	net472	2.58μs	1.7ns	6.12ns	0.249	1.57 KB
#5371	`EnrichedLog`	net6.0	1.42μs	0.378ns	1.42ns	0.0233	1.65 KB
#5371	`EnrichedLog`	netcoreapp3.1	2.3μs	3.15ns	11.8ns	0.0229	1.65 KB
#5371	`EnrichedLog`	net472	2.65μs	1.26ns	4.72ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	80.1ns	310ns	0.0551	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	191ns	740ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	39.3ns	142ns	0.661	0.22	4.41 KB
#5371	`EnrichedLog`	net6.0	113μs	225ns	871ns	0.0562	0	4.23 KB
#5371	`EnrichedLog`	netcoreapp3.1	118μs	139ns	518ns	0.0589	0	4.23 KB
#5371	`EnrichedLog`	net472	146μs	77.6ns	301ns	0.658	0.219	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.17μs	1.23ns	4.77ns	0.0303	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.25μs	1.14ns	4.43ns	0.0298	2.21 KB
master	`EnrichedLog`	net472	4.92μs	3.05ns	11.8ns	0.32	2.02 KB
#5371	`EnrichedLog`	net6.0	3.16μs	1.28ns	4.97ns	0.0305	2.21 KB
#5371	`EnrichedLog`	netcoreapp3.1	4.34μs	2.54ns	9.52ns	0.0301	2.21 KB
#5371	`EnrichedLog`	net472	4.88μs	3.58ns	13.9ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.43μs	1.06ns	3.96ns	0.0165	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.83μs	2.02ns	7.56ns	0.0155	1.18 KB
master	`SendReceive`	net472	2.24μs	2.52ns	9.76ns	0.187	1.18 KB
#5371	`SendReceive`	net6.0	1.45μs	0.458ns	1.72ns	0.016	1.18 KB
#5371	`SendReceive`	netcoreapp3.1	1.85μs	2.59ns	9.68ns	0.0156	1.18 KB
#5371	`SendReceive`	net472	2.38μs	1.73ns	6.49ns	0.187	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.88μs	0.787ns	2.94ns	0.0216	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	4.01μs	2.61ns	10.1ns	0.0221	1.6 KB
master	`EnrichedLog`	net472	4.58μs	2.68ns	10ns	0.314	1.99 KB
#5371	`EnrichedLog`	net6.0	2.88μs	1.19ns	4.63ns	0.0218	1.55 KB
#5371	`EnrichedLog`	netcoreapp3.1	3.91μs	1.31ns	5.08ns	0.0216	1.6 KB
#5371	`EnrichedLog`	net472	4.22μs	2.14ns	8.28ns	0.314	1.99 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5371

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.146	820.15	715.38

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	482ns	0.476ns	1.78ns	0.00766	552 B
master	`StartFinishSpan`	netcoreapp3.1	668ns	1.11ns	4.14ns	0.00761	552 B
master	`StartFinishSpan`	net472	820ns	1.67ns	6.45ns	0.0876	554 B
master	`StartFinishScope`	net6.0	548ns	0.785ns	2.94ns	0.00935	672 B
master	`StartFinishScope`	netcoreapp3.1	810ns	1.14ns	4.42ns	0.00888	672 B
master	`StartFinishScope`	net472	917ns	1.31ns	5.09ns	0.1	634 B
#5371	`StartFinishSpan`	net6.0	503ns	1.06ns	4.11ns	0.00781	552 B
#5371	`StartFinishSpan`	netcoreapp3.1	696ns	1.26ns	4.37ns	0.0075	552 B
#5371	`StartFinishSpan`	net472	716ns	1.25ns	4.83ns	0.0877	554 B
#5371	`StartFinishScope`	net6.0	611ns	1.13ns	4.38ns	0.00934	672 B
#5371	`StartFinishScope`	netcoreapp3.1	780ns	1.47ns	5.7ns	0.00905	672 B
#5371	`StartFinishScope`	net472	936ns	1.05ns	3.78ns	0.101	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	733ns	0.849ns	3.29ns	0.00937	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	961ns	1.35ns	5.04ns	0.00909	672 B
master	`RunOnMethodBegin`	net472	1.05μs	2.21ns	8.57ns	0.101	634 B
#5371	`RunOnMethodBegin`	net6.0	703ns	0.839ns	3.25ns	0.00923	672 B
#5371	`RunOnMethodBegin`	netcoreapp3.1	926ns	1.93ns	7.46ns	0.00882	672 B
#5371	`RunOnMethodBegin`	net472	1.04μs	3.47ns	13.5ns	0.1	634 B

andrewlock · 2024-03-31T13:46:09Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5371) (11.229M)   : 0, 11228937
    master (11.471M)   : 0, 11471077
    benchmarks/2.9.0 (11.411M)   : 0, 11411052

    section Automatic
    This PR (5371) (7.745M)   : 0, 7744836
    master (7.823M)   : 0, 7823378
    benchmarks/2.9.0 (8.041M)   : 0, 8040848

    section Trace stats
    This PR (5371) (8.074M)   : 0, 8073905
    master (8.255M)   : 0, 8255091

    section Manual
    This PR (5371) (9.831M)   : 0, 9831276
    master (10.000M)   : 0, 10000339

    section Manual + Automatic
    This PR (5371) (7.307M)   : 0, 7307043
    master (7.405M)   : 0, 7404644

    section Version Conflict
    This PR (5371) (6.563M)   : 0, 6563106
    master (6.706M)   : 0, 6706148

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5371) (9.485M)   : 0, 9484719
    master (9.678M)   : 0, 9677904
    benchmarks/2.9.0 (9.520M)   : 0, 9520466

    section Automatic
    This PR (5371) (6.663M)   : 0, 6662984
    master (6.483M)   : 0, 6482979

    section Trace stats
    This PR (5371) (6.946M)   : 0, 6945868
    master (6.909M)   : 0, 6909139

    section Manual
    This PR (5371) (8.325M)   : 0, 8325088
    master (8.108M)   : 0, 8108233

    section Manual + Automatic
    This PR (5371) (6.200M)   : 0, 6199922
    master (6.175M)   : 0, 6174670

    section Version Conflict
    This PR (5371) (5.739M)   : 0, 5738888
    master (5.672M)   : 0, 5671735

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5371) (8.829M)   : 0, 8828999
    master (8.644M)   : 0, 8644154
    benchmarks/2.9.0 (8.821M)   : 0, 8820751

    section Automatic
    This PR (5371) (6.133M)   : 0, 6132920
    master (6.087M)   : 0, 6086915
    benchmarks/2.9.0 (6.263M)   : 0, 6262588

    section Trace stats
    This PR (5371) (6.388M)   : 0, 6388252
    master (6.279M)   : 0, 6278610

    section Manual
    This PR (5371) (7.735M)   : 0, 7734790
    master (7.480M)   : 0, 7480304

    section Manual + Automatic
    This PR (5371) (5.787M)   : 0, 5787372
    master (5.849M)   : 0, 5849378

    section Version Conflict
    This PR (5371) (5.282M)   : 0, 5282361
    master (5.225M)   : 0, 5224862

shurivich

Looks good

Better handling exceptions that could not be captured by Exception Re…

06c8024

…play

GreenMatan requested a review from a team as a code owner March 31, 2024 12:50

GreenMatan changed the title ~~[Exception Replay] Better communicate exceptions that we fail to capture any frame~~ [Exception Replay] Better communicate exceptions where we fail to capture any frame Mar 31, 2024

github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Mar 31, 2024

GreenMatan changed the title ~~[Exception Replay] Better communicate exceptions where we fail to capture any frame~~ [Exception Replay] Better communicate non-captured exceptions Mar 31, 2024

shurivich approved these changes Apr 1, 2024

View reviewed changes

GreenMatan merged commit 11b58cc into master Apr 1, 2024
61 checks passed

GreenMatan deleted the matang/exception-replay/better-handle-not-captured-exceptions branch April 1, 2024 08:18

github-actions bot added this to the vNext milestone Apr 1, 2024

GreenMatan mentioned this pull request Apr 3, 2024

[Exception Replay] Enhanced the reporting of non-captured exceptions #5391

Merged

andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Exception Replay] Better communicate non-captured exceptions #5371

[Exception Replay] Better communicate non-captured exceptions #5371

GreenMatan commented Mar 31, 2024 •

edited

Loading

datadog-ddstaging bot commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024

andrewlock commented Mar 31, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5371

Raw results

Raw results

andrewlock commented Mar 31, 2024

shurivich left a comment

[Exception Replay] Better communicate non-captured exceptions #5371

[Exception Replay] Better communicate non-captured exceptions #5371

Conversation

GreenMatan commented Mar 31, 2024 • edited Loading

Summary of changes

Reason for change

datadog-ddstaging bot commented Mar 31, 2024 • edited Loading

Datadog Report

andrewlock commented Mar 31, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Mar 31, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5371

Raw results

Raw results

andrewlock commented Mar 31, 2024

Throughput/Crank Report:zap:

shurivich left a comment

Choose a reason for hiding this comment

GreenMatan commented Mar 31, 2024 •

edited

Loading

datadog-ddstaging bot commented Mar 31, 2024 •

edited

Loading