[Dynamic Instrumentation] Added emitting status for probes #5372

GreenMatan · 2024-03-31T13:17:29Z

Summary of changes

Added new EMITTING status for probes to indicate they are sending data.

The new EMITTING status supports all probe types except Span probes - a change needs to be done in the native instrumentation to support this. The signature of the SpanDebuggerInvoker's BeginSpan/EndSpan methods needs to be changed to accept the probe index to be able to retrieve it's ProbeInfo efficiently. The ProbeInfo is the carrier of the emitting state for caching purposes.

Reason for change

Indicate that a probe is emitting data and not merely installed.

Implementation details

When a probe sends data (determined by hooking into the code locations where data is emitted for the three probe types presented below), a flag is marked to indicate that the probe is emitting data and the ProbeStatusPoller is notified accordingly.

Log Probes: when snapshot is sent
Metric Probes: when the metric is uploaded to statsd
Span Decoration Probes: when there is any tag attached to a span.

Test coverage

All the integrations tests cover this change, with their probe statuses approvals.

datadog-ddstaging · 2024-03-31T13:50:36Z

Datadog Report

Branch report: matang/add-emitting-status
Commit report: 6ead506
Test service: dd-trace-dotnet

✅ 0 Failed, 332137 Passed, 2087 Skipped, 40m 22.47s Wall Time

andrewlock · 2024-03-31T13:58:23Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (74ms)  : 66, 81
     .   : milestone, 74,
    master - mean (75ms)  : 65, 84
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (997ms)  : 970, 1024
     .   : milestone, 997,
    master - mean (1,004ms)  : 979, 1029
     .   : milestone, 1004,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (113ms)  : 108, 118
     .   : milestone, 113,
    master - mean (111ms)  : 107, 115
     .   : milestone, 111,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (715ms)  : 688, 741
     .   : milestone, 715,
    master - mean (723ms)  : 698, 747
     .   : milestone, 723,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (95ms)  : 91, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (670ms)  : 643, 697
     .   : milestone, 670,
    master - mean (676ms)  : 657, 695
     .   : milestone, 676,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (188ms)  : 185, 191
     .   : milestone, 188,
    master - mean (188ms)  : 185, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (1,080ms)  : 1058, 1102
     .   : milestone, 1080,
    master - mean (1,081ms)  : 1059, 1104
     .   : milestone, 1081,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (272ms)  : 269, 276
     .   : milestone, 272,
    master - mean (272ms)  : 268, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (873ms)  : 853, 892
     .   : milestone, 873,
    master - mean (875ms)  : 852, 899
     .   : milestone, 875,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5372) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (262ms)  : 257, 267
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (5372) - mean (858ms)  : 830, 886
     .   : milestone, 858,
    master - mean (862ms)  : 840, 885
     .   : milestone, 862,

andrewlock · 2024-03-31T14:10:29Z

Benchmarks Report for tracer 🐌

Benchmarks for #5372 compared to master:

3 benchmarks are faster, with geometric mean 1.194
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.9μs	49.2ns	291ns	0.022	0.0088	0	7.5 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	55ns	252ns	0.0373	0.0213	0.00533	7.59 KB
master	`StartStopWithChild`	net472	16.9μs	52.5ns	196ns	1.35	0.357	0.116	8.04 KB
#5372	`StartStopWithChild`	net6.0	8.79μs	38.7ns	145ns	0.0249	0.0124	0	7.5 KB
#5372	`StartStopWithChild`	netcoreapp3.1	10.7μs	59.4ns	346ns	0.0261	0.0105	0	7.6 KB
#5372	`StartStopWithChild`	net472	16.9μs	50ns	194ns	1.36	0.335	0.114	8.04 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	483μs	547ns	2.12μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	606μs	323ns	1.25μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	820μs	234ns	877ns	0.411	3.3 KB
#5372	`WriteAndFlushEnrichedTraces`	net6.0	456μs	381ns	1.48μs	0	2.7 KB
#5372	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	606μs	160ns	599ns	0	2.7 KB
#5372	`WriteAndFlushEnrichedTraces`	net472	817μs	246ns	919ns	0.403	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	170ns	658ns	0.26	18.33 KB
master	`SendRequest`	netcoreapp3.1	194μs	249ns	964ns	0.193	20.49 KB
master	`SendRequest`	net472	0.000266ns	0.000143ns	0.000535ns	0	0 b
#5372	`SendRequest`	net6.0	175μs	196ns	759ns	0.26	18.33 KB
#5372	`SendRequest`	netcoreapp3.1	192μs	397ns	1.54μs	0.191	20.49 KB
#5372	`SendRequest`	net472	0.00148ns	0.000399ns	0.00155ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5372

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.54 KB	41.79 KB	241 B	0.58%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	550μs	640ns	2.22μs	0.563	0	0	41.54 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	663μs	2.34μs	9.05μs	0.327	0	0	41.61 KB
master	`WriteAndFlushEnrichedTraces`	net472	878μs	3.69μs	13.3μs	8.25	2.6	0.434	53.26 KB
#5372	`WriteAndFlushEnrichedTraces`	net6.0	548μs	988ns	3.83μs	0.543	0	0	41.79 KB
#5372	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	1.79μs	6.94μs	0.331	0	0	41.63 KB
#5372	`WriteAndFlushEnrichedTraces`	net472	878μs	2.87μs	11.1μs	8.25	2.6	0.434	53.22 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.11μs	0.528ns	1.91ns	0.0111	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.52μs	0.429ns	1.49ns	0.0105	784 B
master	`ExecuteNonQuery`	net472	1.81μs	0.473ns	1.77ns	0.118	746 B
#5372	`ExecuteNonQuery`	net6.0	1.13μs	0.944ns	3.66ns	0.0107	784 B
#5372	`ExecuteNonQuery`	netcoreapp3.1	1.59μs	0.832ns	3.11ns	0.0103	784 B
#5372	`ExecuteNonQuery`	net472	1.78μs	0.812ns	3.14ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.37μs	1.79ns	6.69ns	0.0137	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	2.75ns	10.3ns	0.014	1.01 KB
master	`CallElasticsearch`	net472	2.39μs	0.879ns	3.29ns	0.162	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.37μs	0.953ns	3.57ns	0.0137	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.965ns	3.74ns	0.014	1.06 KB
master	`CallElasticsearchAsync`	net472	2.69μs	2.35ns	9.08ns	0.17	1.08 KB
#5372	`CallElasticsearch`	net6.0	1.35μs	0.894ns	3.35ns	0.0142	1.01 KB
#5372	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.601ns	2.08ns	0.0136	1.01 KB
#5372	`CallElasticsearch`	net472	2.63μs	0.727ns	2.62ns	0.161	1.02 KB
#5372	`CallElasticsearchAsync`	net6.0	1.47μs	0.87ns	3.26ns	0.014	984 B
#5372	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	0.391ns	1.41ns	0.0141	1.06 KB
#5372	`CallElasticsearchAsync`	net472	2.59μs	1.31ns	5.07ns	0.171	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.36μs	0.623ns	2.41ns	0.0129	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.877ns	3.28ns	0.0127	928 B
master	`ExecuteAsync`	net472	2.03μs	0.82ns	3.18ns	0.141	891 B
#5372	`ExecuteAsync`	net6.0	1.38μs	0.717ns	2.68ns	0.0132	928 B
#5372	`ExecuteAsync`	netcoreapp3.1	1.71μs	0.441ns	1.59ns	0.012	928 B
#5372	`ExecuteAsync`	net472	1.95μs	0.524ns	2.03ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.14μs	1.06ns	3.98ns	0.029	2.16 KB
master	`SendAsync`	netcoreapp3.1	5.21μs	1.79ns	6.44ns	0.0364	2.7 KB
master	`SendAsync`	net472	7.88μs	2.92ns	10.9ns	0.484	3.05 KB
#5372	`SendAsync`	net6.0	4.24μs	1.99ns	7.45ns	0.0297	2.16 KB
#5372	`SendAsync`	netcoreapp3.1	5.04μs	1.59ns	5.96ns	0.0354	2.7 KB
#5372	`SendAsync`	net472	7.69μs	2.8ns	10.5ns	0.481	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.44μs	0.794ns	3.07ns	0.0231	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.823ns	3.08ns	0.0226	1.65 KB
master	`EnrichedLog`	net472	2.71μs	1.9ns	7.38ns	0.25	1.57 KB
#5372	`EnrichedLog`	net6.0	1.5μs	0.606ns	2.27ns	0.023	1.65 KB
#5372	`EnrichedLog`	netcoreapp3.1	2.12μs	0.47ns	1.76ns	0.0223	1.65 KB
#5372	`EnrichedLog`	net472	2.73μs	2.57ns	9.6ns	0.25	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	35.1ns	136ns	0	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	135ns	503ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	113ns	436ns	0.659	0.22	4.41 KB
#5372	`EnrichedLog`	net6.0	112μs	48.1ns	186ns	0.0558	0	4.23 KB
#5372	`EnrichedLog`	netcoreapp3.1	120μs	225ns	871ns	0	0	4.23 KB
#5372	`EnrichedLog`	net472	146μs	70.6ns	273ns	0.657	0.219	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.07μs	1.44ns	5.56ns	0.0307	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.23μs	1.73ns	6.72ns	0.0296	2.21 KB
master	`EnrichedLog`	net472	5.02μs	2.02ns	7.84ns	0.321	2.02 KB
#5372	`EnrichedLog`	net6.0	3.02μs	1.05ns	3.8ns	0.03	2.21 KB
#5372	`EnrichedLog`	netcoreapp3.1	4.22μs	1.93ns	7.22ns	0.0295	2.21 KB
#5372	`EnrichedLog`	net472	4.94μs	1.74ns	6.27ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.5μs	0.596ns	2.23ns	0.0164	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	1.67ns	6.26ns	0.0161	1.18 KB
master	`SendReceive`	net472	2.28μs	1.64ns	6.14ns	0.187	1.18 KB
#5372	`SendReceive`	net6.0	1.46μs	0.767ns	2.87ns	0.0161	1.18 KB
#5372	`SendReceive`	netcoreapp3.1	1.89μs	1.08ns	3.89ns	0.0161	1.18 KB
#5372	`SendReceive`	net472	2.23μs	2.6ns	10.1ns	0.186	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.67μs	0.828ns	3.1ns	0.0213	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	1.41ns	5.07ns	0.02	1.6 KB
master	`EnrichedLog`	net472	4.35μs	2.05ns	7.67ns	0.316	1.99 KB
#5372	`EnrichedLog`	net6.0	2.71μs	0.554ns	1.92ns	0.0214	1.55 KB
#5372	`EnrichedLog`	netcoreapp3.1	4μs	1.13ns	4.22ns	0.0201	1.6 KB
#5372	`EnrichedLog`	net472	4.38μs	1.9ns	7.11ns	0.316	1.99 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5372

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.232	561.97	456.12
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.185	626.71	528.92

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	562ns	1.54ns	5.96ns	0.00762	552 B
master	`StartFinishSpan`	netcoreapp3.1	777ns	2.36ns	9.13ns	0.00762	552 B
master	`StartFinishSpan`	net472	760ns	1.73ns	6.7ns	0.0878	554 B
master	`StartFinishScope`	net6.0	626ns	1.34ns	5.2ns	0.00931	672 B
master	`StartFinishScope`	netcoreapp3.1	903ns	1.49ns	5.78ns	0.009	672 B
master	`StartFinishScope`	net472	929ns	1.58ns	6.13ns	0.1	634 B
#5372	`StartFinishSpan`	net6.0	457ns	1.19ns	4.45ns	0.00771	552 B
#5372	`StartFinishSpan`	netcoreapp3.1	760ns	2.02ns	7.8ns	0.00743	552 B
#5372	`StartFinishSpan`	net472	771ns	1.6ns	6.18ns	0.0877	554 B
#5372	`StartFinishScope`	net6.0	528ns	1.22ns	4.56ns	0.00934	672 B
#5372	`StartFinishScope`	netcoreapp3.1	907ns	2.24ns	8.68ns	0.00916	672 B
#5372	`StartFinishScope`	net472	993ns	1.95ns	7.56ns	0.101	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5372

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.165	722.93	620.68

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	722ns	1.64ns	6.33ns	0.0094	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	865ns	2.46ns	9.52ns	0.009	672 B
master	`RunOnMethodBegin`	net472	1.08μs	1.61ns	6.01ns	0.1	634 B
#5372	`RunOnMethodBegin`	net6.0	621ns	1.13ns	4.37ns	0.00951	672 B
#5372	`RunOnMethodBegin`	netcoreapp3.1	890ns	1.15ns	4.45ns	0.00877	672 B
#5372	`RunOnMethodBegin`	net472	1.12μs	2.56ns	9.9ns	0.101	634 B

andrewlock · 2024-03-31T14:31:20Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5372) (11.350M)   : 0, 11349731
    master (11.713M)   : 0, 11712713
    benchmarks/2.9.0 (11.269M)   : 0, 11269029

    section Automatic
    This PR (5372) (7.871M)   : 0, 7870992
    master (7.970M)   : 0, 7970298
    benchmarks/2.9.0 (8.101M)   : 0, 8100962

    section Trace stats
    This PR (5372) (8.149M)   : 0, 8149305
    master (8.309M)   : 0, 8309370

    section Manual
    This PR (5372) (10.035M)   : 0, 10035336
    master (10.107M)   : 0, 10107374

    section Manual + Automatic
    This PR (5372) (7.496M)   : 0, 7495886
    master (7.592M)   : 0, 7591882

    section Version Conflict
    This PR (5372) (6.725M)   : 0, 6724587
    master (6.799M)   : 0, 6799241

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5372) (9.333M)   : 0, 9333435
    master (9.521M)   : 0, 9520620
    benchmarks/2.9.0 (9.648M)   : 0, 9648037

    section Automatic
    This PR (5372) (6.574M)   : 0, 6573989
    master (6.557M)   : 0, 6557237

    section Trace stats
    This PR (5372) (6.759M)   : 0, 6759116
    master (6.958M)   : 0, 6958067

    section Manual
    This PR (5372) (8.230M)   : 0, 8229554
    master (8.209M)   : 0, 8209424

    section Manual + Automatic
    This PR (5372) (6.112M)   : 0, 6111849
    master (6.187M)   : 0, 6187080

    section Version Conflict
    This PR (5372) (5.595M)   : 0, 5594563
    master (5.613M)   : 0, 5612669

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5372) (8.636M)   : 0, 8635618
    master (8.806M)   : 0, 8806035
    benchmarks/2.9.0 (8.991M)   : 0, 8990879

    section Automatic
    This PR (5372) (6.162M)   : 0, 6162346
    master (6.106M)   : 0, 6106236
    benchmarks/2.9.0 (6.362M)   : 0, 6361714

    section Trace stats
    This PR (5372) (6.357M)   : 0, 6357118
    master (6.459M)   : 0, 6458941

    section Manual
    This PR (5372) (7.729M)   : 0, 7729207
    master (7.422M)   : 0, 7422112

    section Manual + Automatic
    This PR (5372) (5.988M)   : 0, 5988469
    master (5.963M)   : 0, 5962899

    section Version Conflict
    This PR (5372) (5.433M)   : 0, 5433296
    master (5.237M)   : 0, 5237367

GreenMatan force-pushed the matang/add-emitting-status branch from 67d9b86 to f46c862 Compare March 31, 2024 13:34

GreenMatan marked this pull request as ready for review March 31, 2024 13:34

GreenMatan requested a review from a team as a code owner March 31, 2024 13:34

GreenMatan changed the title ~~[Dynamic Instrumentation] Adding EMITTING instrumentation status~~ [Dynamic Instrumentation] Added EMITTING probe status Mar 31, 2024

github-actions bot added the area:debugger label Mar 31, 2024

GreenMatan force-pushed the matang/add-emitting-status branch from f46c862 to 8fcf8c5 Compare March 31, 2024 13:34

GreenMatan changed the title ~~[Dynamic Instrumentation] Added EMITTING probe status~~ [Dynamic Instrumentation] Added emitting status for probes Mar 31, 2024

GreenMatan force-pushed the matang/add-emitting-status branch 3 times, most recently from a96aaa0 to 8904439 Compare April 1, 2024 21:39

GreenMatan requested a review from dudikeleti April 1, 2024 21:48

GreenMatan force-pushed the matang/add-emitting-status branch 5 times, most recently from bbb01f5 to 210121a Compare April 3, 2024 12:31

GreenMatan added 2 commits April 3, 2024 17:02

Added EMITTING Probe Status

94ca4fb

Approved statuses with new EMITTING status

6ead506

GreenMatan force-pushed the matang/add-emitting-status branch from 210121a to 6ead506 Compare April 3, 2024 14:02

dudikeleti approved these changes Apr 3, 2024

View reviewed changes

GreenMatan merged commit 48bda30 into master Apr 3, 2024
58 of 61 checks passed

GreenMatan deleted the matang/add-emitting-status branch April 3, 2024 16:53

github-actions bot added this to the vNext-v2 milestone Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dynamic Instrumentation] Added emitting status for probes #5372

[Dynamic Instrumentation] Added emitting status for probes #5372

GreenMatan commented Mar 31, 2024 •

edited

Loading

datadog-ddstaging bot commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024 •

edited

Loading

Raw results

Raw results

Raw results

More allocations ⚠️ in #5372

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5372

Raw results

Faster 🎉 in #5372

Raw results

andrewlock commented Mar 31, 2024 •

edited

Loading

[Dynamic Instrumentation] Added emitting status for probes #5372

[Dynamic Instrumentation] Added emitting status for probes #5372

Conversation

GreenMatan commented Mar 31, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

datadog-ddstaging bot commented Mar 31, 2024 • edited Loading

Datadog Report

andrewlock commented Mar 31, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

andrewlock commented Mar 31, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5372

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5372

Raw results

Faster 🎉 in #5372

Raw results

andrewlock commented Mar 31, 2024 • edited Loading

Throughput/Crank Report:zap:

GreenMatan commented Mar 31, 2024 •

edited

Loading

datadog-ddstaging bot commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024 •

edited

Loading

andrewlock commented Mar 31, 2024 •

edited

Loading