Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fix macos unit test crash #5384

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Try fix macos unit test crash #5384

merged 1 commit into from
Apr 3, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Avoid tests belonging to multiple [Collection]s

Reason for change

We started seeing the crashes after this PR:

So suspect it was the issue. According to xunit/xunit#2497:

Collections are a parallelization and context-sharing boundary. They aren't meant to be used this way.

so probably shouldn't do that

Implementation details

Remove the duplicate Collection attribute by removing from the child and moving it to the base. The [SecuritySequentialTests] collection already disables serialization

Test coverage

🤞

Other details

@andrewlock andrewlock added the area:tests unit tests, integration tests label Apr 2, 2024
@andrewlock andrewlock requested a review from a team as a code owner April 2, 2024 15:12
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Apr 2, 2024 •
edited
Loading

Datadog Report

Branch report: andrew/ci/try-different-macos-approach
Commit report: 9934dd7
Test service: dd-trace-dotnet

✅ 0 Failed, 328209 Passed, 1602 Skipped, 53m 18.34s Wall Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (76ms)  : 67, 84
     .   : milestone, 76,
    master - mean (75ms)  : 65, 85
     .   : milestone, 75,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (1,009ms)  : 988, 1030
     .   : milestone, 1009,
    master - mean (1,005ms)  : 979, 1030
     .   : milestone, 1005,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (112ms)  : 108, 115
     .   : milestone, 112,
    master - mean (110ms)  : 107, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (728ms)  : 705, 751
     .   : milestone, 728,
    master - mean (720ms)  : 698, 742
     .   : milestone, 720,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (95ms)  : 92, 99
     .   : milestone, 95,
    master - mean (95ms)  : 90, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (681ms)  : 660, 702
     .   : milestone, 681,
    master - mean (678ms)  : 652, 704
     .   : milestone, 678,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (188ms)  : 185, 192
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (1,084ms)  : 1060, 1107
     .   : milestone, 1084,
    master - mean (1,077ms)  : 1050, 1104
     .   : milestone, 1077,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (273ms)  : 268, 278
     .   : milestone, 273,
    master - mean (272ms)  : 266, 279
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (876ms)  : 848, 904
     .   : milestone, 876,
    master - mean (882ms)  : 849, 916
     .   : milestone, 882,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5384) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (261ms)  : 257, 265
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5384) - mean (860ms)  : 829, 890
     .   : milestone, 860,
    master - mean (856ms)  : 834, 878
     .   : milestone, 856,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5384 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.139
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.74μs 48.6ns 315ns 0.0211 0.00846 0 7.5 KB
master StartStopWithChild netcoreapp3.1 10.5μs 58.2ns 363ns 0.0257 0.0103 0 7.6 KB
master StartStopWithChild net472 16.9μs 40.9ns 158ns 1.35 0.351 0.117 8.05 KB
#5384 StartStopWithChild net6.0 8.67μs 49.3ns 342ns 0.0177 0.00884 0 7.51 KB
#5384 StartStopWithChild netcoreapp3.1 10.7μs 54.8ns 263ns 0.027 0.0108 0 7.59 KB
#5384 StartStopWithChild net472 17.1μs 47.6ns 184ns 1.34 0.329 0.101 8.03 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 475μs 140ns 524ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 600μs 191ns 716ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 818μs 232ns 900ns 0.408 0 0 3.3 KB
#5384 WriteAndFlushEnrichedTraces net6.0 463μs 498ns 1.86μs 0 0 0 2.7 KB
#5384 WriteAndFlushEnrichedTraces netcoreapp3.1 610μs 363ns 1.36μs 0 0 0 2.7 KB
#5384 WriteAndFlushEnrichedTraces net472 820μs 266ns 1.03μs 0.408 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 172μs 150ns 580ns 0.257 0 0 18.33 KB
master SendRequest netcoreapp3.1 193μs 294ns 1.14μs 0.191 0 0 20.49 KB
master SendRequest net472 0.000103ns 7.47E‑05ns 0.00028ns 0 0 0 0 b
#5384 SendRequest net6.0 174μs 152ns 590ns 0.175 0 0 18.33 KB
#5384 SendRequest netcoreapp3.1 194μs 387ns 1.5μs 0.193 0 0 20.49 KB
#5384 SendRequest net472 0.00186ns 0.000425ns 0.00159ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 551μs 445ns 1.73μs 0.563 0 0 41.67 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 633μs 2.41μs 9.34μs 0.314 0 0 41.67 KB
master WriteAndFlushEnrichedTraces net472 868μs 3.75μs 14.5μs 8.08 2.55 0.425 53.25 KB
#5384 WriteAndFlushEnrichedTraces net6.0 556μs 2.87μs 13.2μs 0.539 0 0 41.58 KB
#5384 WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 747ns 2.89μs 0.332 0 0 41.79 KB
#5384 WriteAndFlushEnrichedTraces net472 859μs 3.38μs 13.1μs 8.45 2.53 0.422 53.25 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.21μs 0.81ns 3.14ns 0.0109 0 0 784 B
master ExecuteNonQuery netcoreapp3.1 1.53μs 2.36ns 9.16ns 0.0106 0 0 784 B
master ExecuteNonQuery net472 1.8μs 0.78ns 2.92ns 0.118 0 0 746 B
#5384 ExecuteNonQuery net6.0 1.14μs 0.703ns 2.72ns 0.0109 0 0 784 B
#5384 ExecuteNonQuery netcoreapp3.1 1.49μs 1.25ns 4.84ns 0.0103 0 0 784 B
#5384 ExecuteNonQuery net472 1.86μs 0.87ns 3.37ns 0.118 0 0 746 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.33μs 0.504ns 1.75ns 0.014 0 0 1.01 KB
master CallElasticsearch netcoreapp3.1 1.6μs 1.05ns 3.92ns 0.0137 0 0 1.01 KB
master CallElasticsearch net472 2.51μs 1.76ns 6.81ns 0.162 0 0 1.02 KB
master CallElasticsearchAsync net6.0 1.34μs 3.64ns 14.1ns 0.014 0 0 984 B
master CallElasticsearchAsync netcoreapp3.1 1.73μs 0.781ns 2.82ns 0.0147 0 0 1.06 KB
master CallElasticsearchAsync net472 2.61μs 2.03ns 7.86ns 0.17 0 0 1.08 KB
#5384 CallElasticsearch net6.0 1.34μs 0.976ns 3.65ns 0.014 0 0 1.01 KB
#5384 CallElasticsearch netcoreapp3.1 1.62μs 1.94ns 7.24ns 0.0138 0 0 1.01 KB
#5384 CallElasticsearch net472 2.53μs 0.743ns 2.78ns 0.161 0 0 1.02 KB
#5384 CallElasticsearchAsync net6.0 1.42μs 0.608ns 2.27ns 0.0141 0 0 984 B
#5384 CallElasticsearchAsync netcoreapp3.1 1.74μs 0.729ns 2.73ns 0.0137 0 0 1.06 KB
#5384 CallElasticsearchAsync net472 2.63μs 1.56ns 5.83ns 0.17 0 0 1.08 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.4μs 0.62ns 2.4ns 0.0134 0 0 928 B
master ExecuteAsync netcoreapp3.1 1.74μs 0.857ns 3.32ns 0.0121 0 0 928 B
master ExecuteAsync net472 1.95μs 1.08ns 4.02ns 0.141 0 0 891 B
#5384 ExecuteAsync net6.0 1.46μs 0.605ns 2.34ns 0.0132 0 0 928 B
#5384 ExecuteAsync netcoreapp3.1 1.66μs 1.26ns 4.72ns 0.0127 0 0 928 B
#5384 ExecuteAsync net472 1.91μs 2.28ns 8.21ns 0.141 0 0 891 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.19μs 1.8ns 6.73ns 0.0293 0 0 2.16 KB
master SendAsync netcoreapp3.1 5.09μs 1.39ns 5.21ns 0.0356 0 0 2.7 KB
master SendAsync net472 7.71μs 2.58ns 10ns 0.483 0 0 3.05 KB
#5384 SendAsync net6.0 4.19μs 1.25ns 4.67ns 0.0295 0 0 2.16 KB
#5384 SendAsync netcoreapp3.1 4.96μs 3.03ns 11.7ns 0.0372 0 0 2.7 KB
#5384 SendAsync net472 7.72μs 2.21ns 7.67ns 0.482 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.6μs 0.497ns 1.86ns 0.0231 0 0 1.65 KB
master EnrichedLog netcoreapp3.1 2.24μs 1.85ns 6.39ns 0.0225 0 0 1.65 KB
master EnrichedLog net472 2.72μs 1.2ns 4.48ns 0.249 0 0 1.57 KB
#5384 EnrichedLog net6.0 1.49μs 0.822ns 3.18ns 0.0232 0 0 1.65 KB
#5384 EnrichedLog netcoreapp3.1 2.18μs 0.968ns 3.62ns 0.0227 0 0 1.65 KB
#5384 EnrichedLog net472 2.65μs 2.01ns 7.77ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 65.3ns 253ns 0.0559 0 0 4.23 KB
master EnrichedLog netcoreapp3.1 118μs 110ns 413ns 0 0 0 4.23 KB
master EnrichedLog net472 146μs 58.7ns 220ns 0.657 0.219 0 4.41 KB
#5384 EnrichedLog net6.0 111μs 89.3ns 346ns 0.055 0 0 4.23 KB
#5384 EnrichedLog netcoreapp3.1 117μs 135ns 504ns 0 0 0 4.23 KB
#5384 EnrichedLog net472 146μs 58ns 209ns 0.656 0.219 0 4.41 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.18μs 8.4ns 32.6ns 0.0299 0 0 2.21 KB
master EnrichedLog netcoreapp3.1 4.22μs 2.59ns 10ns 0.0295 0 0 2.21 KB
master EnrichedLog net472 4.99μs 2.31ns 8.66ns 0.32 0 0 2.02 KB
#5384 EnrichedLog net6.0 3.06μs 1.1ns 4.1ns 0.0308 0 0 2.21 KB
#5384 EnrichedLog netcoreapp3.1 4.14μs 1.49ns 5.58ns 0.0289 0 0 2.21 KB
#5384 EnrichedLog net472 4.95μs 1ns 3.88ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.4μs 1.35ns 5.06ns 0.0162 0 0 1.18 KB
master SendReceive netcoreapp3.1 1.82μs 1.84ns 6.9ns 0.0154 0 0 1.18 KB
master SendReceive net472 2.27μs 2.9ns 11.2ns 0.187 0.00112 0 1.18 KB
#5384 SendReceive net6.0 1.54μs 0.6ns 2.32ns 0.016 0 0 1.18 KB
#5384 SendReceive netcoreapp3.1 1.9μs 1.13ns 4.39ns 0.0161 0 0 1.18 KB
#5384 SendReceive net472 2.24μs 1.18ns 4.56ns 0.187 0.00111 0 1.18 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 0.614ns 2.3ns 0.0221 0 0 1.55 KB
master EnrichedLog netcoreapp3.1 3.98μs 1.41ns 5.46ns 0.0219 0 0 1.6 KB
master EnrichedLog net472 4.52μs 3.24ns 12.5ns 0.315 0 0 1.99 KB
#5384 EnrichedLog net6.0 2.75μs 0.802ns 3ns 0.0206 0 0 1.55 KB
#5384 EnrichedLog netcoreapp3.1 3.98μs 1.97ns 7.1ns 0.0219 0 0 1.6 KB
#5384 EnrichedLog net472 4.41μs 2.09ns 7.83ns 0.315 0 0 1.99 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5384

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.139 1,053.55 924.70

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 477ns 0.952ns 3.69ns 0.00779 0 0 552 B
master StartFinishSpan netcoreapp3.1 696ns 1.36ns 5.25ns 0.00753 0 0 552 B
master StartFinishSpan net472 766ns 1.12ns 4.33ns 0.0877 0 0 554 B
master StartFinishScope net6.0 680ns 1.02ns 3.95ns 0.00946 0 0 672 B
master StartFinishScope netcoreapp3.1 850ns 1.39ns 5.39ns 0.00888 0 0 672 B
master StartFinishScope net472 1.05μs 2.41ns 9.35ns 0.101 0 0 634 B
#5384 StartFinishSpan net6.0 480ns 0.81ns 3.14ns 0.00768 0 0 552 B
#5384 StartFinishSpan netcoreapp3.1 687ns 0.984ns 3.68ns 0.00744 0 0 552 B
#5384 StartFinishSpan net472 757ns 1.65ns 6.4ns 0.088 0 0 554 B
#5384 StartFinishScope net6.0 682ns 0.878ns 3.4ns 0.00948 0 0 672 B
#5384 StartFinishScope netcoreapp3.1 819ns 1.21ns 4.37ns 0.00905 0 0 672 B
#5384 StartFinishScope net472 923ns 1.97ns 7.63ns 0.101 0 0 634 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 641ns 1.4ns 5.41ns 0.00933 0 0 672 B
master RunOnMethodBegin netcoreapp3.1 982ns 1.92ns 7.42ns 0.00887 0 0 672 B
master RunOnMethodBegin net472 1.11μs 2.85ns 11ns 0.1 0 0 634 B
#5384 RunOnMethodBegin net6.0 658ns 1.18ns 4.57ns 0.0096 0 0 672 B
#5384 RunOnMethodBegin netcoreapp3.1 1.03μs 1.57ns 6.07ns 0.00901 0 0 672 B
#5384 RunOnMethodBegin net472 1.14μs 2.05ns 7.93ns 0.1 0 0 634 B

@andrewlock
Copy link
Member Author

Benchmarks Report for appsec 🐌

Benchmarks for #5384 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.905
  • 1 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 70.8μs 90.3ns 350ns 0.0703 0 0 5.97 KB
master AllCycleSimpleBody netcoreapp3.1 61.8μs 41.5ns 155ns 0.092 0 0 6.92 KB
master AllCycleSimpleBody net472 47.9μs 39.3ns 147ns 1.31 0 0 8.3 KB
master AllCycleMoreComplexBody net6.0 77.9μs 140ns 543ns 0.116 0 0 9.48 KB
master AllCycleMoreComplexBody netcoreapp3.1 69.4μs 68.3ns 264ns 0.139 0 0 10.33 KB
master AllCycleMoreComplexBody net472 55.6μs 58.2ns 225ns 1.86 0.0277 0 11.82 KB
master ObjectExtractorSimpleBody net6.0 139ns 0.141ns 0.527ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 198ns 0.176ns 0.683ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 161ns 0.123ns 0.478ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.95μs 1.31ns 5.06ns 0.053 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 3.91μs 2.28ns 8.55ns 0.0492 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 3.78μs 1.72ns 6.67ns 0.603 0.00567 0 3.8 KB
#5384 AllCycleSimpleBody net6.0 72.1μs 128ns 498ns 0.0714 0 0 5.97 KB
#5384 AllCycleSimpleBody netcoreapp3.1 61.7μs 47.3ns 177ns 0.0615 0 0 6.92 KB
#5384 AllCycleSimpleBody net472 48.3μs 46.2ns 173ns 1.32 0 0 8.3 KB
#5384 AllCycleMoreComplexBody net6.0 76.8μs 59.9ns 232ns 0.115 0 0 9.48 KB
#5384 AllCycleMoreComplexBody netcoreapp3.1 68.4μs 93.2ns 349ns 0.137 0 0 10.33 KB
#5384 AllCycleMoreComplexBody net472 56.1μs 34.8ns 135ns 1.87 0.028 0 11.82 KB
#5384 ObjectExtractorSimpleBody net6.0 146ns 0.105ns 0.408ns 0.00397 0 0 280 B
#5384 ObjectExtractorSimpleBody netcoreapp3.1 201ns 0.134ns 0.501ns 0.00367 0 0 272 B
#5384 ObjectExtractorSimpleBody net472 173ns 0.233ns 0.904ns 0.0446 0 0 281 B
#5384 ObjectExtractorMoreComplexBody net6.0 2.99μs 1.95ns 7.31ns 0.054 0 0 3.78 KB
#5384 ObjectExtractorMoreComplexBody netcoreapp3.1 4.03μs 1.55ns 6.01ns 0.0501 0 0 3.69 KB
#5384 ObjectExtractorMoreComplexBody net472 3.78μs 3.15ns 12.2ns 0.602 0.0057 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 39.3μs 16.7ns 62.6ns 0.452 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 56μs 24.6ns 91.9ns 0.446 0 0 32.4 KB
master EncodeArgs net472 70.3μs 35.6ns 138ns 5.14 0.0704 0 32.5 KB
master EncodeLegacyArgs net6.0 75.6μs 402ns 2.05μs 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 104μs 132ns 510ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 159μs 241ns 932ns 0.313 0 0 2.15 KB
#5384 EncodeArgs net6.0 40.8μs 18.6ns 72.1ns 0.447 0 0 32.4 KB
#5384 EncodeArgs netcoreapp3.1 56.1μs 32.7ns 126ns 0.445 0 0 32.4 KB
#5384 EncodeArgs net472 70.4μs 43.9ns 164ns 5.14 0.0704 0 32.5 KB
#5384 EncodeLegacyArgs net6.0 78μs 22.6ns 81.6ns 0 0 0 2.14 KB
#5384 EncodeLegacyArgs netcoreapp3.1 103μs 131ns 474ns 0 0 0 2.15 KB
#5384 EncodeLegacyArgs net472 159μs 60.8ns 228ns 0.317 0 0 2.15 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 183μs 87.2ns 338ns 0 0 0 2.13 KB
master RunWafRealisticBenchmark netcoreapp3.1 195μs 68.9ns 267ns 0 0 0 2.1 KB
master RunWafRealisticBenchmark net472 216μs 48.8ns 189ns 0.324 0 0 2.17 KB
master RunWafRealisticBenchmarkWithAttack net6.0 121μs 54ns 202ns 0 0 0 1.37 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 207ns 802ns 0 0 0 1.36 KB
master RunWafRealisticBenchmarkWithAttack net472 141μs 55ns 213ns 0.211 0 0 1.39 KB
#5384 RunWafRealisticBenchmark net6.0 181μs 87.9ns 329ns 0 0 0 2.13 KB
#5384 RunWafRealisticBenchmark netcoreapp3.1 197μs 168ns 651ns 0 0 0 2.11 KB
#5384 RunWafRealisticBenchmark net472 214μs 52.5ns 196ns 0.321 0 0 2.17 KB
#5384 RunWafRealisticBenchmarkWithAttack net6.0 120μs 44.3ns 166ns 0 0 0 1.37 KB
#5384 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 130μs 109ns 421ns 0 0 0 1.36 KB
#5384 RunWafRealisticBenchmarkWithAttack net472 142μs 172ns 668ns 0.211 0 0 1.39 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #5384

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.905 284,000.00 540,900.00

More allocations ⚠️ in #5384

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 203.83 KB 265.75 KB 61.92 KB 30.38%

Fewer allocations 🎉 in #5384

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 61.6 KB 57.16 KB -4.44 KB -7.21%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 61.6μs 666ns 6.53μs 0 0 0 43.44 KB
master StringConcatBenchmark netcoreapp3.1 64.3μs 820ns 8.16μs 0 0 0 42.64 KB
master StringConcatBenchmark net472 38.2μs 95ns 343ns 0 0 0 61.6 KB
master StringConcatAspectBenchmark net6.0 285μs 1.32μs 4.74μs 0 0 0 203.83 KB
master StringConcatAspectBenchmark netcoreapp3.1 329μs 1.53μs 11.5μs 0 0 0 204.89 KB
master StringConcatAspectBenchmark net472 262μs 5.35μs 51.1μs 0 0 0 221.18 KB
#5384 StringConcatBenchmark net6.0 61.5μs 731ns 7.24μs 0 0 0 43.44 KB
#5384 StringConcatBenchmark netcoreapp3.1 60.1μs 813ns 7.84μs 0 0 0 42.64 KB
#5384 StringConcatBenchmark net472 39μs 215ns 1.29μs 0 0 0 57.16 KB
#5384 StringConcatAspectBenchmark net6.0 544μs 2.97μs 17.1μs 0 0 0 265.75 KB
#5384 StringConcatAspectBenchmark netcoreapp3.1 317μs 1.38μs 4.98μs 0 0 0 204.11 KB
#5384 StringConcatAspectBenchmark net472 265μs 5.09μs 48.6μs 0 0 0 221.18 KB

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5384) (11.308M)   : 0, 11308294
    master (11.488M)   : 0, 11487640
    benchmarks/2.9.0 (11.392M)   : 0, 11391935

    section Automatic
    This PR (5384) (7.813M)   : 0, 7812873
    master (7.846M)   : 0, 7845687
    benchmarks/2.9.0 (8.262M)   : 0, 8262391

    section Trace stats
    This PR (5384) (8.091M)   : 0, 8090623
    master (8.313M)   : 0, 8313072

    section Manual
    This PR (5384) (9.784M)   : 0, 9783654
    master (9.948M)   : 0, 9947556

    section Manual + Automatic
    This PR (5384) (7.298M)   : 0, 7298425
    master (7.411M)   : 0, 7411345

    section Version Conflict
    This PR (5384) (6.617M)   : 0, 6617179
    master (6.757M)   : 0, 6757124
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5384) (9.519M)   : 0, 9519430
    master (9.676M)   : 0, 9675896
    benchmarks/2.9.0 (9.682M)   : 0, 9682370

    section Automatic
    This PR (5384) (6.700M)   : 0, 6699513
    master (6.648M)   : 0, 6648346

    section Trace stats
    This PR (5384) (6.861M)   : 0, 6861430
    master (6.856M)   : 0, 6855794

    section Manual
    This PR (5384) (7.987M)   : 0, 7987436
    master (8.399M)   : 0, 8399398

    section Manual + Automatic
    This PR (5384) (6.010M)   : 0, 6010057
    master (6.231M)   : 0, 6231131

    section Version Conflict
    This PR (5384) (5.647M)   : 0, 5646693
    master (5.698M)   : 0, 5698324
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5384) (8.834M)   : 0, 8834216
    master (8.706M)   : 0, 8706036
    benchmarks/2.9.0 (8.781M)   : 0, 8781024

    section Automatic
    This PR (5384) (6.172M)   : 0, 6171616
    master (6.118M)   : 0, 6118101
    benchmarks/2.9.0 (6.470M)   : 0, 6470482

    section Trace stats
    This PR (5384) (6.431M)   : 0, 6430891
    master (6.327M)   : 0, 6327387

    section Manual
    This PR (5384) (7.683M)   : 0, 7683218
    master (7.824M)   : 0, 7823664

    section Manual + Automatic
    This PR (5384) (5.955M)   : 0, 5955085
    master (5.891M)   : 0, 5890564

    section Version Conflict
    This PR (5384) (5.343M)   : 0, 5342638
    master (5.248M)   : 0, 5248258
Loading

@andrewlock andrewlock merged commit 100a235 into master Apr 3, 2024
55 of 57 checks passed
@andrewlock andrewlock deleted the andrew/ci/try-different-macos-approach branch April 3, 2024 11:38
@github-actions github-actions bot added this to the vNext milestone Apr 3, 2024
@andrewlock andrewlock modified the milestones: vNext, vNext-v2 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertpi robertpi robertpi approved these changes

Assignees
No one assigned
Labels
area:tests unit tests, integration tests
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @robertpi