-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only publish :latest
lib-injection container images on merges to master
#5388
Only publish :latest
lib-injection container images on merges to master
#5388
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 328306 Passed, 1584 Skipped, 42m 27.81s Wall Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (73ms) : 66, 80
. : milestone, 73,
master - mean (75ms) : 65, 84
. : milestone, 75,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (995ms) : 974, 1015
. : milestone, 995,
master - mean (1,004ms) : 979, 1029
. : milestone, 1004,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (110ms) : 107, 114
. : milestone, 110,
master - mean (111ms) : 107, 115
. : milestone, 111,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (719ms) : 687, 751
. : milestone, 719,
master - mean (723ms) : 698, 747
. : milestone, 723,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (93ms) : 90, 97
. : milestone, 93,
master - mean (95ms) : 91, 99
. : milestone, 95,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (674ms) : 649, 699
. : milestone, 674,
master - mean (676ms) : 657, 695
. : milestone, 676,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (188ms) : 185, 191
. : milestone, 188,
master - mean (188ms) : 185, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (1,082ms) : 1059, 1105
. : milestone, 1082,
master - mean (1,081ms) : 1059, 1104
. : milestone, 1081,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (271ms) : 268, 275
. : milestone, 271,
master - mean (272ms) : 268, 276
. : milestone, 272,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (876ms) : 850, 903
. : milestone, 876,
master - mean (875ms) : 852, 899
. : milestone, 875,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5388) - mean (260ms) : 256, 264
. : milestone, 260,
master - mean (262ms) : 257, 267
. : milestone, 262,
section CallTarget+Inlining+NGEN
This PR (5388) - mean (855ms) : 821, 890
. : milestone, 855,
master - mean (862ms) : 840, 885
. : milestone, 862,
|
Benchmarks Report for tracer 🐌Benchmarks for #5388 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Slower
|
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 | 1.124 | 1,106.60 | 1,244.25 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.11μs | 0.528ns | 1.91ns | 0.0111 | 0 | 0 | 784 B |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.52μs | 0.429ns | 1.49ns | 0.0105 | 0 | 0 | 784 B |
master | ExecuteNonQuery |
net472 | 1.81μs | 0.473ns | 1.77ns | 0.118 | 0 | 0 | 746 B |
#5388 | ExecuteNonQuery |
net6.0 | 1.24μs | 0.597ns | 2.31ns | 0.0112 | 0 | 0 | 784 B |
#5388 | ExecuteNonQuery |
netcoreapp3.1 | 1.51μs | 0.487ns | 1.88ns | 0.0105 | 0 | 0 | 784 B |
#5388 | ExecuteNonQuery |
net472 | 1.81μs | 0.724ns | 2.8ns | 0.118 | 0 | 0 | 746 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.37μs | 1.79ns | 6.69ns | 0.0137 | 0 | 0 | 1.01 KB |
master | CallElasticsearch |
netcoreapp3.1 | 1.63μs | 2.75ns | 10.3ns | 0.014 | 0 | 0 | 1.01 KB |
master | CallElasticsearch |
net472 | 2.39μs | 0.879ns | 3.29ns | 0.162 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net6.0 | 1.37μs | 0.953ns | 3.57ns | 0.0137 | 0 | 0 | 984 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.64μs | 0.965ns | 3.74ns | 0.014 | 0 | 0 | 1.06 KB |
master | CallElasticsearchAsync |
net472 | 2.69μs | 2.35ns | 9.08ns | 0.17 | 0 | 0 | 1.08 KB |
#5388 | CallElasticsearch |
net6.0 | 1.31μs | 0.482ns | 1.87ns | 0.0138 | 0 | 0 | 1.01 KB |
#5388 | CallElasticsearch |
netcoreapp3.1 | 1.64μs | 1ns | 3.61ns | 0.0138 | 0 | 0 | 1.01 KB |
#5388 | CallElasticsearch |
net472 | 2.54μs | 0.445ns | 1.6ns | 0.161 | 0 | 0 | 1.02 KB |
#5388 | CallElasticsearchAsync |
net6.0 | 1.28μs | 0.875ns | 3.28ns | 0.0135 | 0 | 0 | 984 B |
#5388 | CallElasticsearchAsync |
netcoreapp3.1 | 1.77μs | 3.86ns | 14.4ns | 0.0139 | 0 | 0 | 1.06 KB |
#5388 | CallElasticsearchAsync |
net472 | 2.72μs | 1.72ns | 6.43ns | 0.17 | 0 | 0 | 1.08 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.36μs | 0.623ns | 2.41ns | 0.0129 | 0 | 0 | 928 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.68μs | 0.877ns | 3.28ns | 0.0127 | 0 | 0 | 928 B |
master | ExecuteAsync |
net472 | 2.03μs | 0.82ns | 3.18ns | 0.141 | 0 | 0 | 891 B |
#5388 | ExecuteAsync |
net6.0 | 1.32μs | 0.541ns | 2.09ns | 0.0131 | 0 | 0 | 928 B |
#5388 | ExecuteAsync |
netcoreapp3.1 | 1.71μs | 0.831ns | 3.22ns | 0.012 | 0 | 0 | 928 B |
#5388 | ExecuteAsync |
net472 | 2μs | 0.913ns | 3.42ns | 0.141 | 0 | 0 | 891 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.14μs | 1.06ns | 3.98ns | 0.029 | 0 | 0 | 2.16 KB |
master | SendAsync |
netcoreapp3.1 | 5.21μs | 1.79ns | 6.44ns | 0.0364 | 0 | 0 | 2.7 KB |
master | SendAsync |
net472 | 7.88μs | 2.92ns | 10.9ns | 0.484 | 0 | 0 | 3.05 KB |
#5388 | SendAsync |
net6.0 | 4.06μs | 0.838ns | 3.02ns | 0.0286 | 0 | 0 | 2.16 KB |
#5388 | SendAsync |
netcoreapp3.1 | 5.28μs | 2.24ns | 8.38ns | 0.037 | 0 | 0 | 2.7 KB |
#5388 | SendAsync |
net472 | 7.67μs | 1.52ns | 5.68ns | 0.482 | 0 | 0 | 3.05 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.44μs | 0.794ns | 3.07ns | 0.0231 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.23μs | 0.823ns | 3.08ns | 0.0226 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 2.71μs | 1.9ns | 7.38ns | 0.25 | 0 | 0 | 1.57 KB |
#5388 | EnrichedLog |
net6.0 | 1.5μs | 0.391ns | 1.41ns | 0.0226 | 0 | 0 | 1.65 KB |
#5388 | EnrichedLog |
netcoreapp3.1 | 2.19μs | 1.15ns | 4.31ns | 0.0219 | 0 | 0 | 1.65 KB |
#5388 | EnrichedLog |
net472 | 2.58μs | 1.2ns | 4.34ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 112μs | 35.1ns | 136ns | 0 | 0 | 0 | 4.23 KB |
master | EnrichedLog |
netcoreapp3.1 | 118μs | 135ns | 503ns | 0 | 0 | 0 | 4.23 KB |
master | EnrichedLog |
net472 | 147μs | 113ns | 436ns | 0.659 | 0.22 | 0 | 4.41 KB |
#5388 | EnrichedLog |
net6.0 | 110μs | 55.6ns | 215ns | 0.055 | 0 | 0 | 4.23 KB |
#5388 | EnrichedLog |
netcoreapp3.1 | 117μs | 118ns | 457ns | 0.0586 | 0 | 0 | 4.23 KB |
#5388 | EnrichedLog |
net472 | 147μs | 104ns | 404ns | 0.658 | 0.219 | 0 | 4.41 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.07μs | 1.44ns | 5.56ns | 0.0307 | 0 | 0 | 2.21 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.23μs | 1.73ns | 6.72ns | 0.0296 | 0 | 0 | 2.21 KB |
master | EnrichedLog |
net472 | 5.02μs | 2.02ns | 7.84ns | 0.321 | 0 | 0 | 2.02 KB |
#5388 | EnrichedLog |
net6.0 | 3.16μs | 1.44ns | 5.39ns | 0.03 | 0 | 0 | 2.21 KB |
#5388 | EnrichedLog |
netcoreapp3.1 | 4.09μs | 2.71ns | 10.2ns | 0.0288 | 0 | 0 | 2.21 KB |
#5388 | EnrichedLog |
net472 | 4.96μs | 1.09ns | 4.08ns | 0.321 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.5μs | 0.596ns | 2.23ns | 0.0164 | 0 | 0 | 1.18 KB |
master | SendReceive |
netcoreapp3.1 | 1.79μs | 1.67ns | 6.26ns | 0.0161 | 0 | 0 | 1.18 KB |
master | SendReceive |
net472 | 2.28μs | 1.64ns | 6.14ns | 0.187 | 0 | 0 | 1.18 KB |
#5388 | SendReceive |
net6.0 | 1.39μs | 1.05ns | 3.93ns | 0.0165 | 0 | 0 | 1.18 KB |
#5388 | SendReceive |
netcoreapp3.1 | 1.76μs | 1.4ns | 5.42ns | 0.016 | 0 | 0 | 1.18 KB |
#5388 | SendReceive |
net472 | 2.25μs | 1.26ns | 4.71ns | 0.187 | 0 | 0 | 1.18 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.67μs | 0.828ns | 3.1ns | 0.0213 | 0 | 0 | 1.55 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.95μs | 1.41ns | 5.07ns | 0.02 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
net472 | 4.35μs | 2.05ns | 7.67ns | 0.316 | 0 | 0 | 1.99 KB |
#5388 | EnrichedLog |
net6.0 | 2.83μs | 1.21ns | 4.68ns | 0.0213 | 0 | 0 | 1.55 KB |
#5388 | EnrichedLog |
netcoreapp3.1 | 3.93μs | 2.05ns | 7.67ns | 0.0217 | 0 | 0 | 1.6 KB |
#5388 | EnrichedLog |
net472 | 4.56μs | 2.28ns | 8.84ns | 0.314 | 0 | 0 | 1.99 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5388
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0
1.122
626.71
558.55
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.122 | 626.71 | 558.55 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 562ns | 1.54ns | 5.96ns | 0.00762 | 0 | 0 | 552 B |
master | StartFinishSpan |
netcoreapp3.1 | 777ns | 2.36ns | 9.13ns | 0.00762 | 0 | 0 | 552 B |
master | StartFinishSpan |
net472 | 760ns | 1.73ns | 6.7ns | 0.0878 | 0 | 0 | 554 B |
master | StartFinishScope |
net6.0 | 626ns | 1.34ns | 5.2ns | 0.00931 | 0 | 0 | 672 B |
master | StartFinishScope |
netcoreapp3.1 | 903ns | 1.49ns | 5.78ns | 0.009 | 0 | 0 | 672 B |
master | StartFinishScope |
net472 | 929ns | 1.58ns | 6.13ns | 0.1 | 0 | 0 | 634 B |
#5388 | StartFinishSpan |
net6.0 | 531ns | 0.798ns | 3.09ns | 0.0077 | 0 | 0 | 552 B |
#5388 | StartFinishSpan |
netcoreapp3.1 | 716ns | 2.93ns | 11.3ns | 0.00755 | 0 | 0 | 552 B |
#5388 | StartFinishSpan |
net472 | 756ns | 1.63ns | 6.33ns | 0.0877 | 0 | 0 | 554 B |
#5388 | StartFinishScope |
net6.0 | 558ns | 0.746ns | 2.79ns | 0.00929 | 0 | 0 | 672 B |
#5388 | StartFinishScope |
netcoreapp3.1 | 863ns | 1.26ns | 4.88ns | 0.00922 | 0 | 0 | 672 B |
#5388 | StartFinishScope |
net472 | 953ns | 1.57ns | 6.08ns | 0.101 | 0 | 0 | 634 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #5388
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.206
722.93
599.54
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.206 | 722.93 | 599.54 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 722ns | 1.64ns | 6.33ns | 0.0094 | 0 | 0 | 672 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 865ns | 2.46ns | 9.52ns | 0.009 | 0 | 0 | 672 B |
master | RunOnMethodBegin |
net472 | 1.08μs | 1.61ns | 6.01ns | 0.1 | 0 | 0 | 634 B |
#5388 | RunOnMethodBegin |
net6.0 | 600ns | 1.1ns | 4.25ns | 0.00949 | 0 | 0 | 672 B |
#5388 | RunOnMethodBegin |
netcoreapp3.1 | 965ns | 0.782ns | 2.93ns | 0.00886 | 0 | 0 | 672 B |
#5388 | RunOnMethodBegin |
net472 | 1.07μs | 1.97ns | 7.63ns | 0.101 | 0 | 0 | 634 B |
Throughput/Crank Report:zap:Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5388) (10.802M) : 0, 10802074
master (10.962M) : 0, 10961969
benchmarks/2.9.0 (11.269M) : 0, 11269029
section Automatic
This PR (5388) (7.466M) : 0, 7465613
master (7.503M) : 0, 7503453
benchmarks/2.9.0 (8.101M) : 0, 8100962
section Trace stats
This PR (5388) (7.736M) : 0, 7736455
master (7.826M) : 0, 7826349
section Manual
This PR (5388) (9.417M) : 0, 9416932
master (9.540M) : 0, 9539506
section Manual + Automatic
This PR (5388) (6.961M) : 0, 6961269
master (7.140M) : 0, 7140240
section Version Conflict
This PR (5388) (6.389M) : 0, 6388591
master (6.410M) : 0, 6410320
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5388) (9.447M) : 0, 9446735
master (9.499M) : 0, 9498868
benchmarks/2.9.0 (9.648M) : 0, 9648037
section Automatic
This PR (5388) (6.603M) : 0, 6602775
master (6.660M) : 0, 6660300
section Trace stats
This PR (5388) (6.917M) : 0, 6917008
master (6.866M) : 0, 6865962
section Manual
This PR (5388) (8.175M) : 0, 8175141
master (8.166M) : 0, 8166096
section Manual + Automatic
This PR (5388) (6.168M) : 0, 6168243
master (6.173M) : 0, 6173243
section Version Conflict
This PR (5388) (5.470M) : 0, 5469820
master (5.579M) : 0, 5578907
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5388) (8.566M) : 0, 8565967
master (8.681M) : 0, 8681195
benchmarks/2.9.0 (8.991M) : 0, 8990879
section Automatic
This PR (5388) (6.184M) : 0, 6184281
master (6.080M) : 0, 6080451
benchmarks/2.9.0 (6.362M) : 0, 6361714
section Trace stats
This PR (5388) (6.394M) : 0, 6393523
master (6.327M) : 0, 6326606
section Manual
This PR (5388) (7.739M) : 0, 7738714
master (7.608M) : 0, 7607508
section Manual + Automatic
This PR (5388) (5.950M) : 0, 5949716
master (5.829M) : 0, 5829141
section Version Conflict
This PR (5388) (5.248M) : 0, 5247516
master (5.284M) : 0, 5283582
|
Summary of changes
Limits the building of lib-injection
:latest
images to merges to masterReason for change
We shouldn't be pushing these for other
release/x
branchesImplementation details
Send an
is_latest
flag in the dispatchTest coverage
Hard to check it doesn't set this for non-master, but when it's merged, I'll verify it sets the variable correctly, and we can probably be confident enough if so
Other details
Not that this means if we do releases from non-main branches that we want to be marked as latest (i.e. hotfix releases), we'll need to manually trigger this workflow to create the container images.
I think that's a reasonable tradeoff, and will add it to the release process.