-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Upgrade cppcheck to 2.12 #5398
Conversation
Datadog ReportBranch report: ❌ 1 Failed (1 Known Flaky), 332025 Passed, 1880 Skipped, 49m 16.9s Wall Time ❌ Failed Tests (1)
|
075fc23
to
5367383
Compare
5367383
to
3b864c4
Compare
@@ -15,6 +15,7 @@ namespace pmr { | |||
using namespace std::experimental::pmr; | |||
} | |||
#else // Not found at all | |||
// cppcheck-suppress preprocessorErrorDirective |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since CppCheck cannot find <memory_resource>
header file, it defaults to #error
.
Here we suppress the error because it's not one :)
preprocessorErrorDirective:*/logging.h | ||
cppcheckError:*/StackSamplerLoopManager.cpp | ||
missingIncludeSystem:* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove missing standard include headers (too noisy). CppCheck folks does not recommend otherwise we might have events from those files (which is not what we want)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (74ms) : 67, 81
. : milestone, 74,
master - mean (74ms) : 65, 84
. : milestone, 74,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (997ms) : 982, 1012
. : milestone, 997,
master - mean (998ms) : 976, 1020
. : milestone, 998,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (111ms) : 107, 114
. : milestone, 111,
master - mean (111ms) : 106, 115
. : milestone, 111,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (716ms) : 698, 735
. : milestone, 716,
master - mean (715ms) : 691, 738
. : milestone, 715,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (95ms) : 91, 98
. : milestone, 95,
master - mean (94ms) : 91, 97
. : milestone, 94,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (675ms) : 649, 700
. : milestone, 675,
master - mean (674ms) : 647, 700
. : milestone, 674,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (188ms) : 185, 191
. : milestone, 188,
master - mean (188ms) : 185, 192
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (1,075ms) : 1046, 1104
. : milestone, 1075,
master - mean (1,076ms) : 1045, 1108
. : milestone, 1076,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (270ms) : 263, 277
. : milestone, 270,
master - mean (270ms) : 262, 277
. : milestone, 270,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (877ms) : 857, 897
. : milestone, 877,
master - mean (863ms) : 833, 893
. : milestone, 863,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5398) - mean (261ms) : 257, 265
. : milestone, 261,
master - mean (260ms) : 256, 264
. : milestone, 260,
section CallTarget+Inlining+NGEN
This PR (5398) - mean (858ms) : 835, 881
. : milestone, 858,
master - mean (845ms) : 817, 873
. : milestone, 845,
|
Benchmarks Report for tracer 🐌Benchmarks for #5398 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️
|
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 | 1.154 | 1,478.86 | 1,281.31 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.48μs | 0.698ns | 2.61ns | 0.0132 | 0 | 0 | 928 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.73μs | 1.76ns | 6.6ns | 0.0128 | 0 | 0 | 928 B |
master | ExecuteAsync |
net472 | 2.01μs | 0.79ns | 2.95ns | 0.141 | 0 | 0 | 891 B |
#5398 | ExecuteAsync |
net6.0 | 1.28μs | 0.299ns | 1.03ns | 0.0129 | 0 | 0 | 928 B |
#5398 | ExecuteAsync |
netcoreapp3.1 | 1.62μs | 0.649ns | 2.34ns | 0.0125 | 0 | 0 | 928 B |
#5398 | ExecuteAsync |
net472 | 2.03μs | 1.13ns | 4.36ns | 0.141 | 0 | 0 | 891 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.33μs | 12.8ns | 49.5ns | 0.03 | 0 | 0 | 2.16 KB |
master | SendAsync |
netcoreapp3.1 | 5.14μs | 5.08ns | 19ns | 0.0362 | 0 | 0 | 2.7 KB |
master | SendAsync |
net472 | 7.75μs | 2.94ns | 11ns | 0.483 | 0 | 0 | 3.05 KB |
#5398 | SendAsync |
net6.0 | 3.99μs | 2.34ns | 8.77ns | 0.0299 | 0 | 0 | 2.16 KB |
#5398 | SendAsync |
netcoreapp3.1 | 5.05μs | 4.58ns | 17.7ns | 0.0379 | 0 | 0 | 2.7 KB |
#5398 | SendAsync |
net472 | 7.69μs | 3.34ns | 12.9ns | 0.484 | 0 | 0 | 3.05 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.6μs | 1.07ns | 4.13ns | 0.0225 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.19μs | 0.638ns | 2.47ns | 0.0231 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 2.68μs | 0.954ns | 3.44ns | 0.25 | 0 | 0 | 1.57 KB |
#5398 | EnrichedLog |
net6.0 | 1.6μs | 0.805ns | 3.01ns | 0.0231 | 0 | 0 | 1.65 KB |
#5398 | EnrichedLog |
netcoreapp3.1 | 2.27μs | 0.825ns | 3.09ns | 0.0224 | 0 | 0 | 1.65 KB |
#5398 | EnrichedLog |
net472 | 2.63μs | 2.69ns | 10.1ns | 0.249 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 112μs | 178ns | 689ns | 0 | 0 | 0 | 4.23 KB |
master | EnrichedLog |
netcoreapp3.1 | 117μs | 126ns | 489ns | 0 | 0 | 0 | 4.23 KB |
master | EnrichedLog |
net472 | 146μs | 55.1ns | 199ns | 0.657 | 0.219 | 0 | 4.41 KB |
#5398 | EnrichedLog |
net6.0 | 113μs | 220ns | 854ns | 0.0561 | 0 | 0 | 4.23 KB |
#5398 | EnrichedLog |
netcoreapp3.1 | 118μs | 166ns | 645ns | 0.0594 | 0 | 0 | 4.23 KB |
#5398 | EnrichedLog |
net472 | 147μs | 126ns | 489ns | 0.66 | 0.22 | 0 | 4.41 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 3.19μs | 2.18ns | 8.45ns | 0.03 | 0 | 0 | 2.21 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.28μs | 2.3ns | 8.9ns | 0.0301 | 0 | 0 | 2.21 KB |
master | EnrichedLog |
net472 | 5.05μs | 2.26ns | 8.76ns | 0.321 | 0 | 0 | 2.02 KB |
#5398 | EnrichedLog |
net6.0 | 3.12μs | 1.88ns | 7.28ns | 0.0311 | 0 | 0 | 2.21 KB |
#5398 | EnrichedLog |
netcoreapp3.1 | 4.19μs | 2.03ns | 7.87ns | 0.0291 | 0 | 0 | 2.21 KB |
#5398 | EnrichedLog |
net472 | 4.85μs | 2.08ns | 8.05ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.47μs | 0.573ns | 2.15ns | 0.0161 | 0 | 0 | 1.18 KB |
master | SendReceive |
netcoreapp3.1 | 1.86μs | 1.52ns | 5.89ns | 0.0157 | 0 | 0 | 1.18 KB |
master | SendReceive |
net472 | 2.3μs | 2.27ns | 8.79ns | 0.187 | 0 | 0 | 1.18 KB |
#5398 | SendReceive |
net6.0 | 1.43μs | 1.06ns | 3.96ns | 0.0164 | 0 | 0 | 1.18 KB |
#5398 | SendReceive |
netcoreapp3.1 | 1.85μs | 1.35ns | 5.24ns | 0.0158 | 0 | 0 | 1.18 KB |
#5398 | SendReceive |
net472 | 2.31μs | 1.11ns | 4.28ns | 0.187 | 0 | 0 | 1.18 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.76μs | 1.01ns | 3.77ns | 0.0208 | 0 | 0 | 1.55 KB |
master | EnrichedLog |
netcoreapp3.1 | 3.86μs | 1.41ns | 5.26ns | 0.0212 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
net472 | 4.62μs | 2.56ns | 9.91ns | 0.314 | 0 | 0 | 1.99 KB |
#5398 | EnrichedLog |
net6.0 | 2.8μs | 3.35ns | 12.1ns | 0.0209 | 0 | 0 | 1.55 KB |
#5398 | EnrichedLog |
netcoreapp3.1 | 3.91μs | 1.58ns | 6.11ns | 0.0213 | 0 | 0 | 1.6 KB |
#5398 | EnrichedLog |
net472 | 4.45μs | 1.57ns | 6.1ns | 0.315 | 0 | 0 | 1.99 KB |
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 474ns | 1.01ns | 3.93ns | 0.00778 | 0 | 0 | 552 B |
master | StartFinishSpan |
netcoreapp3.1 | 744ns | 1.91ns | 7.4ns | 0.00752 | 0 | 0 | 552 B |
master | StartFinishSpan |
net472 | 789ns | 1.07ns | 3.87ns | 0.0877 | 0 | 0 | 554 B |
master | StartFinishScope |
net6.0 | 601ns | 1.62ns | 6.27ns | 0.0093 | 0 | 0 | 672 B |
master | StartFinishScope |
netcoreapp3.1 | 897ns | 1.26ns | 4.72ns | 0.00904 | 0 | 0 | 672 B |
master | StartFinishScope |
net472 | 892ns | 1.97ns | 7.35ns | 0.101 | 0 | 0 | 634 B |
#5398 | StartFinishSpan |
net6.0 | 518ns | 2.7ns | 12.7ns | 0.00772 | 0 | 0 | 552 B |
#5398 | StartFinishSpan |
netcoreapp3.1 | 667ns | 0.94ns | 3.26ns | 0.00755 | 0 | 0 | 552 B |
#5398 | StartFinishSpan |
net472 | 789ns | 0.775ns | 3ns | 0.0877 | 0 | 0 | 554 B |
#5398 | StartFinishScope |
net6.0 | 624ns | 0.465ns | 1.68ns | 0.00937 | 0 | 0 | 672 B |
#5398 | StartFinishScope |
netcoreapp3.1 | 849ns | 3.67ns | 14.2ns | 0.00905 | 0 | 0 | 672 B |
#5398 | StartFinishScope |
net472 | 897ns | 1.04ns | 4.01ns | 0.1 | 0 | 0 | 634 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️
Slower ⚠️ in #5398
Benchmark
diff/base
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0
1.184
619.13
733.19
Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 | 1.184 | 619.13 | 733.19 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 620ns | 1.4ns | 5.41ns | 0.00939 | 0 | 0 | 672 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 904ns | 1.51ns | 5.86ns | 0.00907 | 0 | 0 | 672 B |
master | RunOnMethodBegin |
net472 | 1.07μs | 2.84ns | 11ns | 0.1 | 0 | 0 | 634 B |
#5398 | RunOnMethodBegin |
net6.0 | 733ns | 0.871ns | 3.37ns | 0.00954 | 0 | 0 | 672 B |
#5398 | RunOnMethodBegin |
netcoreapp3.1 | 960ns | 1.95ns | 7.56ns | 0.00888 | 0 | 0 | 672 B |
#5398 | RunOnMethodBegin |
net472 | 1.07μs | 1.42ns | 5.51ns | 0.1 | 0 | 0 | 634 B |
3b864c4
to
f62186f
Compare
Summary of changes
Bump CppCheck + add suppressions
Reason for change
The job has 100% error rate.
Implementation details
Test coverage
Other details