[CI Visibility] - Fix ITR Code Coverage collector attach algorithm #5412

tonyredondo · 2024-04-08T09:00:53Z

Summary of changes

This PR changes the algorithm to attach the ITR code coverage datacollector by:

Adding support for commands with the .exe suffix.
Add log warning when the code coverage has been enabled, but the command is not a dotnet command or a vstest.console command.
Add a log warning when the code coverage has been enabled, but the command is not a dotnet test command.

Reason for change

Currently we are not attaching the collector if the command finishes with the .exe suffix.

andrewlock · 2024-04-08T09:06:09Z

tracer/src/Datadog.Trace.Tools.Runner/RunCiCommand.cs

-                    var isVsTestCommand = string.Equals(program, "VSTest.Console", StringComparison.OrdinalIgnoreCase);
-                    foreach (var arg in args.Skip(1))
+                    // Try to find the test command type: `dotnet test` or `dotnet vstest`
+                    var isDotnetTestCommand = false;


Or did you mean to reset the isVsTestCommand here too? 🤔

andrewlock · 2024-04-08T09:07:02Z

tracer/src/Datadog.Trace.Tools.Runner/RunCiCommand.cs

                // Check if we are running dotnet process
-                if (string.Equals(program, "dotnet", StringComparison.OrdinalIgnoreCase) ||
-                    string.Equals(program, "VSTest.Console", StringComparison.OrdinalIgnoreCase))
+                if (isDotnetCommand || isVsTestCommand)


Will we ever have isDotnetCommand == true and isVsTestCommand == true? Is VSTest.Console test a thing you're looking for? If not, then I assume you don't need || isVsTestCommand here? 🤔

I need that || because the code to attach the collector is inside that condition.
We need to attach the collector, and there's two mode of attach:

dotnet test : Mode 1

dotnet vstest : Mode 2

vstest.console : Mode 2

So when I detect dotnet I need to look further for test or vstest to select the mode.

That's why initially I have if (isDotnetCommand || isVsTestCommand) (we need to attach the collector if we can) and later the if (isDotnetCommand) to look into the arguments (to decide if we have test or vstest to attach to).

But I mean, if you have vstest.console and not dotnet, then you're doing Mode2 no matter what, right? 🤔

In other words, which mode should be doing for these?

vstest.console test myproj.project

vstest.console vstest myproj.project

Or, while we're at it, what about these?

vstest.console myproj.project -- extra args test

dotnet test myproj.project -- extra args vstest

If the answer to 1 and 2 about are both "Mode 2", then I think we should skip the arg checking if isVsTestCommand == true 🤔

done in f287b66

…collector

datadog-ddstaging · 2024-04-08T11:59:21Z

Datadog Report

Branch report: tony/civisibility-fix-codecoverage-attach-collector
Commit report: 951741e
Test service: dd-trace-dotnet

✅ 0 Failed, 326558 Passed, 1580 Skipped, 42m 13.2s Wall Time

andrewlock · 2024-04-08T12:06:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (73ms)  : 65, 82
     .   : milestone, 73,
    master - mean (74ms)  : 61, 87
     .   : milestone, 74,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (998ms)  : 973, 1022
     .   : milestone, 998,
    master - mean (995ms)  : 979, 1010
     .   : milestone, 995,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (109ms)  : 107, 112
     .   : milestone, 109,
    master - mean (109ms)  : 105, 113
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (713ms)  : 689, 737
     .   : milestone, 713,
    master - mean (715ms)  : 689, 741
     .   : milestone, 715,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (669ms)  : 642, 695
     .   : milestone, 669,
    master - mean (665ms)  : 642, 689
     .   : milestone, 665,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (186ms)  : 184, 189
     .   : milestone, 186,
    master - mean (187ms)  : 185, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (1,074ms)  : 1046, 1101
     .   : milestone, 1074,
    master - mean (1,077ms)  : 1049, 1105
     .   : milestone, 1077,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (270ms)  : 263, 276
     .   : milestone, 270,
    master - mean (271ms)  : 268, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (872ms)  : 849, 896
     .   : milestone, 872,
    master - mean (877ms)  : 852, 902
     .   : milestone, 877,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5412) - mean (259ms)  : 252, 266
     .   : milestone, 259,
    master - mean (259ms)  : 254, 264
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5412) - mean (850ms)  : 824, 877
     .   : milestone, 850,
    master - mean (851ms)  : 830, 872
     .   : milestone, 851,

andrewlock · 2024-04-08T12:57:11Z

Benchmarks Report for tracer 🐌

Benchmarks for #5412 compared to master:

1 benchmarks are faster, with geometric mean 1.127
3 benchmarks are slower, with geometric mean 1.141
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.58μs	42.5ns	199ns	0.0219	0.00874	0	7.51 KB
master	`StartStopWithChild`	netcoreapp3.1	10.8μs	54.8ns	257ns	0.0345	0.0173	0.00575	7.6 KB
master	`StartStopWithChild`	net472	17μs	51.1ns	191ns	1.35	0.334	0.106	8.05 KB
#5412	`StartStopWithChild`	net6.0	8.7μs	45.7ns	219ns	0.021	0.0084	0	7.51 KB
#5412	`StartStopWithChild`	netcoreapp3.1	10.8μs	57.1ns	308ns	0.0376	0.0161	0	7.6 KB
#5412	`StartStopWithChild`	net472	16.9μs	57.9ns	224ns	1.34	0.317	0.0942	8.06 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	488μs	220ns	853ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	605μs	154ns	595ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	818μs	494ns	1.91μs	0.403	3.3 KB
#5412	`WriteAndFlushEnrichedTraces`	net6.0	466μs	505ns	1.95μs	0	2.7 KB
#5412	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	600μs	161ns	625ns	0	2.7 KB
#5412	`WriteAndFlushEnrichedTraces`	net472	820μs	305ns	1.18μs	0.408	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	171μs	169ns	656ns	0.17	18.33 KB
master	`SendRequest`	netcoreapp3.1	191μs	244ns	946ns	0.19	20.49 KB
master	`SendRequest`	net472	0.000966ns	0.000316ns	0.00118ns	0	0 b
#5412	`SendRequest`	net6.0	174μs	173ns	672ns	0.259	18.33 KB
#5412	`SendRequest`	netcoreapp3.1	194μs	399ns	1.38μs	0.196	20.49 KB
#5412	`SendRequest`	net472	0.000147ns	8.91E‑05ns	0.000334ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	544μs	341ns	1.28μs	0.563	0	0	41.52 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	1.58μs	6.11μs	0.324	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	842μs	3.54μs	13.7μs	8.39	2.52	0.419	53.24 KB
#5412	`WriteAndFlushEnrichedTraces`	net6.0	545μs	1.59μs	6.17μs	0.534	0	0	41.63 KB
#5412	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	1.74μs	6.75μs	0.317	0	0	41.72 KB
#5412	`WriteAndFlushEnrichedTraces`	net472	859μs	3.53μs	13.7μs	8.45	2.53	0.422	53.24 KB

Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5412

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.121	1,083.43	1,214.82

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.08μs	0.249ns	0.964ns	0.0109	784 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	2.37ns	9.17ns	0.0105	784 B
master	`ExecuteNonQuery`	net472	1.83μs	0.359ns	1.34ns	0.118	746 B
#5412	`ExecuteNonQuery`	net6.0	1.22μs	0.372ns	1.34ns	0.0109	784 B
#5412	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	0.491ns	1.9ns	0.0107	784 B
#5412	`ExecuteNonQuery`	net472	1.73μs	0.698ns	2.7ns	0.118	746 B

Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5412

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.127	1,273.11	1,434.45

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	1.25μs	0.342ns	1.28ns	0.0145	0	1.01 KB
master	`CallElasticsearch`	netcoreapp3.1	1.71μs	1.86ns	7.19ns	0.0135	0	1.01 KB
master	`CallElasticsearch`	net472	2.59μs	1.77ns	6.6ns	0.162	0	1.02 KB
master	`CallElasticsearchAsync`	net6.0	1.27μs	0.52ns	2.02ns	0.0135	0	984 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	0.811ns	2.92ns	0.0141	0	1.06 KB
master	`CallElasticsearchAsync`	net472	2.58μs	1.65ns	6.41ns	0.17	0	1.08 KB
#5412	`CallElasticsearch`	net6.0	1.29μs	0.49ns	1.9ns	0.0143	0	1.01 KB
#5412	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.481ns	1.8ns	0.0137	0	1.01 KB
#5412	`CallElasticsearch`	net472	2.58μs	1.93ns	7.49ns	0.161	0.00129	1.02 KB
#5412	`CallElasticsearchAsync`	net6.0	1.43μs	0.441ns	1.65ns	0.0136	0	984 B
#5412	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	0.775ns	2.9ns	0.0146	0	1.06 KB
#5412	`CallElasticsearchAsync`	net472	2.63μs	1.48ns	5.75ns	0.17	0	1.08 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.97ns	3.76ns	0.0127	928 B
master	`ExecuteAsync`	netcoreapp3.1	1.69μs	0.918ns	3.43ns	0.0129	928 B
master	`ExecuteAsync`	net472	1.92μs	4.05ns	14.6ns	0.141	891 B
#5412	`ExecuteAsync`	net6.0	1.22μs	0.544ns	2.04ns	0.0129	928 B
#5412	`ExecuteAsync`	netcoreapp3.1	1.7μs	0.419ns	1.62ns	0.0126	928 B
#5412	`ExecuteAsync`	net472	1.91μs	1.2ns	4.66ns	0.141	891 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.05μs	1.03ns	3.72ns	0.0303	2.16 KB
master	`SendAsync`	netcoreapp3.1	4.97μs	2.48ns	9.61ns	0.0346	2.7 KB
master	`SendAsync`	net472	7.72μs	8.52ns	31.9ns	0.484	3.05 KB
#5412	`SendAsync`	net6.0	4.2μs	1.12ns	4.02ns	0.0315	2.16 KB
#5412	`SendAsync`	netcoreapp3.1	5.09μs	1.9ns	7.11ns	0.0357	2.7 KB
#5412	`SendAsync`	net472	7.87μs	3.48ns	13.5ns	0.482	3.05 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	2.96ns	11.5ns	0.0233	1.65 KB
master	`EnrichedLog`	netcoreapp3.1	2.16μs	0.907ns	3.39ns	0.0219	1.65 KB
master	`EnrichedLog`	net472	2.83μs	1.16ns	4.35ns	0.249	1.57 KB
#5412	`EnrichedLog`	net6.0	1.5μs	1.14ns	4.42ns	0.0232	1.65 KB
#5412	`EnrichedLog`	netcoreapp3.1	2.21μs	0.798ns	2.99ns	0.0224	1.65 KB
#5412	`EnrichedLog`	net472	2.72μs	1.48ns	5.54ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	218ns	845ns	0.0565	0	4.23 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	139ns	519ns	0	0	4.23 KB
master	`EnrichedLog`	net472	147μs	131ns	507ns	0.659	0.22	4.41 KB
#5412	`EnrichedLog`	net6.0	111μs	68ns	263ns	0.056	0	4.23 KB
#5412	`EnrichedLog`	netcoreapp3.1	117μs	150ns	581ns	0	0	4.23 KB
#5412	`EnrichedLog`	net472	146μs	47.6ns	178ns	0.658	0.219	4.41 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.87ns	7.25ns	0.0303	2.21 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	2.12ns	7.93ns	0.0297	2.21 KB
master	`EnrichedLog`	net472	4.81μs	5.36ns	20.8ns	0.321	2.02 KB
#5412	`EnrichedLog`	net6.0	3.09μs	1.09ns	4.08ns	0.031	2.21 KB
#5412	`EnrichedLog`	netcoreapp3.1	4.32μs	1.09ns	4.22ns	0.0281	2.21 KB
#5412	`EnrichedLog`	net472	4.88μs	2.15ns	8.34ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.54μs	1.05ns	3.92ns	0.0162	0	1.18 KB
master	`SendReceive`	netcoreapp3.1	1.91μs	0.803ns	2.9ns	0.0161	0	1.18 KB
master	`SendReceive`	net472	2.37μs	1.09ns	4.21ns	0.186	0	1.18 KB
#5412	`SendReceive`	net6.0	1.42μs	0.325ns	1.26ns	0.0163	0	1.18 KB
#5412	`SendReceive`	netcoreapp3.1	1.78μs	0.793ns	2.97ns	0.0155	0	1.18 KB
#5412	`SendReceive`	net472	2.26μs	1.23ns	4.76ns	0.187	0.00113	1.18 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	0.912ns	3.53ns	0.0222	1.55 KB
master	`EnrichedLog`	netcoreapp3.1	3.88μs	2.19ns	8.19ns	0.0213	1.6 KB
master	`EnrichedLog`	net472	4.39μs	1.81ns	7.01ns	0.314	1.99 KB
#5412	`EnrichedLog`	net6.0	2.74μs	1.33ns	5.15ns	0.0206	1.55 KB
#5412	`EnrichedLog`	netcoreapp3.1	3.98μs	1.24ns	4.29ns	0.0198	1.6 KB
#5412	`EnrichedLog`	net472	4.49μs	2.14ns	8.28ns	0.316	1.99 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5412

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.176	533.26	627.02

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	526ns	1.29ns	5ns	0.00771	552 B
master	`StartFinishSpan`	netcoreapp3.1	728ns	1.4ns	5.43ns	0.0074	552 B
master	`StartFinishSpan`	net472	680ns	0.921ns	3.57ns	0.0877	554 B
master	`StartFinishScope`	net6.0	534ns	0.99ns	3.83ns	0.00946	672 B
master	`StartFinishScope`	netcoreapp3.1	925ns	1.46ns	5.64ns	0.00875	672 B
master	`StartFinishScope`	net472	977ns	1.67ns	6.25ns	0.101	634 B
#5412	`StartFinishSpan`	net6.0	521ns	0.908ns	3.52ns	0.00762	552 B
#5412	`StartFinishSpan`	netcoreapp3.1	695ns	2.87ns	11.1ns	0.00737	552 B
#5412	`StartFinishSpan`	net472	736ns	1.01ns	3.92ns	0.0879	554 B
#5412	`StartFinishScope`	net6.0	627ns	1.09ns	4.23ns	0.00944	672 B
#5412	`StartFinishScope`	netcoreapp3.1	925ns	1.11ns	4.29ns	0.00892	672 B
#5412	`StartFinishScope`	net472	948ns	1.83ns	7.07ns	0.1	634 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5412

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472	1.127	1,167.53	1,036.25

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	640ns	1.19ns	4.6ns	0.00941	672 B
master	`RunOnMethodBegin`	netcoreapp3.1	946ns	1.64ns	6.35ns	0.00861	672 B
master	`RunOnMethodBegin`	net472	1.17μs	3.27ns	12.7ns	0.101	634 B
#5412	`RunOnMethodBegin`	net6.0	659ns	0.529ns	1.98ns	0.00954	672 B
#5412	`RunOnMethodBegin`	netcoreapp3.1	961ns	1.53ns	5.92ns	0.00897	672 B
#5412	`RunOnMethodBegin`	net472	1.03μs	1.96ns	7.59ns	0.1	634 B

[CI Visibility] - Fix ITR Code Coverage collector attach algorithm

0cc1234

tonyredondo self-assigned this Apr 8, 2024

tonyredondo requested a review from a team as a code owner April 8, 2024 09:00

github-actions bot added the area:ci-visibility label Apr 8, 2024

andrewlock approved these changes Apr 8, 2024

View reviewed changes

anmarchenko approved these changes Apr 8, 2024

View reviewed changes

Change from review

f287b66

DataDog deleted a comment from andrewlock Apr 8, 2024

DataDog deleted a comment from datadog-ddstaging bot Apr 8, 2024

Merge branch 'master' into tony/civisibility-fix-codecoverage-attach-…

951741e

…collector

tonyredondo merged commit 8345175 into master Apr 8, 2024
54 of 57 checks passed

tonyredondo deleted the tony/civisibility-fix-codecoverage-attach-collector branch April 8, 2024 13:13

github-actions bot added this to the vNext-v2 milestone Apr 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI Visibility] - Fix ITR Code Coverage collector attach algorithm #5412

[CI Visibility] - Fix ITR Code Coverage collector attach algorithm #5412

tonyredondo commented Apr 8, 2024

andrewlock Apr 8, 2024

andrewlock Apr 8, 2024

tonyredondo Apr 8, 2024

andrewlock Apr 8, 2024 •

edited

Loading

andrewlock Apr 8, 2024

tonyredondo Apr 8, 2024

datadog-ddstaging bot commented Apr 8, 2024 •

edited

Loading

andrewlock commented Apr 8, 2024

andrewlock commented Apr 8, 2024

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5412

Raw results

Slower ⚠️ in #5412

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5412

Raw results

Faster 🎉 in #5412

Raw results

[CI Visibility] - Fix ITR Code Coverage collector attach algorithm #5412

[CI Visibility] - Fix ITR Code Coverage collector attach algorithm #5412

Conversation

tonyredondo commented Apr 8, 2024

Summary of changes

Reason for change

andrewlock Apr 8, 2024

Choose a reason for hiding this comment

andrewlock Apr 8, 2024

Choose a reason for hiding this comment

tonyredondo Apr 8, 2024

Choose a reason for hiding this comment

andrewlock Apr 8, 2024 • edited Loading

Choose a reason for hiding this comment

andrewlock Apr 8, 2024

Choose a reason for hiding this comment

tonyredondo Apr 8, 2024

Choose a reason for hiding this comment

datadog-ddstaging bot commented Apr 8, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 8, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 8, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5412

Raw results

Slower ⚠️ in #5412

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5412

Raw results

Faster 🎉 in #5412

Raw results

andrewlock Apr 8, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 8, 2024 •

edited

Loading