Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profiler integration tests #5423

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix profiler integration tests #5423

merged 1 commit into from
Apr 10, 2024

Conversation

andrewlock
Copy link
Member

Summary of changes

Add missing MockSpanLink for profiler integration tests

Reason for change

The profiler integration tests are currently completely broken on master

Implementation details

#5354 added support for span links. As part of that PR, the mock span definition was updated. Unfortunately, the profiler integration tests link in the MockSpan, so it was then missing the MockSpanLink definition

Test coverage

Covered by existing

Other details

IMO this is exactly the sort of coupling we don't want between the different products, where a sipmle change in one breaks the other products, and results in broken master. That said, we probably do want to have a unified specification for what a "span" looks like. Maybe the answer is a proper shared project, instead of simple linking?

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Apr 10, 2024
@andrewlock andrewlock requested a review from a team as a code owner April 10, 2024 08:45
@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Apr 10, 2024
gleocadie
gleocadie approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Apr 10, 2024 •
edited
Loading

Datadog Report

Branch report: andrew/fix-profiler-integration-tests
Commit report: 11e5715
Test service: dd-trace-dotnet

✅ 0 Failed, 331318 Passed, 1798 Skipped, 42m 41.34s Wall Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (74ms)  : 63, 85
     .   : milestone, 74,
    master - mean (72ms)  : 63, 81
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (1,018ms)  : 1002, 1034
     .   : milestone, 1018,
    master - mean (1,022ms)  : 1004, 1040
     .   : milestone, 1022,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (108ms)  : 105, 112
     .   : milestone, 108,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (746ms)  : 726, 765
     .   : milestone, 746,
    master - mean (744ms)  : 730, 758
     .   : milestone, 744,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (92ms)  : 88, 95
     .   : milestone, 92,
    master - mean (93ms)  : 89, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (690ms)  : 675, 706
     .   : milestone, 690,
    master - mean (698ms)  : 683, 713
     .   : milestone, 698,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (187ms)  : 184, 190
     .   : milestone, 187,
    master - mean (187ms)  : 183, 191
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (1,098ms)  : 1070, 1125
     .   : milestone, 1098,
    master - mean (1,099ms)  : 1075, 1124
     .   : milestone, 1099,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (270ms)  : 266, 275
     .   : milestone, 270,
    master - mean (270ms)  : 267, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (895ms)  : 876, 913
     .   : milestone, 895,
    master - mean (889ms)  : 869, 909
     .   : milestone, 889,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5423) - mean (261ms)  : 258, 265
     .   : milestone, 261,
    master - mean (259ms)  : 252, 266
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5423) - mean (876ms)  : 849, 902
     .   : milestone, 876,
    master - mean (874ms)  : 858, 891
     .   : milestone, 874,
Loading

@andrewlock
Copy link
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5423 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.132
  • 2 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.61μs 43.6ns 214ns 0.0262 0.0131 0 7.54 KB
master StartStopWithChild netcoreapp3.1 10.5μs 53.9ns 259ns 0.0264 0.0105 0 7.63 KB
master StartStopWithChild net472 17μs 64.6ns 250ns 1.35 0.376 0.12 8.07 KB
#5423 StartStopWithChild net6.0 8.7μs 44.8ns 210ns 0.0254 0.0127 0 7.54 KB
#5423 StartStopWithChild netcoreapp3.1 10.6μs 59.1ns 392ns 0.0252 0.0101 0 7.63 KB
#5423 StartStopWithChild net472 16.7μs 56.9ns 220ns 1.35 0.379 0.124 8.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 450μs 449ns 1.74μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 622μs 308ns 1.19μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 818μs 611ns 2.37μs 0.406 0 0 3.3 KB
#5423 WriteAndFlushEnrichedTraces net6.0 480μs 202ns 755ns 0 0 0 2.7 KB
#5423 WriteAndFlushEnrichedTraces netcoreapp3.1 608μs 198ns 768ns 0 0 0 2.7 KB
#5423 WriteAndFlushEnrichedTraces net472 825μs 246ns 951ns 0.411 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 168μs 290ns 1.12μs 0.17 0 0 18.38 KB
master SendRequest netcoreapp3.1 192μs 301ns 1.17μs 0.191 0 0 20.54 KB
master SendRequest net472 0.000434ns 0.000182ns 0.000657ns 0 0 0 0 b
#5423 SendRequest net6.0 167μs 157ns 609ns 0.25 0 0 18.38 KB
#5423 SendRequest netcoreapp3.1 194μs 353ns 1.37μs 0.193 0 0 20.54 KB
#5423 SendRequest net472 0.00153ns 0.000391ns 0.00141ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5423

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.84 KB 41.61 KB -234 B -0.56%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.96 KB 41.6 KB -360 B -0.86%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 576μs 1.35μs 5.22μs 0.548 0 0 41.84 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 650μs 943ns 3.53μs 0.331 0 0 41.96 KB
master WriteAndFlushEnrichedTraces net472 871μs 4.33μs 19.4μs 8.08 2.55 0.425 53.21 KB
#5423 WriteAndFlushEnrichedTraces net6.0 557μs 1.07μs 4.13μs 0.553 0 0 41.61 KB
#5423 WriteAndFlushEnrichedTraces netcoreapp3.1 645μs 1.07μs 4.15μs 0.319 0 0 41.6 KB
#5423 WriteAndFlushEnrichedTraces net472 831μs 2.99μs 11.6μs 8.12 2.44 0.406 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.13μs 0.664ns 2.48ns 0.0113 0 0 800 B
master ExecuteNonQuery netcoreapp3.1 1.59μs 0.427ns 1.54ns 0.0104 0 0 800 B
master ExecuteNonQuery net472 1.81μs 0.399ns 1.54ns 0.121 0 0 762 B
#5423 ExecuteNonQuery net6.0 1.17μs 0.787ns 3.05ns 0.0111 0 0 800 B
#5423 ExecuteNonQuery netcoreapp3.1 1.48μs 1.73ns 6.7ns 0.0103 0 0 800 B
#5423 ExecuteNonQuery net472 1.78μs 0.569ns 2.13ns 0.121 0 0 762 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.503ns 1.88ns 0.0143 0 0 1.02 KB
master CallElasticsearch netcoreapp3.1 1.6μs 0.481ns 1.8ns 0.0138 0 0 1.02 KB
master CallElasticsearch net472 2.6μs 1.47ns 5.48ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.46μs 0.873ns 3.27ns 0.0138 0 0 1 KB
master CallElasticsearchAsync netcoreapp3.1 1.68μs 0.739ns 2.86ns 0.0142 0 0 1.07 KB
master CallElasticsearchAsync net472 2.66μs 1.52ns 5.7ns 0.172 0 0 1.09 KB
#5423 CallElasticsearch net6.0 1.29μs 0.635ns 2.38ns 0.0144 0 0 1.02 KB
#5423 CallElasticsearch netcoreapp3.1 1.6μs 0.735ns 2.75ns 0.0136 0 0 1.02 KB
#5423 CallElasticsearch net472 2.49μs 2.15ns 8.32ns 0.164 0 0 1.04 KB
#5423 CallElasticsearchAsync net6.0 1.31μs 0.416ns 1.56ns 0.0138 0 0 1 KB
#5423 CallElasticsearchAsync netcoreapp3.1 1.67μs 1.22ns 4.56ns 0.0145 0 0 1.07 KB
#5423 CallElasticsearchAsync net472 2.54μs 0.964ns 3.61ns 0.172 0 0 1.09 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.33μs 1.33ns 5.15ns 0.0128 0 0 944 B
master ExecuteAsync netcoreapp3.1 1.82μs 0.765ns 2.86ns 0.0126 0 0 944 B
master ExecuteAsync net472 1.96μs 0.502ns 1.88ns 0.144 0 0 907 B
#5423 ExecuteAsync net6.0 1.4μs 1.28ns 4.96ns 0.0133 0 0 944 B
#5423 ExecuteAsync netcoreapp3.1 1.73μs 1.42ns 5.32ns 0.0121 0 0 944 B
#5423 ExecuteAsync net472 1.95μs 0.973ns 3.77ns 0.144 0 0 907 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.09μs 1.77ns 6.62ns 0.0295 0 0 2.18 KB
master SendAsync netcoreapp3.1 5.05μs 1.98ns 7.4ns 0.0354 0 0 2.71 KB
master SendAsync net472 7.69μs 1.95ns 7.3ns 0.485 0 0 3.07 KB
#5423 SendAsync net6.0 4.34μs 2.19ns 8.2ns 0.0302 0 0 2.18 KB
#5423 SendAsync netcoreapp3.1 5.07μs 1.61ns 5.82ns 0.0354 0 0 2.71 KB
#5423 SendAsync net472 7.73μs 2.27ns 8.81ns 0.486 0 0 3.06 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5423

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0 1.117 1,598.53 1,430.93

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.6μs 0.901ns 3.49ns 0.0235 0 0 1.68 KB
master EnrichedLog netcoreapp3.1 2.25μs 1.05ns 3.94ns 0.023 0 0 1.68 KB
master EnrichedLog net472 2.7μs 0.736ns 2.55ns 0.255 0 0 1.61 KB
#5423 EnrichedLog net6.0 1.43μs 0.801ns 3ns 0.0237 0 0 1.68 KB
#5423 EnrichedLog netcoreapp3.1 2.35μs 0.831ns 3.22ns 0.0223 0 0 1.68 KB
#5423 EnrichedLog net472 2.61μs 2.47ns 9.25ns 0.254 0 0 1.61 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 86.6ns 336ns 0.0565 0 0 4.26 KB
master EnrichedLog netcoreapp3.1 117μs 103ns 398ns 0.0589 0 0 4.26 KB
master EnrichedLog net472 146μs 83ns 311ns 0.66 0.22 0 4.45 KB
#5423 EnrichedLog net6.0 112μs 108ns 403ns 0.056 0 0 4.26 KB
#5423 EnrichedLog netcoreapp3.1 120μs 105ns 380ns 0 0 0 4.26 KB
#5423 EnrichedLog net472 147μs 124ns 479ns 0.659 0.22 0 4.45 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.02μs 1.18ns 4.56ns 0.0319 0 0 2.24 KB
master EnrichedLog netcoreapp3.1 4.15μs 1.86ns 6.97ns 0.0293 0 0 2.24 KB
master EnrichedLog net472 5.03μs 1.84ns 7.11ns 0.324 0 0 2.05 KB
#5423 EnrichedLog net6.0 3.15μs 1.02ns 3.81ns 0.0307 0 0 2.24 KB
#5423 EnrichedLog netcoreapp3.1 4.14μs 2.56ns 9.9ns 0.0308 0 0 2.24 KB
#5423 EnrichedLog net472 4.96μs 2.06ns 7.99ns 0.325 0 0 2.05 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.51μs 0.833ns 3.12ns 0.0165 0 0 1.19 KB
master SendReceive netcoreapp3.1 1.81μs 0.705ns 2.64ns 0.0163 0 0 1.19 KB
master SendReceive net472 2.29μs 1.22ns 4.56ns 0.19 0 0 1.2 KB
#5423 SendReceive net6.0 1.4μs 1.51ns 5.64ns 0.0169 0 0 1.19 KB
#5423 SendReceive netcoreapp3.1 1.84μs 0.759ns 2.94ns 0.0165 0 0 1.19 KB
#5423 SendReceive net472 2.32μs 2.94ns 11ns 0.19 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.63μs 0.715ns 2.58ns 0.0224 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 3.97μs 1.31ns 4.92ns 0.022 0 0 1.63 KB
master EnrichedLog net472 4.56μs 2.37ns 9.16ns 0.319 0 0 2.02 KB
#5423 EnrichedLog net6.0 2.77μs 1.01ns 3.78ns 0.0223 0 0 1.58 KB
#5423 EnrichedLog netcoreapp3.1 3.93μs 1.93ns 7.21ns 0.0216 0 0 1.63 KB
#5423 EnrichedLog net472 4.57μs 2.21ns 8.27ns 0.32 0 0 2.02 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5423

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.148 744.22 648.35

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 543ns 0.926ns 3.47ns 0.00789 0 0 568 B
master StartFinishSpan netcoreapp3.1 744ns 1.51ns 5.85ns 0.00758 0 0 568 B
master StartFinishSpan net472 742ns 1.34ns 5.19ns 0.0902 0 0 570 B
master StartFinishScope net6.0 589ns 0.77ns 2.88ns 0.00948 0 0 688 B
master StartFinishScope netcoreapp3.1 832ns 4.19ns 18.7ns 0.00914 0 0 688 B
master StartFinishScope net472 976ns 2.66ns 10.3ns 0.103 0 0 650 B
#5423 StartFinishSpan net6.0 525ns 0.938ns 3.63ns 0.00797 0 0 568 B
#5423 StartFinishSpan netcoreapp3.1 648ns 1.86ns 7.19ns 0.00762 0 0 568 B
#5423 StartFinishSpan net472 772ns 1.07ns 4.14ns 0.0905 0 0 570 B
#5423 StartFinishScope net6.0 577ns 1.21ns 4.69ns 0.00972 0 0 688 B
#5423 StartFinishScope netcoreapp3.1 870ns 1.89ns 7.33ns 0.00907 0 0 688 B
#5423 StartFinishScope net472 951ns 1.6ns 6.2ns 0.103 0 0 650 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 674ns 0.877ns 3.16ns 0.00948 0 0 688 B
master RunOnMethodBegin netcoreapp3.1 957ns 3.5ns 13.6ns 0.00927 0 0 688 B
master RunOnMethodBegin net472 1.05μs 2.65ns 10.3ns 0.103 0 0 650 B
#5423 RunOnMethodBegin net6.0 670ns 0.953ns 3.69ns 0.00974 0 0 688 B
#5423 RunOnMethodBegin netcoreapp3.1 966ns 2.46ns 9.54ns 0.00914 0 0 688 B
#5423 RunOnMethodBegin net472 1.11μs 1.87ns 7.23ns 0.103 0 0 650 B

@andrewlock
Copy link
Member Author

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5423) (11.094M)   : 0, 11094158
    master (11.430M)   : 0, 11429664
    benchmarks/2.9.0 (11.187M)   : 0, 11186587

    section Automatic
    This PR (5423) (7.679M)   : 0, 7678647
    master (7.819M)   : 0, 7818528
    benchmarks/2.9.0 (8.098M)   : 0, 8098308

    section Trace stats
    This PR (5423) (7.894M)   : 0, 7894435
    master (8.162M)   : 0, 8162196

    section Manual
    This PR (5423) (9.799M)   : 0, 9799313
    master (9.986M)   : 0, 9985819

    section Manual + Automatic
    This PR (5423) (7.285M)   : 0, 7284821
    master (7.471M)   : 0, 7470769

    section Version Conflict
    This PR (5423) (6.557M)   : 0, 6556681
    master (6.778M)   : 0, 6778254
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5423) (9.449M)   : 0, 9448731
    master (9.643M)   : 0, 9643473
    benchmarks/2.9.0 (9.623M)   : 0, 9622544

    section Automatic
    This PR (5423) (6.560M)   : 0, 6560053
    master (6.659M)   : 0, 6659218

    section Trace stats
    This PR (5423) (6.945M)   : 0, 6945442
    master (6.920M)   : 0, 6919531

    section Manual
    This PR (5423) (8.115M)   : 0, 8114842
    master (8.396M)   : 0, 8395590

    section Manual + Automatic
    This PR (5423) (6.066M)   : 0, 6065634
    master (6.179M)   : 0, 6179055

    section Version Conflict
    This PR (5423) (5.655M)   : 0, 5655424
    master (5.678M)   : 0, 5677677
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5423) (10.269M)   : 0, 10269081
    master (10.042M)   : 0, 10041632
    benchmarks/2.9.0 (10.205M)   : 0, 10204623

    section Automatic
    This PR (5423) (7.194M)   : 0, 7194361
    master (6.962M)   : 0, 6961998
    benchmarks/2.9.0 (7.559M)   : 0, 7559485

    section Trace stats
    This PR (5423) (7.506M)   : 0, 7506335
    master (7.392M)   : 0, 7391845

    section Manual
    This PR (5423) (8.804M)   : 0, 8804422
    master (8.612M)   : 0, 8612052

    section Manual + Automatic
    This PR (5423) (6.878M)   : 0, 6878198
    master (6.769M)   : 0, 6768748

    section Version Conflict
    This PR (5423) (6.192M)   : 0, 6191550
    master (6.068M)   : 0, 6068180
Loading

@andrewlock andrewlock merged commit 8d62084 into master Apr 10, 2024
65 checks passed
@andrewlock andrewlock deleted the andrew/fix-profiler-integration-tests branch April 10, 2024 12:01
@github-actions github-actions bot added this to the vNext-v2 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler area:tests unit tests, integration tests
Projects
None yet
Milestone
2.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlock @gleocadie