[Profiler] Pass memory_resource around #5434

gleocadie · 2024-04-11T18:02:17Z

Summary of changes

Provide memory_resource instance to provider.

Reason for change

This is mainly plumbing PR. The goal is to pass a memory_resource to the LinkedList.

For now we use the default one (new/delete).
In next PR(s), we may use Pooled resource memory instances.

Implementation details

Change Providers signature to pass a memory_resource to the LinkedList

Test coverage

Current tests must pass

Other details

datadog-ddstaging · 2024-04-11T18:15:37Z

Datadog Report

Branch report: gleocadie/pass-memory-resource-to-provider
Commit report: da28eb9
Test service: dd-trace-dotnet

✅ 0 Failed, 328498 Passed, 1794 Skipped, 43m 36.66s Wall Time

andrewlock · 2024-04-11T18:26:46Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (75ms)  : 60, 90
     .   : milestone, 75,
    master - mean (73ms)  : 65, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (1,014ms)  : 993, 1035
     .   : milestone, 1014,
    master - mean (1,013ms)  : 991, 1035
     .   : milestone, 1013,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (109ms)  : 106, 112
     .   : milestone, 109,
    master - mean (109ms)  : 106, 112
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (735ms)  : 718, 753
     .   : milestone, 735,
    master - mean (736ms)  : 716, 756
     .   : milestone, 736,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (94ms)  : 90, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (690ms)  : 660, 719
     .   : milestone, 690,
    master - mean (691ms)  : 668, 714
     .   : milestone, 691,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (187ms)  : 185, 190
     .   : milestone, 187,
    master - mean (188ms)  : 185, 191
     .   : milestone, 188,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (1,085ms)  : 1057, 1112
     .   : milestone, 1085,
    master - mean (1,091ms)  : 1071, 1111
     .   : milestone, 1091,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (271ms)  : 267, 275
     .   : milestone, 271,
    master - mean (273ms)  : 269, 277
     .   : milestone, 273,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (889ms)  : 868, 910
     .   : milestone, 889,
    master - mean (890ms)  : 863, 916
     .   : milestone, 890,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5434) - mean (260ms)  : 256, 265
     .   : milestone, 260,
    master - mean (261ms)  : 258, 264
     .   : milestone, 261,

    section CallTarget+Inlining+NGEN
    This PR (5434) - mean (869ms)  : 848, 890
     .   : milestone, 869,
    master - mean (867ms)  : 845, 888
     .   : milestone, 867,

andrewlock · 2024-04-11T18:39:53Z

Benchmarks Report for tracer 🐌

Benchmarks for #5434 compared to master:

1 benchmarks are slower, with geometric mean 1.147
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.97μs	51.2ns	366ns	0.0184	0.00919	0	7.54 KB
master	`StartStopWithChild`	netcoreapp3.1	10.5μs	43.3ns	162ns	0.0313	0.0157	0	7.64 KB
master	`StartStopWithChild`	net472	17μs	81.3ns	325ns	1.34	0.353	0.103	8.09 KB
#5434	`StartStopWithChild`	net6.0	9.18μs	51.5ns	342ns	0.0218	0.00872	0	7.54 KB
#5434	`StartStopWithChild`	netcoreapp3.1	10.6μs	59.6ns	400ns	0.0261	0.0156	0	7.63 KB
#5434	`StartStopWithChild`	net472	16.9μs	55.5ns	208ns	1.36	0.369	0.0923	8.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	455μs	472ns	1.7μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	619μs	139ns	518ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	829μs	239ns	927ns	0.408	3.3 KB
#5434	`WriteAndFlushEnrichedTraces`	net6.0	464μs	136ns	527ns	0	2.7 KB
#5434	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	622μs	315ns	1.22μs	0	2.7 KB
#5434	`WriteAndFlushEnrichedTraces`	net472	822μs	280ns	1.05μs	0.408	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	169μs	208ns	807ns	0.252	18.38 KB
master	`SendRequest`	netcoreapp3.1	189μs	269ns	1.04μs	0.188	20.54 KB
master	`SendRequest`	net472	0.000552ns	0.000251ns	0.000971ns	0	0 b
#5434	`SendRequest`	net6.0	171μs	197ns	762ns	0.17	18.38 KB
#5434	`SendRequest`	netcoreapp3.1	191μs	399ns	1.54μs	0.19	20.54 KB
#5434	`SendRequest`	net472	4.83E‑05ns	4.74E‑05ns	0.000164ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	553μs	1.46μs	5.66μs	0.553	0	0	41.73 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	672μs	1.98μs	7.66μs	0.336	0	0	41.75 KB
master	`WriteAndFlushEnrichedTraces`	net472	846μs	2.89μs	11.2μs	8.45	2.53	0.422	53.26 KB
#5434	`WriteAndFlushEnrichedTraces`	net6.0	537μs	453ns	1.69μs	0.548	0	0	41.74 KB
#5434	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	668μs	501ns	1.8μs	0.334	0	0	41.67 KB
#5434	`WriteAndFlushEnrichedTraces`	net472	839μs	2.42μs	8.72μs	8.19	2.59	0.431	53.25 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.22μs	3.28ns	12.7ns	0.0109	800 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.53μs	1.12ns	4.32ns	0.0106	800 B
master	`ExecuteNonQuery`	net472	1.76μs	0.408ns	1.53ns	0.121	762 B
#5434	`ExecuteNonQuery`	net6.0	1.15μs	0.611ns	2.37ns	0.0108	800 B
#5434	`ExecuteNonQuery`	netcoreapp3.1	1.57μs	1.48ns	5.55ns	0.011	800 B
#5434	`ExecuteNonQuery`	net472	1.8μs	0.848ns	3.28ns	0.12	762 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.32μs	0.669ns	2.5ns	0.0145	1.02 KB
master	`CallElasticsearch`	netcoreapp3.1	1.62μs	2.82ns	10.9ns	0.0138	1.02 KB
master	`CallElasticsearch`	net472	2.55μs	0.936ns	3.63ns	0.164	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.31μs	0.575ns	2.23ns	0.0138	1 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.67μs	2.64ns	9.89ns	0.0141	1.07 KB
master	`CallElasticsearchAsync`	net472	2.64μs	0.757ns	2.83ns	0.172	1.09 KB
#5434	`CallElasticsearch`	net6.0	1.31μs	0.545ns	2.04ns	0.0145	1.02 KB
#5434	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.536ns	2.01ns	0.0134	1.02 KB
#5434	`CallElasticsearch`	net472	2.51μs	1.99ns	7.45ns	0.164	1.04 KB
#5434	`CallElasticsearchAsync`	net6.0	1.45μs	0.69ns	2.58ns	0.0136	1 KB
#5434	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	1.69ns	6.54ns	0.0138	1.07 KB
#5434	`CallElasticsearchAsync`	net472	2.61μs	0.961ns	3.72ns	0.172	1.09 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.42μs	0.438ns	1.7ns	0.0134	944 B
master	`ExecuteAsync`	netcoreapp3.1	1.67μs	0.559ns	2.09ns	0.0124	944 B
master	`ExecuteAsync`	net472	1.93μs	4.69ns	17.5ns	0.143	907 B
#5434	`ExecuteAsync`	net6.0	1.4μs	0.953ns	3.69ns	0.0134	944 B
#5434	`ExecuteAsync`	netcoreapp3.1	1.61μs	1.56ns	5.83ns	0.0129	944 B
#5434	`ExecuteAsync`	net472	1.82μs	0.87ns	3.26ns	0.144	907 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.18μs	2.27ns	8.5ns	0.0294	2.18 KB
master	`SendAsync`	netcoreapp3.1	5.09μs	2.28ns	7.89ns	0.0382	2.71 KB
master	`SendAsync`	net472	7.68μs	4.35ns	16.8ns	0.485	3.06 KB
#5434	`SendAsync`	net6.0	4.23μs	1.4ns	5.24ns	0.0297	2.18 KB
#5434	`SendAsync`	netcoreapp3.1	5.12μs	2.13ns	7.97ns	0.0356	2.71 KB
#5434	`SendAsync`	net472	7.75μs	3.21ns	12.4ns	0.483	3.07 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.58μs	1.1ns	4.11ns	0.0238	1.68 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	1.01ns	3.76ns	0.0223	1.68 KB
master	`EnrichedLog`	net472	2.66μs	1.83ns	6.61ns	0.254	1.61 KB
#5434	`EnrichedLog`	net6.0	1.5μs	0.562ns	2.18ns	0.0233	1.68 KB
#5434	`EnrichedLog`	netcoreapp3.1	2.22μs	1.25ns	4.66ns	0.0224	1.68 KB
#5434	`EnrichedLog`	net472	2.74μs	4.29ns	16.6ns	0.254	1.61 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	114μs	176ns	657ns	0.0568	0	4.26 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	142ns	549ns	0.0603	0	4.26 KB
master	`EnrichedLog`	net472	152μs	282ns	1.09μs	0.673	0.224	4.45 KB
#5434	`EnrichedLog`	net6.0	114μs	179ns	692ns	0.0567	0	4.26 KB
#5434	`EnrichedLog`	netcoreapp3.1	121μs	160ns	619ns	0	0	4.26 KB
#5434	`EnrichedLog`	net472	149μs	119ns	459ns	0.666	0.222	4.45 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.89μs	1.38ns	5.33ns	0.0317	2.24 KB
master	`EnrichedLog`	netcoreapp3.1	4.29μs	2.01ns	7.8ns	0.0302	2.24 KB
master	`EnrichedLog`	net472	4.95μs	2.24ns	8.38ns	0.325	2.05 KB
#5434	`EnrichedLog`	net6.0	2.95μs	1.32ns	5.1ns	0.0314	2.24 KB
#5434	`EnrichedLog`	netcoreapp3.1	4.18μs	2.2ns	8.23ns	0.031	2.24 KB
#5434	`EnrichedLog`	net472	4.84μs	1.1ns	4.26ns	0.324	2.05 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.5μs	3.04ns	11.8ns	0.0166	1.19 KB
master	`SendReceive`	netcoreapp3.1	1.88μs	2.68ns	9.67ns	0.0159	1.19 KB
master	`SendReceive`	net472	2.32μs	0.631ns	2.36ns	0.189	1.2 KB
#5434	`SendReceive`	net6.0	1.54μs	1.05ns	4.05ns	0.0162	1.19 KB
#5434	`SendReceive`	netcoreapp3.1	1.83μs	2.12ns	7.93ns	0.0164	1.19 KB
#5434	`SendReceive`	net472	2.17μs	1.98ns	7.14ns	0.189	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.7μs	1.39ns	5ns	0.0216	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	3.85μs	2.33ns	8.73ns	0.0211	1.63 KB
master	`EnrichedLog`	net472	4.43μs	1.84ns	6.88ns	0.321	2.02 KB
#5434	`EnrichedLog`	net6.0	2.71μs	1.53ns	5.72ns	0.0217	1.58 KB
#5434	`EnrichedLog`	netcoreapp3.1	4.06μs	3ns	11.2ns	0.0222	1.63 KB
#5434	`EnrichedLog`	net472	4.68μs	0.929ns	3.22ns	0.32	2.02 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5434

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1	1.147	663.66	760.98

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	478ns	0.815ns	3.16ns	0.00801	568 B
master	`StartFinishSpan`	netcoreapp3.1	663ns	1.42ns	5.5ns	0.00793	568 B
master	`StartFinishSpan`	net472	803ns	1.57ns	6.09ns	0.0904	570 B
master	`StartFinishScope`	net6.0	590ns	1.1ns	4.11ns	0.00949	688 B
master	`StartFinishScope`	netcoreapp3.1	883ns	1.18ns	4.57ns	0.00913	688 B
master	`StartFinishScope`	net472	1μs	1.35ns	5.21ns	0.103	650 B
#5434	`StartFinishSpan`	net6.0	464ns	0.859ns	3.33ns	0.008	568 B
#5434	`StartFinishSpan`	netcoreapp3.1	760ns	1.27ns	4.75ns	0.00759	568 B
#5434	`StartFinishSpan`	net472	782ns	1.39ns	5.39ns	0.0905	570 B
#5434	`StartFinishScope`	net6.0	625ns	0.571ns	2.14ns	0.00955	688 B
#5434	`StartFinishScope`	netcoreapp3.1	896ns	1.33ns	5.15ns	0.00954	688 B
#5434	`StartFinishScope`	net472	983ns	2ns	7.74ns	0.103	650 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	646ns	0.91ns	3.52ns	0.00954	688 B
master	`RunOnMethodBegin`	netcoreapp3.1	902ns	1.23ns	4.76ns	0.00919	688 B
master	`RunOnMethodBegin`	net472	1.16μs	1.42ns	5.48ns	0.103	650 B
#5434	`RunOnMethodBegin`	net6.0	672ns	1.14ns	4.41ns	0.00974	688 B
#5434	`RunOnMethodBegin`	netcoreapp3.1	957ns	1.77ns	6.61ns	0.00932	688 B
#5434	`RunOnMethodBegin`	net472	1.11μs	2.31ns	8.94ns	0.103	650 B

andrewlock · 2024-04-12T00:31:36Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5434) (11.444M)   : 0, 11444305
    master (11.027M)   : 0, 11026822
    benchmarks/2.9.0 (11.441M)   : 0, 11440819

    section Automatic
    This PR (5434) (7.852M)   : 0, 7851824
    master (7.668M)   : 0, 7667630
    benchmarks/2.9.0 (8.279M)   : 0, 8278641

    section Trace stats
    This PR (5434) (8.153M)   : 0, 8153254
    master (7.941M)   : 0, 7940559

    section Manual
    This PR (5434) (9.779M)   : 0, 9779386
    master (9.543M)   : 0, 9542981

    section Manual + Automatic
    This PR (5434) (7.386M)   : 0, 7386185
    master (7.329M)   : 0, 7329210

    section Version Conflict
    This PR (5434) (6.714M)   : 0, 6714218
    master (6.506M)   : 0, 6505794

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5434) (9.591M)   : 0, 9591435
    master (9.868M)   : 0, 9868320
    benchmarks/2.9.0 (9.449M)   : 0, 9448631

    section Automatic
    This PR (5434) (6.662M)   : 0, 6662092
    master (6.641M)   : 0, 6641481

    section Trace stats
    This PR (5434) (7.022M)   : 0, 7022321
    master (6.996M)   : 0, 6996397

    section Manual
    This PR (5434) (8.134M)   : 0, 8134435
    master (8.395M)   : 0, 8395069

    section Manual + Automatic
    This PR (5434) (6.204M)   : 0, 6204426
    master (6.209M)   : 0, 6209484

    section Version Conflict
    This PR (5434) (5.726M)   : 0, 5725626
    master (5.724M)   : 0, 5723880

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5434) (10.086M)   : 0, 10085844
    master (9.937M)   : 0, 9937171
    benchmarks/2.9.0 (9.815M)   : 0, 9814765

    section Automatic
    This PR (5434) (7.143M)   : 0, 7142636
    master (7.202M)   : 0, 7202285
    benchmarks/2.9.0 (7.255M)   : 0, 7254797

    section Trace stats
    This PR (5434) (7.489M)   : 0, 7488643
    master (7.422M)   : 0, 7422329

    section Manual
    This PR (5434) (8.814M)   : 0, 8813699
    master (8.985M)   : 0, 8984711

    section Manual + Automatic
    This PR (5434) (6.926M)   : 0, 6926301
    master (6.966M)   : 0, 6966271

    section Version Conflict
    This PR (5434) (6.200M)   : 0, 6200237
    master (6.248M)   : 0, 6248072

chrisnas

LGTM

Pass memory_resource around

da28eb9

gleocadie requested a review from a team as a code owner April 11, 2024 18:02

github-actions bot added the area:profiler Issues related to the continous-profiler label Apr 11, 2024

chrisnas approved these changes Apr 12, 2024

View reviewed changes

gleocadie merged commit 138cf57 into master Apr 12, 2024
65 checks passed

gleocadie deleted the gleocadie/pass-memory-resource-to-provider branch April 12, 2024 06:55

github-actions bot added this to the vNext-v2 milestone Apr 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler] Pass memory_resource around #5434

[Profiler] Pass memory_resource around #5434

gleocadie commented Apr 11, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 11, 2024 •

edited

Loading

andrewlock commented Apr 11, 2024

andrewlock commented Apr 11, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5434

Raw results

Raw results

andrewlock commented Apr 12, 2024

chrisnas left a comment

[Profiler] Pass memory_resource around #5434

[Profiler] Pass memory_resource around #5434

Conversation

gleocadie commented Apr 11, 2024 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 11, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 11, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 11, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5434

Raw results

Raw results

andrewlock commented Apr 12, 2024

Throughput/Crank Report:zap:

chrisnas left a comment

Choose a reason for hiding this comment

gleocadie commented Apr 11, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 11, 2024 •

edited

Loading