[Profiler] Fix possible crash when Agent does not answer namedpipe connection #5437

chrisnas · 2024-04-12T18:16:12Z

Summary of changes

Handle Agent connection error to stop the server
Stop listening to events before stopping the services

Reason for change

Possible crash in CI

Implementation details

Test coverage

Crashing test should be valid now

Other details

andrewlock · 2024-04-12T18:39:52Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (70ms)  : 67, 72
     .   : milestone, 70,
    master - mean (72ms)  : 65, 79
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (1,015ms)  : 995, 1034
     .   : milestone, 1015,
    master - mean (1,021ms)  : 1002, 1041
     .   : milestone, 1021,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (110ms)  : 108, 113
     .   : milestone, 110,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (737ms)  : 714, 760
     .   : milestone, 737,
    master - mean (734ms)  : 713, 755
     .   : milestone, 734,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (94ms)  : 91, 97
     .   : milestone, 94,
    master - mean (93ms)  : 90, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (694ms)  : 672, 716
     .   : milestone, 694,
    master - mean (684ms)  : 660, 707
     .   : milestone, 684,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (187ms)  : 183, 191
     .   : milestone, 187,
    master - mean (187ms)  : 184, 190
     .   : milestone, 187,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (1,076ms)  : 1051, 1102
     .   : milestone, 1076,
    master - mean (1,079ms)  : 1043, 1115
     .   : milestone, 1079,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (272ms)  : 266, 277
     .   : milestone, 272,
    master - mean (271ms)  : 263, 278
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (870ms)  : 841, 900
     .   : milestone, 870,
    master - mean (867ms)  : 838, 896
     .   : milestone, 867,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5437) - mean (261ms)  : 257, 265
     .   : milestone, 261,
    master - mean (259ms)  : 253, 265
     .   : milestone, 259,

    section CallTarget+Inlining+NGEN
    This PR (5437) - mean (851ms)  : 824, 879
     .   : milestone, 851,
    master - mean (853ms)  : 831, 876
     .   : milestone, 853,

datadog-ddstaging · 2024-04-12T18:47:00Z

Datadog Report

Branch report: chrisnas/fix_etw_race_condition
Commit report: 1ec77cb
Test service: dd-trace-dotnet

✅ 0 Failed, 334199 Passed, 1817 Skipped, 41m 20.05s Wall Time

andrewlock · 2024-04-12T19:53:13Z

Benchmarks Report for tracer 🐌

Benchmarks for #5437 compared to master:

1 benchmarks are faster, with geometric mean 1.129
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.72μs	48.7ns	312ns	0.0211	0.0127	0	7.54 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	55.3ns	282ns	0.0373	0.016	0	7.64 KB
master	`StartStopWithChild`	net472	17μs	32.9ns	123ns	1.35	0.372	0.11	8.08 KB
#5437	`StartStopWithChild`	net6.0	8.68μs	47.1ns	279ns	0.0221	0.00885	0	7.53 KB
#5437	`StartStopWithChild`	netcoreapp3.1	10.5μs	54.8ns	268ns	0.0259	0.0103	0	7.64 KB
#5437	`StartStopWithChild`	net472	16.7μs	81.1ns	325ns	1.34	0.34	0.111	8.07 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	495μs	374ns	1.45μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	619μs	183ns	709ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	821μs	492ns	1.91μs	0.408	3.3 KB
#5437	`WriteAndFlushEnrichedTraces`	net6.0	476μs	187ns	725ns	0	2.7 KB
#5437	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	618μs	277ns	1.07μs	0	2.7 KB
#5437	`WriteAndFlushEnrichedTraces`	net472	815μs	368ns	1.38μs	0.406	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	170μs	135ns	522ns	0.256	18.38 KB
master	`SendRequest`	netcoreapp3.1	191μs	398ns	1.54μs	0.192	20.54 KB
master	`SendRequest`	net472	0.0003ns	0.000161ns	0.000603ns	0	0 b
#5437	`SendRequest`	net6.0	171μs	241ns	933ns	0.253	18.38 KB
#5437	`SendRequest`	netcoreapp3.1	186μs	289ns	1.12μs	0.187	20.55 KB
#5437	`SendRequest`	net472	0.0011ns	0.000284ns	0.00106ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	533μs	1.65μs	6.39μs	0.536	0	0	41.55 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	655μs	710ns	2.66μs	0.329	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	853μs	3.84μs	14.9μs	8.06	2.42	0.403	53.26 KB
#5437	`WriteAndFlushEnrichedTraces`	net6.0	540μs	581ns	2.25μs	0.548	0	0	41.68 KB
#5437	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	246ns	953ns	0.326	0	0	41.74 KB
#5437	`WriteAndFlushEnrichedTraces`	net472	824μs	2.97μs	11.5μs	8.25	2.36	0.393	53.27 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.22μs	0.557ns	2.16ns	0.011	800 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.52μs	0.515ns	1.99ns	0.0107	800 B
master	`ExecuteNonQuery`	net472	1.79μs	0.799ns	3.09ns	0.121	762 B
#5437	`ExecuteNonQuery`	net6.0	1.15μs	0.394ns	1.42ns	0.0109	800 B
#5437	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	0.434ns	1.5ns	0.0106	800 B
#5437	`ExecuteNonQuery`	net472	1.79μs	0.53ns	2.05ns	0.12	762 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.27μs	0.617ns	2.39ns	0.0146	1.02 KB
master	`CallElasticsearch`	netcoreapp3.1	1.59μs	1.11ns	4.17ns	0.0135	1.02 KB
master	`CallElasticsearch`	net472	2.48μs	1.17ns	4.36ns	0.164	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.36μs	0.707ns	2.65ns	0.0143	1 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.66μs	0.823ns	3.08ns	0.0143	1.07 KB
master	`CallElasticsearchAsync`	net472	2.58μs	0.863ns	3.34ns	0.173	1.09 KB
#5437	`CallElasticsearch`	net6.0	1.27μs	0.951ns	3.56ns	0.0145	1.02 KB
#5437	`CallElasticsearch`	netcoreapp3.1	1.72μs	0.881ns	3.41ns	0.0135	1.02 KB
#5437	`CallElasticsearch`	net472	2.48μs	1.61ns	6.22ns	0.164	1.04 KB
#5437	`CallElasticsearchAsync`	net6.0	1.42μs	1.19ns	4.45ns	0.0142	1 KB
#5437	`CallElasticsearchAsync`	netcoreapp3.1	1.76μs	0.977ns	3.52ns	0.0142	1.07 KB
#5437	`CallElasticsearchAsync`	net472	2.62μs	1.58ns	5.9ns	0.173	1.09 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.869ns	3.25ns	0.0134	944 B
master	`ExecuteAsync`	netcoreapp3.1	1.75μs	1.28ns	4.79ns	0.0122	944 B
master	`ExecuteAsync`	net472	1.79μs	1.64ns	6.34ns	0.144	907 B
#5437	`ExecuteAsync`	net6.0	1.31μs	1.35ns	5.05ns	0.0131	944 B
#5437	`ExecuteAsync`	netcoreapp3.1	1.66μs	0.998ns	3.73ns	0.0127	944 B
#5437	`ExecuteAsync`	net472	1.75μs	1.05ns	4.09ns	0.143	907 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.03μs	1.84ns	7.13ns	0.03	2.18 KB
master	`SendAsync`	netcoreapp3.1	5.09μs	2.85ns	10.7ns	0.0358	2.71 KB
master	`SendAsync`	net472	7.76μs	12.5ns	46.7ns	0.484	3.07 KB
#5437	`SendAsync`	net6.0	4.21μs	1.4ns	5.04ns	0.0314	2.18 KB
#5437	`SendAsync`	netcoreapp3.1	5.13μs	2.66ns	9.59ns	0.0359	2.71 KB
#5437	`SendAsync`	net472	7.79μs	2.88ns	11.2ns	0.487	3.07 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.45μs	0.612ns	2.37ns	0.0238	1.68 KB
master	`EnrichedLog`	netcoreapp3.1	2.28μs	1.53ns	5.93ns	0.0221	1.68 KB
master	`EnrichedLog`	net472	2.67μs	1.98ns	7.66ns	0.255	1.61 KB
#5437	`EnrichedLog`	net6.0	1.47μs	0.862ns	3.23ns	0.0236	1.68 KB
#5437	`EnrichedLog`	netcoreapp3.1	2.24μs	0.802ns	3.1ns	0.0232	1.68 KB
#5437	`EnrichedLog`	net472	2.59μs	2.59ns	9.69ns	0.254	1.61 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	273ns	1.06μs	0.0562	0	4.26 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	106ns	409ns	0.0602	0	4.26 KB
master	`EnrichedLog`	net472	150μs	250ns	967ns	0.677	0.226	4.45 KB
#5437	`EnrichedLog`	net6.0	113μs	55.6ns	215ns	0.0561	0	4.26 KB
#5437	`EnrichedLog`	netcoreapp3.1	121μs	89ns	345ns	0.0602	0	4.26 KB
#5437	`EnrichedLog`	net472	151μs	152ns	589ns	0.676	0.225	4.45 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	1.41ns	5.45ns	0.0315	2.24 KB
master	`EnrichedLog`	netcoreapp3.1	4.17μs	3.45ns	13.3ns	0.0296	2.24 KB
master	`EnrichedLog`	net472	4.85μs	1.89ns	7.34ns	0.325	2.05 KB
#5437	`EnrichedLog`	net6.0	3.11μs	1.69ns	6.09ns	0.0311	2.24 KB
#5437	`EnrichedLog`	netcoreapp3.1	4.16μs	2.61ns	9.41ns	0.0291	2.24 KB
#5437	`EnrichedLog`	net472	4.93μs	3.74ns	14.5ns	0.325	2.05 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.42μs	0.769ns	2.77ns	0.0163	1.19 KB
master	`SendReceive`	netcoreapp3.1	1.78μs	0.64ns	2.48ns	0.0161	1.19 KB
master	`SendReceive`	net472	2.18μs	1.68ns	6.51ns	0.19	1.2 KB
#5437	`SendReceive`	net6.0	1.41μs	0.531ns	1.99ns	0.0169	1.19 KB
#5437	`SendReceive`	netcoreapp3.1	1.79μs	0.87ns	3.26ns	0.0162	1.19 KB
#5437	`SendReceive`	net472	2.16μs	1.19ns	4.44ns	0.19	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.78μs	1.24ns	4.66ns	0.0222	1.58 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	1.06ns	4.1ns	0.0217	1.63 KB
master	`EnrichedLog`	net472	4.51μs	1.86ns	7.21ns	0.32	2.02 KB
#5437	`EnrichedLog`	net6.0	2.76μs	2.11ns	7.88ns	0.022	1.58 KB
#5437	`EnrichedLog`	netcoreapp3.1	3.83μs	4.76ns	18.4ns	0.021	1.63 KB
#5437	`EnrichedLog`	net472	4.53μs	3.26ns	12.6ns	0.321	2.02 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	521ns	0.668ns	2.59ns	0.00785	568 B
master	`StartFinishSpan`	netcoreapp3.1	710ns	1.32ns	5.1ns	0.00783	568 B
master	`StartFinishSpan`	net472	792ns	1.72ns	6.67ns	0.0901	570 B
master	`StartFinishScope`	net6.0	612ns	0.715ns	2.77ns	0.00953	688 B
master	`StartFinishScope`	netcoreapp3.1	835ns	2.48ns	9.62ns	0.00928	688 B
master	`StartFinishScope`	net472	996ns	2.04ns	7.89ns	0.103	650 B
#5437	`StartFinishSpan`	net6.0	476ns	2.46ns	11.5ns	0.00792	568 B
#5437	`StartFinishSpan`	netcoreapp3.1	783ns	0.943ns	3.53ns	0.00784	568 B
#5437	`StartFinishSpan`	net472	808ns	1.4ns	5.43ns	0.0905	570 B
#5437	`StartFinishScope`	net6.0	636ns	1.39ns	5.19ns	0.00955	688 B
#5437	`StartFinishScope`	netcoreapp3.1	882ns	4.1ns	15.9ns	0.00948	688 B
#5437	`StartFinishScope`	net472	997ns	1.73ns	6.68ns	0.103	650 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5437

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.129	761.97	674.73

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	762ns	0.653ns	2.44ns	0.0095	688 B
master	`RunOnMethodBegin`	netcoreapp3.1	901ns	1.05ns	4.08ns	0.00934	688 B
master	`RunOnMethodBegin`	net472	1.19μs	3.23ns	12.5ns	0.103	650 B
#5437	`RunOnMethodBegin`	net6.0	675ns	1.13ns	4.39ns	0.00977	688 B
#5437	`RunOnMethodBegin`	netcoreapp3.1	968ns	0.47ns	1.82ns	0.00941	688 B
#5437	`RunOnMethodBegin`	net472	1.1μs	2.4ns	9.3ns	0.103	650 B

andrewlock · 2024-04-12T20:12:12Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5437) (11.397M)   : 0, 11396551
    master (11.265M)   : 0, 11265396
    benchmarks/2.9.0 (11.505M)   : 0, 11505055

    section Automatic
    This PR (5437) (7.865M)   : 0, 7865091
    master (7.873M)   : 0, 7872843
    benchmarks/2.9.0 (8.298M)   : 0, 8297530

    section Trace stats
    This PR (5437) (8.191M)   : 0, 8190934
    master (8.110M)   : 0, 8110433

    section Manual
    This PR (5437) (9.951M)   : 0, 9951082
    master (10.010M)   : 0, 10009570

    section Manual + Automatic
    This PR (5437) (7.517M)   : 0, 7517081
    master (7.428M)   : 0, 7427798

    section Version Conflict
    This PR (5437) (6.808M)   : 0, 6807799
    master (6.722M)   : 0, 6722246

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5437) (9.617M)   : 0, 9617179
    master (9.626M)   : 0, 9626096
    benchmarks/2.9.0 (9.448M)   : 0, 9448007

    section Automatic
    This PR (5437) (6.635M)   : 0, 6635440
    master (6.569M)   : 0, 6568518

    section Trace stats
    This PR (5437) (6.996M)   : 0, 6996104
    master (6.938M)   : 0, 6938241

    section Manual
    This PR (5437) (8.118M)   : 0, 8117907
    master (8.120M)   : 0, 8120475

    section Manual + Automatic
    This PR (5437) (6.113M)   : 0, 6112738
    master (6.268M)   : 0, 6267828

    section Version Conflict
    This PR (5437) (5.557M)   : 0, 5556987
    master (5.663M)   : 0, 5662584

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5437) (10.069M)   : 0, 10069209
    master (10.108M)   : 0, 10108263
    benchmarks/2.9.0 (10.119M)   : 0, 10118734

    section Automatic
    This PR (5437) (7.140M)   : 0, 7139563
    master (7.267M)   : 0, 7266809
    benchmarks/2.9.0 (7.382M)   : 0, 7381600

    section Trace stats
    This PR (5437) (7.412M)   : 0, 7412145
    master (7.464M)   : 0, 7464193

    section Manual
    This PR (5437) (8.769M)   : 0, 8768694
    master (8.838M)   : 0, 8837615

    section Manual + Automatic
    This PR (5437) (6.985M)   : 0, 6984631
    master (7.026M)   : 0, 7025722

    section Version Conflict
    This PR (5437) (6.193M)   : 0, 6192554
    master (6.290M)   : 0, 6290404

gleocadie

LGTM

chrisnas requested a review from a team as a code owner April 12, 2024 18:16

github-actions bot added the area:profiler Issues related to the continous-profiler label Apr 12, 2024

chrisnas added 3 commits April 15, 2024 13:00

Fix possible crash when Agent does not answer namedpipe connection

e6f6829

missing file

c38af9e

Cleanup

1ec77cb

andrewlock force-pushed the chrisnas/fix_etw_race_condition branch from 4d8ddfb to 1ec77cb Compare April 15, 2024 12:00

gleocadie approved these changes Apr 15, 2024

View reviewed changes

andrewlock merged commit ba5dcd4 into master Apr 15, 2024
65 checks passed

andrewlock deleted the chrisnas/fix_etw_race_condition branch April 15, 2024 14:45

github-actions bot added this to the vNext-v2 milestone Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Profiler] Fix possible crash when Agent does not answer namedpipe connection #5437

[Profiler] Fix possible crash when Agent does not answer namedpipe connection #5437

chrisnas commented Apr 12, 2024

andrewlock commented Apr 12, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 12, 2024 •

edited

Loading

andrewlock commented Apr 12, 2024 •

edited

Loading

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5437

Raw results

andrewlock commented Apr 12, 2024 •

edited

Loading

gleocadie left a comment

[Profiler] Fix possible crash when Agent does not answer namedpipe connection #5437

[Profiler] Fix possible crash when Agent does not answer namedpipe connection #5437

Conversation

chrisnas commented Apr 12, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Apr 12, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Apr 12, 2024 • edited Loading

Datadog Report

andrewlock commented Apr 12, 2024 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #5437

Raw results

andrewlock commented Apr 12, 2024 • edited Loading

Throughput/Crank Report:zap:

gleocadie left a comment

Choose a reason for hiding this comment

andrewlock commented Apr 12, 2024 •

edited

Loading

datadog-ddstaging bot commented Apr 12, 2024 •

edited

Loading

andrewlock commented Apr 12, 2024 •

edited

Loading

andrewlock commented Apr 12, 2024 •

edited

Loading