[v3] Fix `SpanContextInjectorExtractorTests` to account for `tracestate` #5479

andrewlock · 2024-04-22T10:50:27Z

Summary of changes

Fixes SpanContextInjectorExtractorTests which are broken on v3

Reason for change

#5176 added support for encoding the last seen Datadog span ID in the tracestate. However, this conflicted with expectations of unit tests introduced in the v3-main branch

Implementation details

First commit refactors the unit tests to better expose the issue (by way of "better" FluentAssertion methods)
Second commit fixes the issue by accounting for tracestate

Test coverage

Same

Other details

…cestate

datadog-ddstaging · 2024-04-22T11:08:45Z

Datadog Report

Branch report: andrew/v3-public-apis/fix-unit-tests
Commit report: 9fd8db8
Test service: dd-trace-dotnet

✅ 0 Failed, 24329 Passed, 68 Skipped, 5m 23.67s Wall Time

bouwkast

Thanks :)

andrewlock · 2024-04-22T11:20:05Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (75ms)  : 62, 88
     .   : milestone, 75,
    master - mean (73ms)  : 65, 81
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (1,033ms)  : 1013, 1053
     .   : milestone, 1033,
    master - mean (1,017ms)  : 994, 1041
     .   : milestone, 1017,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (109ms)  : 105, 113
     .   : milestone, 109,
    master - mean (108ms)  : 106, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (746ms)  : 724, 767
     .   : milestone, 746,
    master - mean (729ms)  : 708, 750
     .   : milestone, 729,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (94ms)  : 90, 98
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (714ms)  : 685, 743
     .   : milestone, 714,
    master - mean (687ms)  : 663, 710
     .   : milestone, 687,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (190ms)  : 187, 193
     .   : milestone, 190,
    master - mean (190ms)  : 187, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (1,110ms)  : 1080, 1141
     .   : milestone, 1110,
    master - mean (1,097ms)  : 1068, 1126
     .   : milestone, 1097,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (276ms)  : 271, 280
     .   : milestone, 276,
    master - mean (275ms)  : 270, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (892ms)  : 869, 915
     .   : milestone, 892,
    master - mean (885ms)  : 860, 910
     .   : milestone, 885,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5479) - mean (266ms)  : 259, 273
     .   : milestone, 266,
    master - mean (264ms)  : 259, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5479) - mean (885ms)  : 859, 910
     .   : milestone, 885,
    master - mean (870ms)  : 840, 900
     .   : milestone, 870,

andrewlock · 2024-04-22T11:39:11Z

Benchmarks Report for tracer 🐌

Benchmarks for #5479 compared to master:

1 benchmarks are faster, with geometric mean 1.126
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.77μs	46.6ns	264ns	0.0259	0.0129	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	10.7μs	57.7ns	311ns	0.0257	0.0103	0	7.65 KB
master	`StartStopWithChild`	net472	17.1μs	50.2ns	188ns	1.36	0.37	0.0948	8.11 KB
#5479	`StartStopWithChild`	net6.0	8.96μs	50.9ns	356ns	0.0219	0.00877	0	7.56 KB
#5479	`StartStopWithChild`	netcoreapp3.1	10.7μs	57.7ns	311ns	0.0254	0.0101	0	7.65 KB
#5479	`StartStopWithChild`	net472	17.1μs	56.3ns	218ns	1.35	0.368	0.12	8.1 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	469μs	432ns	1.67μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	636μs	209ns	808ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	967ns	3.75μs	0.419	3.3 KB
#5479	`WriteAndFlushEnrichedTraces`	net6.0	456μs	357ns	1.34μs	0	2.7 KB
#5479	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	629μs	253ns	980ns	0	2.7 KB
#5479	`WriteAndFlushEnrichedTraces`	net472	827μs	375ns	1.45μs	0.411	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	168μs	260ns	1.01μs	0.251	18.49 KB
master	`SendRequest`	netcoreapp3.1	191μs	360ns	1.4μs	0.192	20.66 KB
master	`SendRequest`	net472	0.0152ns	0.00419ns	0.0162ns	0	0 b
#5479	`SendRequest`	net6.0	167μs	227ns	878ns	0.167	18.49 KB
#5479	`SendRequest`	netcoreapp3.1	189μs	322ns	1.25μs	0.188	20.65 KB
#5479	`SendRequest`	net472	0.000849ns	0.000239ns	0.000925ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5479

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.7 KB	41.43 KB	-269 B	-0.65%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	537μs	1.46μs	5.67μs	0.556	0	0	41.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	654μs	2.81μs	10.9μs	0.324	0	0	41.86 KB
master	`WriteAndFlushEnrichedTraces`	net472	844μs	3.75μs	14.5μs	8.42	2.66	0.443	53.27 KB
#5479	`WriteAndFlushEnrichedTraces`	net6.0	529μs	254ns	984ns	0.548	0	0	41.43 KB
#5479	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	662μs	2.04μs	7.9μs	0.331	0	0	41.93 KB
#5479	`WriteAndFlushEnrichedTraces`	net472	870μs	4.19μs	16.2μs	8.08	2.55	0.425	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.14μs	0.565ns	2.11ns	0.0115	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	0.39ns	1.41ns	0.0104	808 B
master	`ExecuteNonQuery`	net472	1.81μs	0.541ns	2.09ns	0.122	770 B
#5479	`ExecuteNonQuery`	net6.0	1.17μs	0.436ns	1.69ns	0.0117	808 B
#5479	`ExecuteNonQuery`	netcoreapp3.1	1.56μs	0.579ns	2.17ns	0.011	808 B
#5479	`ExecuteNonQuery`	net472	1.81μs	2.54ns	9.51ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5479

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.126	1,540.69	1,368.87

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.31μs	0.814ns	3.05ns	0.0144	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.518ns	2.01ns	0.0141	1.03 KB
master	`CallElasticsearch`	net472	2.51μs	1.22ns	4.56ns	0.165	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.54μs	0.704ns	2.64ns	0.0139	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.74μs	3.08ns	11.9ns	0.0147	1.08 KB
master	`CallElasticsearchAsync`	net472	2.62μs	1.87ns	7.23ns	0.174	1.1 KB
#5479	`CallElasticsearch`	net6.0	1.27μs	1.01ns	3.92ns	0.0145	1.03 KB
#5479	`CallElasticsearch`	netcoreapp3.1	1.62μs	0.721ns	2.7ns	0.0138	1.03 KB
#5479	`CallElasticsearch`	net472	2.62μs	1.07ns	3.87ns	0.165	1.04 KB
#5479	`CallElasticsearchAsync`	net6.0	1.37μs	0.435ns	1.63ns	0.0144	1.01 KB
#5479	`CallElasticsearchAsync`	netcoreapp3.1	1.73μs	1.51ns	5.65ns	0.0146	1.08 KB
#5479	`CallElasticsearchAsync`	net472	2.64μs	1.42ns	5.11ns	0.174	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.28μs	0.711ns	2.75ns	0.0135	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.76μs	0.779ns	3.02ns	0.0123	952 B
master	`ExecuteAsync`	net472	1.81μs	0.82ns	3.18ns	0.145	915 B
#5479	`ExecuteAsync`	net6.0	1.33μs	0.88ns	3.29ns	0.0134	952 B
#5479	`ExecuteAsync`	netcoreapp3.1	1.68μs	0.649ns	2.43ns	0.0126	952 B
#5479	`ExecuteAsync`	net472	1.87μs	0.711ns	2.75ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.22μs	1.72ns	6.21ns	0.0316	2.27 KB
master	`SendAsync`	netcoreapp3.1	5.18μs	1.97ns	7.65ns	0.0392	2.81 KB
master	`SendAsync`	net472	7.83μs	2ns	7.48ns	0.502	3.18 KB
#5479	`SendAsync`	net6.0	4.19μs	1.32ns	4.96ns	0.0312	2.27 KB
#5479	`SendAsync`	netcoreapp3.1	5.26μs	1.95ns	7.29ns	0.037	2.81 KB
#5479	`SendAsync`	net472	7.74μs	3.03ns	11.7ns	0.503	3.18 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.56μs	0.265ns	0.919ns	0.0244	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	2.28μs	1.74ns	6.74ns	0.0232	1.7 KB
master	`EnrichedLog`	net472	2.75μs	1.83ns	6.33ns	0.257	1.62 KB
#5479	`EnrichedLog`	net6.0	1.51μs	0.913ns	3.42ns	0.0234	1.7 KB
#5479	`EnrichedLog`	netcoreapp3.1	2.36μs	1.28ns	4.61ns	0.0234	1.7 KB
#5479	`EnrichedLog`	net472	2.8μs	0.974ns	3.64ns	0.257	1.62 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	112μs	181ns	702ns	0.0559	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	179ns	691ns	0	0	4.28 KB
master	`EnrichedLog`	net472	149μs	136ns	527ns	0.684	0.228	4.46 KB
#5479	`EnrichedLog`	net6.0	113μs	176ns	680ns	0.0564	0	4.28 KB
#5479	`EnrichedLog`	netcoreapp3.1	120μs	284ns	1.1μs	0.0609	0	4.28 KB
#5479	`EnrichedLog`	net472	150μs	207ns	801ns	0.68	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.12μs	0.916ns	3.3ns	0.0326	2.25 KB
master	`EnrichedLog`	netcoreapp3.1	4.18μs	2.9ns	11.2ns	0.0295	2.25 KB
master	`EnrichedLog`	net472	4.84μs	1.77ns	6.84ns	0.329	2.07 KB
#5479	`EnrichedLog`	net6.0	3.05μs	1.38ns	5.16ns	0.0322	2.25 KB
#5479	`EnrichedLog`	netcoreapp3.1	4.27μs	3.12ns	12.1ns	0.03	2.25 KB
#5479	`EnrichedLog`	net472	4.83μs	1.63ns	6.31ns	0.328	2.07 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.49μs	0.721ns	2.79ns	0.0164	1.2 KB
master	`SendReceive`	netcoreapp3.1	1.8μs	2.58ns	9.99ns	0.0161	1.2 KB
master	`SendReceive`	net472	2.23μs	0.958ns	3.71ns	0.191	1.2 KB
#5479	`SendReceive`	net6.0	1.41μs	0.319ns	1.1ns	0.017	1.2 KB
#5479	`SendReceive`	netcoreapp3.1	1.84μs	0.791ns	2.74ns	0.0166	1.2 KB
#5479	`SendReceive`	net472	2.15μs	1.24ns	4.8ns	0.191	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.74μs	0.766ns	2.87ns	0.022	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.96μs	1.78ns	6.88ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.49μs	1.55ns	6.02ns	0.323	2.04 KB
#5479	`EnrichedLog`	net6.0	2.79μs	0.853ns	3.19ns	0.0223	1.6 KB
#5479	`EnrichedLog`	netcoreapp3.1	4.05μs	1.07ns	3.99ns	0.0222	1.65 KB
#5479	`EnrichedLog`	net472	4.58μs	2.7ns	10.4ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	506ns	0.323ns	1.25ns	0.00802	576 B
master	`StartFinishSpan`	netcoreapp3.1	783ns	0.845ns	3.27ns	0.00768	576 B
master	`StartFinishSpan`	net472	812ns	0.864ns	3.35ns	0.0917	578 B
master	`StartFinishScope`	net6.0	603ns	0.537ns	2.01ns	0.00976	696 B
master	`StartFinishScope`	netcoreapp3.1	929ns	1ns	3.89ns	0.00923	696 B
master	`StartFinishScope`	net472	1.01μs	1.01ns	3.9ns	0.104	658 B
#5479	`StartFinishSpan`	net6.0	550ns	0.341ns	1.18ns	0.00798	576 B
#5479	`StartFinishSpan`	netcoreapp3.1	718ns	0.663ns	2.57ns	0.00779	576 B
#5479	`StartFinishSpan`	net472	781ns	0.705ns	2.73ns	0.0917	578 B
#5479	`StartFinishScope`	net6.0	580ns	0.263ns	0.95ns	0.00981	696 B
#5479	`StartFinishScope`	netcoreapp3.1	880ns	0.754ns	2.92ns	0.00928	696 B
#5479	`StartFinishScope`	net472	1.03μs	0.753ns	2.92ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	699ns	0.605ns	2.34ns	0.00986	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	989ns	1.28ns	4.97ns	0.00929	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.887ns	3.44ns	0.105	658 B
#5479	`RunOnMethodBegin`	net6.0	705ns	0.353ns	1.37ns	0.00958	696 B
#5479	`RunOnMethodBegin`	netcoreapp3.1	1.03μs	0.828ns	3.21ns	0.00926	696 B
#5479	`RunOnMethodBegin`	net472	1.15μs	0.645ns	2.42ns	0.104	658 B

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added 2 commits April 22, 2024 11:47

Refactor unit tests to expose errors more easily

89954fb

Fix SpanContextInjectorExtractorTests expectations to account for tra…

9fd8db8

…cestate

andrewlock added the area:tests unit tests, integration tests label Apr 22, 2024

andrewlock requested a review from a team as a code owner April 22, 2024 10:50

bouwkast approved these changes Apr 22, 2024

View reviewed changes

zacharycmontoya approved these changes Apr 22, 2024

View reviewed changes

andrewlock merged commit 3fe36f1 into v3-main Apr 22, 2024
57 of 65 checks passed

andrewlock deleted the andrew/v3-public-apis/fix-unit-tests branch April 22, 2024 12:16

andrewlock added this to the vNext-v3 milestone Apr 22, 2024

andrewlock added a commit that referenced this pull request May 1, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

f9c98f0

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jun 5, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

4be10b6

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 1, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

ef6e948

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 1, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

d473980

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 2, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

ea621dc

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 2, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

5806e58

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 2, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

45b6176

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 3, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

660c85b

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 4, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

3d25035

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

andrewlock added a commit that referenced this pull request Jul 4, 2024

[v3] Fix SpanContextInjectorExtractorTests to account for `tracesta…

69334b7

…te` (#5479) * Refactor unit tests to expose errors more easily * Fix SpanContextInjectorExtractorTests expectations to account for tracestate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v3] Fix `SpanContextInjectorExtractorTests` to account for `tracestate` #5479

[v3] Fix `SpanContextInjectorExtractorTests` to account for `tracestate` #5479

andrewlock commented Apr 22, 2024

datadog-ddstaging bot commented Apr 22, 2024 •

edited

Loading

bouwkast left a comment

andrewlock commented Apr 22, 2024

andrewlock commented Apr 22, 2024

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5479

Raw results

Raw results

Faster 🎉 in #5479

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

[v3] Fix SpanContextInjectorExtractorTests to account for tracestate #5479

[v3] Fix SpanContextInjectorExtractorTests to account for tracestate #5479

Conversation

andrewlock commented Apr 22, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Apr 22, 2024 • edited Loading

Datadog Report

bouwkast left a comment

Choose a reason for hiding this comment

andrewlock commented Apr 22, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Apr 22, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #5479

Raw results

Raw results

Faster 🎉 in #5479

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

[v3] Fix `SpanContextInjectorExtractorTests` to account for `tracestate` #5479

[v3] Fix `SpanContextInjectorExtractorTests` to account for `tracestate` #5479

datadog-ddstaging bot commented Apr 22, 2024 •

edited

Loading