"Manually" install MSI dependencies instead of using choco install #5553

andrewlock · 2024-05-10T16:16:42Z

Summary of changes

Adds a helper step for installing MSIs
Update the func.exe and cppcheck installers to use the helper

Reason for change

We've been seeing some 429 Too Many Requests coming from chocolatey. We only install 2 things with it, so installing the MSIs directly is easier than trying to counteract that/handle commercial licensing etc

Implementation details

Checked what MSI we were installing (fixed for cppcheck and floating for azure functions) and installed them.

We could directly install cppcheck on the hosted agents, but this was easier for now and will be easier to update if needs be. We can always re-evaluate.

We don't want to pre-install the Azure functions tools, as we want to make sure we're testing with the latest (for now)

Test coverage

Ran a test build here and all good

Other details

We're getting a lot of 429s from the mcr docker repo, so that's next in line, but harder to solve...

This reverts commit 5603b4b.

datadog-ddstaging · 2024-05-10T16:31:56Z

Datadog Report

Branch report: andrew/ci/manual-choco-install
Commit report: 2ff87a3
Test service: dd-trace-dotnet

✅ 0 Failed, 332958 Passed, 1557 Skipped, 13h 27m 53.04s Total Time

andrewlock · 2024-05-10T16:40:55Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (76ms)  : 64, 89
     .   : milestone, 76,
    master - mean (73ms)  : 64, 82
     .   : milestone, 73,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (1,026ms)  : 1000, 1052
     .   : milestone, 1026,
    master - mean (1,015ms)  : 995, 1035
     .   : milestone, 1015,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (111ms)  : 106, 115
     .   : milestone, 111,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (741ms)  : 714, 769
     .   : milestone, 741,
    master - mean (736ms)  : 713, 758
     .   : milestone, 736,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (94ms)  : 92, 97
     .   : milestone, 94,
    master - mean (94ms)  : 91, 97
     .   : milestone, 94,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (696ms)  : 673, 719
     .   : milestone, 696,
    master - mean (686ms)  : 665, 707
     .   : milestone, 686,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (190ms)  : 187, 194
     .   : milestone, 190,
    master - mean (190ms)  : 188, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (1,089ms)  : 1060, 1118
     .   : milestone, 1089,
    master - mean (1,086ms)  : 1065, 1107
     .   : milestone, 1086,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (277ms)  : 271, 282
     .   : milestone, 277,
    master - mean (275ms)  : 272, 278
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (885ms)  : 864, 906
     .   : milestone, 885,
    master - mean (894ms)  : 870, 918
     .   : milestone, 894,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5553) - mean (266ms)  : 259, 272
     .   : milestone, 266,
    master - mean (264ms)  : 261, 267
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5553) - mean (874ms)  : 847, 900
     .   : milestone, 874,
    master - mean (863ms)  : 840, 886
     .   : milestone, 863,

andrewlock · 2024-05-10T16:53:32Z

Benchmarks Report for tracer 🐌

Benchmarks for #5553 compared to master:

2 benchmarks are faster, with geometric mean 1.159
1 benchmarks are slower, with geometric mean 1.142
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	9.01μs	48.7ns	263ns	0.0217	0.00868	0	7.55 KB
master	`StartStopWithChild`	netcoreapp3.1	11.3μs	67.5ns	641ns	0.0215	0.0108	0	7.66 KB
master	`StartStopWithChild`	net472	17.2μs	56.4ns	219ns	1.37	0.382	0.0954	8.09 KB
#5553	`StartStopWithChild`	net6.0	8.84μs	46.1ns	226ns	0.0235	0.00938	0	7.55 KB
#5553	`StartStopWithChild`	netcoreapp3.1	10.8μs	60.6ns	379ns	0.0317	0.0159	0	7.64 KB
#5553	`StartStopWithChild`	net472	17μs	42.3ns	164ns	1.38	0.381	0.101	8.1 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	457μs	199ns	716ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	623μs	261ns	1.01μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	834μs	753ns	2.91μs	0.417	3.3 KB
#5553	`WriteAndFlushEnrichedTraces`	net6.0	461μs	230ns	892ns	0	2.7 KB
#5553	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	632μs	210ns	784ns	0	2.7 KB
#5553	`WriteAndFlushEnrichedTraces`	net472	832μs	398ns	1.54μs	0.414	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	168μs	268ns	1.04μs	0.249	18.49 KB
master	`SendRequest`	netcoreapp3.1	190μs	269ns	1.04μs	0.189	20.65 KB
master	`SendRequest`	net472	0.000792ns	0.000219ns	0.000821ns	0	0 b
#5553	`SendRequest`	net6.0	172μs	178ns	667ns	0.258	18.49 KB
#5553	`SendRequest`	netcoreapp3.1	192μs	355ns	1.38μs	0.192	20.65 KB
#5553	`SendRequest`	net472	0.000865ns	0.000256ns	0.000925ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #5553

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.82 KB	42.09 KB	268 B	0.64%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	553μs	483ns	1.67μs	0.573	0	0	41.43 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	1.64μs	6.37μs	0.322	0	0	41.82 KB
master	`WriteAndFlushEnrichedTraces`	net472	855μs	4.1μs	16.9μs	8.13	2.57	0.428	53.24 KB
#5553	`WriteAndFlushEnrichedTraces`	net6.0	557μs	244ns	914ns	0.558	0	0	41.59 KB
#5553	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	666μs	2.37μs	9.16μs	0.331	0	0	42.09 KB
#5553	`WriteAndFlushEnrichedTraces`	net472	847μs	4.08μs	15.8μs	8.33	2.5	0.417	53.28 KB

Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5553

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0	1.181	1,333.00	1,128.82

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.33μs	0.651ns	2.52ns	0.0113	808 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.56μs	1.23ns	4.76ns	0.0109	808 B
master	`ExecuteNonQuery`	net472	1.86μs	0.815ns	3.16ns	0.122	770 B
#5553	`ExecuteNonQuery`	net6.0	1.13μs	0.556ns	2.15ns	0.0114	808 B
#5553	`ExecuteNonQuery`	netcoreapp3.1	1.56μs	0.867ns	3.24ns	0.0109	808 B
#5553	`ExecuteNonQuery`	net472	1.8μs	0.848ns	3.17ns	0.122	770 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.26μs	0.765ns	2.86ns	0.0146	1.03 KB
master	`CallElasticsearch`	netcoreapp3.1	1.66μs	1.42ns	5.49ns	0.0134	1.03 KB
master	`CallElasticsearch`	net472	2.47μs	2.31ns	8.93ns	0.165	1.04 KB
master	`CallElasticsearchAsync`	net6.0	1.34μs	0.766ns	2.87ns	0.0142	1.01 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.71μs	0.617ns	2.22ns	0.0145	1.08 KB
master	`CallElasticsearchAsync`	net472	2.69μs	1.31ns	5.07ns	0.174	1.1 KB
#5553	`CallElasticsearch`	net6.0	1.39μs	0.937ns	3.51ns	0.014	1.03 KB
#5553	`CallElasticsearch`	netcoreapp3.1	1.66μs	1.31ns	5.09ns	0.014	1.03 KB
#5553	`CallElasticsearch`	net472	2.61μs	1.2ns	4.47ns	0.166	1.04 KB
#5553	`CallElasticsearchAsync`	net6.0	1.35μs	0.765ns	2.86ns	0.0142	1.01 KB
#5553	`CallElasticsearchAsync`	netcoreapp3.1	1.7μs	1.08ns	4.02ns	0.0144	1.08 KB
#5553	`CallElasticsearchAsync`	net472	2.61μs	1.83ns	7.1ns	0.174	1.1 KB

Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5553

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.138	1,426.50	1,253.96

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.43μs	0.385ns	1.44ns	0.0129	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.7μs	0.731ns	2.83ns	0.0128	952 B
master	`ExecuteAsync`	net472	1.79μs	0.4ns	1.5ns	0.145	915 B
#5553	`ExecuteAsync`	net6.0	1.25μs	0.845ns	3.27ns	0.0131	952 B
#5553	`ExecuteAsync`	netcoreapp3.1	1.79μs	1.39ns	5.2ns	0.0126	952 B
#5553	`ExecuteAsync`	net472	1.74μs	0.985ns	3.82ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.23μs	1.97ns	7.12ns	0.0315	2.27 KB
master	`SendAsync`	netcoreapp3.1	5.13μs	2.48ns	8.94ns	0.0385	2.81 KB
master	`SendAsync`	net472	7.92μs	2.13ns	8.25ns	0.503	3.18 KB
#5553	`SendAsync`	net6.0	4.23μs	1.31ns	4.71ns	0.0318	2.27 KB
#5553	`SendAsync`	netcoreapp3.1	5.15μs	3.04ns	11.4ns	0.0387	2.81 KB
#5553	`SendAsync`	net472	7.91μs	4.14ns	16ns	0.502	3.18 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.51μs	0.654ns	2.53ns	0.0235	1.7 KB
master	`EnrichedLog`	netcoreapp3.1	2.21μs	1.07ns	3.99ns	0.0232	1.7 KB
master	`EnrichedLog`	net472	2.65μs	2.63ns	10.2ns	0.257	1.62 KB
#5553	`EnrichedLog`	net6.0	1.62μs	4.76ns	17.8ns	0.0239	1.7 KB
#5553	`EnrichedLog`	netcoreapp3.1	2.3μs	1.04ns	3.91ns	0.0235	1.7 KB
#5553	`EnrichedLog`	net472	2.71μs	5.26ns	18.9ns	0.258	1.62 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	226ns	875ns	0.0562	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	179ns	694ns	0.0599	0	4.28 KB
master	`EnrichedLog`	net472	150μs	269ns	1.04μs	0.674	0.225	4.46 KB
#5553	`EnrichedLog`	net6.0	113μs	220ns	795ns	0.056	0	4.28 KB
#5553	`EnrichedLog`	netcoreapp3.1	119μs	191ns	740ns	0.06	0	4.28 KB
#5553	`EnrichedLog`	net472	152μs	70.9ns	275ns	0.68	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.12μs	0.997ns	3.73ns	0.0316	2.25 KB
master	`EnrichedLog`	netcoreapp3.1	4.32μs	0.749ns	2.59ns	0.0303	2.25 KB
master	`EnrichedLog`	net472	4.94μs	1.84ns	7.12ns	0.328	2.07 KB
#5553	`EnrichedLog`	net6.0	3.1μs	1.04ns	3.88ns	0.0325	2.25 KB
#5553	`EnrichedLog`	netcoreapp3.1	4.39μs	1.52ns	5.9ns	0.0307	2.25 KB
#5553	`EnrichedLog`	net472	4.87μs	1.47ns	5.69ns	0.327	2.07 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.44μs	1.05ns	3.93ns	0.0167	0	1.2 KB
master	`SendReceive`	netcoreapp3.1	1.79μs	0.772ns	2.78ns	0.0161	0	1.2 KB
master	`SendReceive`	net472	2.27μs	2.61ns	10.1ns	0.19	0.0011	1.2 KB
#5553	`SendReceive`	net6.0	1.53μs	1.06ns	3.81ns	0.0164	0	1.2 KB
#5553	`SendReceive`	netcoreapp3.1	1.81μs	0.707ns	2.74ns	0.0164	0	1.2 KB
#5553	`SendReceive`	net472	2.35μs	1.32ns	5.12ns	0.191	0	1.2 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.82μs	0.977ns	3.66ns	0.0226	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.93μs	1.84ns	7.13ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.45μs	2.02ns	7.82ns	0.323	2.04 KB
#5553	`EnrichedLog`	net6.0	2.74μs	1.35ns	5.06ns	0.0219	1.6 KB
#5553	`EnrichedLog`	netcoreapp3.1	3.83μs	3.07ns	11.9ns	0.0224	1.65 KB
#5553	`EnrichedLog`	net472	4.39μs	2.78ns	10.8ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	534ns	0.273ns	1.02ns	0.00804	576 B
master	`StartFinishSpan`	netcoreapp3.1	763ns	0.48ns	1.86ns	0.00767	576 B
master	`StartFinishSpan`	net472	769ns	0.318ns	1.23ns	0.0917	578 B
master	`StartFinishScope`	net6.0	624ns	0.315ns	1.22ns	0.00982	696 B
master	`StartFinishScope`	netcoreapp3.1	869ns	1.93ns	7.49ns	0.00919	696 B
master	`StartFinishScope`	net472	975ns	1.31ns	5.09ns	0.104	658 B
#5553	`StartFinishSpan`	net6.0	550ns	0.297ns	1.03ns	0.008	576 B
#5553	`StartFinishSpan`	netcoreapp3.1	713ns	0.829ns	3.1ns	0.00788	576 B
#5553	`StartFinishSpan`	net472	805ns	0.562ns	2.18ns	0.0915	578 B
#5553	`StartFinishScope`	net6.0	603ns	0.121ns	0.454ns	0.00966	696 B
#5553	`StartFinishScope`	netcoreapp3.1	815ns	0.48ns	1.66ns	0.00948	696 B
#5553	`StartFinishScope`	net472	1.01μs	0.438ns	1.7ns	0.105	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5553

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.142	610.77	697.48

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	611ns	0.201ns	0.778ns	0.00982	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	956ns	1.03ns	3.98ns	0.00949	696 B
master	`RunOnMethodBegin`	net472	1.2μs	0.608ns	2.28ns	0.104	658 B
#5553	`RunOnMethodBegin`	net6.0	699ns	0.693ns	2.68ns	0.00987	696 B
#5553	`RunOnMethodBegin`	netcoreapp3.1	961ns	0.818ns	3.17ns	0.00931	696 B
#5553	`RunOnMethodBegin`	net472	1.17μs	0.816ns	3.16ns	0.104	658 B

andrewlock · 2024-05-10T17:03:23Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5553) (11.811M)   : 0, 11810890
    master (11.852M)   : 0, 11852318
    benchmarks/2.9.0 (11.974M)   : 0, 11974446

    section Automatic
    This PR (5553) (8.104M)   : 0, 8104197
    master (8.096M)   : 0, 8095817
    benchmarks/2.9.0 (8.575M)   : 0, 8575488

    section Trace stats
    master (8.336M)   : 0, 8336370

    section Manual
    This PR (5553) (10.221M)   : 0, 10220919
    master (10.282M)   : 0, 10281771

    section Manual + Automatic
    This PR (5553) (7.657M)   : 0, 7657047
    master (7.622M)   : 0, 7622164

    section Version Conflict
    master (6.832M)   : 0, 6832211

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5553) (9.727M)   : 0, 9726923
    master (9.632M)   : 0, 9632001
    benchmarks/2.9.0 (9.439M)   : 0, 9439439

    section Automatic
    This PR (5553) (6.546M)   : 0, 6545924
    master (6.560M)   : 0, 6559833

    section Trace stats
    master (6.991M)   : 0, 6990816

    section Manual
    This PR (5553) (8.175M)   : 0, 8175458
    master (8.126M)   : 0, 8126263

    section Manual + Automatic
    This PR (5553) (6.173M)   : 0, 6173341
    master (6.100M)   : 0, 6100102

    section Version Conflict
    master (5.850M)   : 0, 5849806

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5553) (10.158M)   : 0, 10158101
    master (9.789M)   : 0, 9788902
    benchmarks/2.9.0 (10.146M)   : 0, 10145550

    section Automatic
    This PR (5553) (7.091M)   : 0, 7091347
    master (6.912M)   : 0, 6911889
    benchmarks/2.9.0 (7.352M)   : 0, 7352284

    section Trace stats
    master (7.330M)   : 0, 7330202

    section Manual
    This PR (5553) (8.699M)   : 0, 8699390
    master (8.487M)   : 0, 8487180

    section Manual + Automatic
    This PR (5553) (6.883M)   : 0, 6882503
    master (6.685M)   : 0, 6685303

    section Version Conflict
    master (6.080M)   : 0, 6080138

andrewlock added 5 commits May 10, 2024 16:17

Add "install MSI" helper for pipeline

17a4b32

Install cppcheck using MSI directly

1c89a56

TESTING cppcheck

5603b4b

Install Azure functions using the MSI instead of chocolatey

180369b

Revert "TESTING cppcheck"

2ff87a3

This reverts commit 5603b4b.

andrewlock requested a review from a team as a code owner May 10, 2024 16:16

github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label May 10, 2024

lucaspimentel approved these changes May 10, 2024

View reviewed changes

lucaspimentel requested a review from a team May 10, 2024 17:44

kevingosse approved these changes May 15, 2024

View reviewed changes

andrewlock merged commit 53a2313 into master May 15, 2024
57 checks passed

andrewlock deleted the andrew/ci/manual-choco-install branch May 15, 2024 08:56

github-actions bot added this to the vNext-v2 milestone May 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"Manually" install MSI dependencies instead of using choco install #5553

"Manually" install MSI dependencies instead of using choco install #5553

andrewlock commented May 10, 2024

datadog-ddstaging bot commented May 10, 2024 •

edited

Loading

andrewlock commented May 10, 2024

andrewlock commented May 10, 2024

Raw results

Raw results

Raw results

More allocations ⚠️ in #5553

Raw results

Faster 🎉 in #5553

Raw results

Raw results

Faster 🎉 in #5553

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5553

Raw results

andrewlock commented May 10, 2024

"Manually" install MSI dependencies instead of using choco install #5553

"Manually" install MSI dependencies instead of using choco install #5553

Conversation

andrewlock commented May 10, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented May 10, 2024 • edited Loading

Datadog Report

andrewlock commented May 10, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented May 10, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #5553

Raw results

Faster 🎉 in #5553

Raw results

Raw results

Faster 🎉 in #5553

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #5553

Raw results

andrewlock commented May 10, 2024

Throughput/Crank Report:zap:

datadog-ddstaging bot commented May 10, 2024 •

edited

Loading